IntelFrameworkModulePkg BootMngr: Fix potential read over memory boundary

[mirror_edk2.git] / IntelFrameworkModulePkg / Universal / BdsDxe / BootMngr / BootManager.c

diff --git a/IntelFrameworkModulePkg/Universal/BdsDxe/BootMngr/BootManager.c b/IntelFrameworkModulePkg/Universal/BdsDxe/BootMngr/BootManager.c
index 978959d6e7b6a35a37cc7369605b57472625b5dc..6efd783ab21957e5b71c5b1393dcdaa06264416e 100644 (file)
--- a/IntelFrameworkModulePkg/Universal/BdsDxe/BootMngr/BootManager.c
+++ b/IntelFrameworkModulePkg/Universal/BdsDxe/BootMngr/BootManager.c
@@ -319,8 +319,9 @@ CallBootManager (
 \r
     TempStr = DevicePathToStr (Option->DevicePath);\r
     HelpSize = StrSize (TempStr) + StrSize (L"Device Path : ");\r
-    HelpString = AllocateCopyPool (HelpSize, L"Device Path : ");\r
+    HelpString = AllocateZeroPool (HelpSize);\r
     ASSERT (HelpString != NULL);\r
+    StrCatS (HelpString, HelpSize / sizeof (CHAR16), L"Device Path : ");\r
     StrCatS (HelpString, HelpSize / sizeof (CHAR16), TempStr);\r
 \r
     HelpToken = HiiSetString (HiiHandle, 0, HelpString, NULL);\r