]> git.proxmox.com Git - mirror_edk2.git/blobdiff - MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.c
MdeModulePkg: Apply uncrustify changes
[mirror_edk2.git] / MdeModulePkg / Bus / Usb / UsbKbDxe / EfiKey.c
index 27685995c238e01d1edcf9482639825336542432..e889f422bbf748fbf2db945a0e4a5f434b78aca8 100644 (file)
@@ -13,7 +13,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 //\r
 // USB Keyboard Driver Global Variables\r
 //\r
-EFI_DRIVER_BINDING_PROTOCOL gUsbKeyboardDriverBinding = {\r
+EFI_DRIVER_BINDING_PROTOCOL  gUsbKeyboardDriverBinding = {\r
   USBKeyboardDriverBindingSupported,\r
   USBKeyboardDriverBindingStart,\r
   USBKeyboardDriverBindingStop,\r
@@ -37,11 +37,11 @@ EFI_DRIVER_BINDING_PROTOCOL gUsbKeyboardDriverBinding = {
 EFI_STATUS\r
 EFIAPI\r
 USBKeyboardDriverBindingEntryPoint (\r
-  IN EFI_HANDLE           ImageHandle,\r
-  IN EFI_SYSTEM_TABLE     *SystemTable\r
+  IN EFI_HANDLE        ImageHandle,\r
+  IN EFI_SYSTEM_TABLE  *SystemTable\r
   )\r
 {\r
-  EFI_STATUS              Status;\r
+  EFI_STATUS  Status;\r
 \r
   Status = EfiLibInstallDriverBindingComponentName2 (\r
              ImageHandle,\r
@@ -70,13 +70,13 @@ USBKeyboardDriverBindingEntryPoint (
 EFI_STATUS\r
 EFIAPI\r
 USBKeyboardDriverBindingSupported (\r
-  IN EFI_DRIVER_BINDING_PROTOCOL    *This,\r
-  IN EFI_HANDLE                     Controller,\r
-  IN EFI_DEVICE_PATH_PROTOCOL       *RemainingDevicePath\r
+  IN EFI_DRIVER_BINDING_PROTOCOL  *This,\r
+  IN EFI_HANDLE                   Controller,\r
+  IN EFI_DEVICE_PATH_PROTOCOL     *RemainingDevicePath\r
   )\r
 {\r
-  EFI_STATUS          Status;\r
-  EFI_USB_IO_PROTOCOL *UsbIo;\r
+  EFI_STATUS           Status;\r
+  EFI_USB_IO_PROTOCOL  *UsbIo;\r
 \r
   //\r
   // Check if USB I/O Protocol is attached on the controller handle.\r
@@ -84,7 +84,7 @@ USBKeyboardDriverBindingSupported (
   Status = gBS->OpenProtocol (\r
                   Controller,\r
                   &gEfiUsbIoProtocolGuid,\r
-                  (VOID **) &UsbIo,\r
+                  (VOID **)&UsbIo,\r
                   This->DriverBindingHandle,\r
                   Controller,\r
                   EFI_OPEN_PROTOCOL_BY_DRIVER\r
@@ -133,22 +133,22 @@ USBKeyboardDriverBindingSupported (
 EFI_STATUS\r
 EFIAPI\r
 USBKeyboardDriverBindingStart (\r
-  IN EFI_DRIVER_BINDING_PROTOCOL    *This,\r
-  IN EFI_HANDLE                     Controller,\r
-  IN EFI_DEVICE_PATH_PROTOCOL       *RemainingDevicePath\r
+  IN EFI_DRIVER_BINDING_PROTOCOL  *This,\r
+  IN EFI_HANDLE                   Controller,\r
+  IN EFI_DEVICE_PATH_PROTOCOL     *RemainingDevicePath\r
   )\r
 {\r
-  EFI_STATUS                    Status;\r
-  EFI_USB_IO_PROTOCOL           *UsbIo;\r
-  USB_KB_DEV                    *UsbKeyboardDevice;\r
-  UINT8                         EndpointNumber;\r
-  EFI_USB_ENDPOINT_DESCRIPTOR   EndpointDescriptor;\r
-  UINT8                         Index;\r
-  UINT8                         EndpointAddr;\r
-  UINT8                         PollingInterval;\r
-  UINT8                         PacketSize;\r
-  BOOLEAN                       Found;\r
-  EFI_TPL                       OldTpl;\r
+  EFI_STATUS                   Status;\r
+  EFI_USB_IO_PROTOCOL          *UsbIo;\r
+  USB_KB_DEV                   *UsbKeyboardDevice;\r
+  UINT8                        EndpointNumber;\r
+  EFI_USB_ENDPOINT_DESCRIPTOR  EndpointDescriptor;\r
+  UINT8                        Index;\r
+  UINT8                        EndpointAddr;\r
+  UINT8                        PollingInterval;\r
+  UINT8                        PacketSize;\r
+  BOOLEAN                      Found;\r
+  EFI_TPL                      OldTpl;\r
 \r
   OldTpl = gBS->RaiseTPL (TPL_CALLBACK);\r
   //\r
@@ -157,7 +157,7 @@ USBKeyboardDriverBindingStart (
   Status = gBS->OpenProtocol (\r
                   Controller,\r
                   &gEfiUsbIoProtocolGuid,\r
-                  (VOID **) &UsbIo,\r
+                  (VOID **)&UsbIo,\r
                   This->DriverBindingHandle,\r
                   Controller,\r
                   EFI_OPEN_PROTOCOL_BY_DRIVER\r
@@ -175,7 +175,7 @@ USBKeyboardDriverBindingStart (
   Status = gBS->OpenProtocol (\r
                   Controller,\r
                   &gEfiDevicePathProtocolGuid,\r
-                  (VOID **) &UsbKeyboardDevice->DevicePath,\r
+                  (VOID **)&UsbKeyboardDevice->DevicePath,\r
                   This->DriverBindingHandle,\r
                   Controller,\r
                   EFI_OPEN_PROTOCOL_GET_PROTOCOL\r
@@ -184,6 +184,7 @@ USBKeyboardDriverBindingStart (
   if (EFI_ERROR (Status)) {\r
     goto ErrorExit;\r
   }\r
+\r
   //\r
   // Report that the USB keyboard is being enabled\r
   //\r
@@ -215,22 +216,23 @@ USBKeyboardDriverBindingStart (
   EndpointNumber = UsbKeyboardDevice->InterfaceDescriptor.NumEndpoints;\r
 \r
   //\r
-  // Traverse endpoints to find interrupt endpoint\r
+  // Traverse endpoints to find interrupt endpoint IN\r
   //\r
   Found = FALSE;\r
   for (Index = 0; Index < EndpointNumber; Index++) {\r
-\r
     UsbIo->UsbGetEndpointDescriptor (\r
              UsbIo,\r
              Index,\r
              &EndpointDescriptor\r
              );\r
 \r
-    if ((EndpointDescriptor.Attributes & (BIT0 | BIT1)) == USB_ENDPOINT_INTERRUPT) {\r
+    if (((EndpointDescriptor.Attributes & (BIT0 | BIT1)) == USB_ENDPOINT_INTERRUPT) &&\r
+        ((EndpointDescriptor.EndpointAddress & USB_ENDPOINT_DIR_IN) != 0))\r
+    {\r
       //\r
       // We only care interrupt endpoint here\r
       //\r
-      CopyMem(&UsbKeyboardDevice->IntEndpointDescriptor, &EndpointDescriptor, sizeof(EndpointDescriptor));\r
+      CopyMem (&UsbKeyboardDevice->IntEndpointDescriptor, &EndpointDescriptor, sizeof (EndpointDescriptor));\r
       Found = TRUE;\r
       break;\r
     }\r
@@ -257,9 +259,9 @@ USBKeyboardDriverBindingStart (
     UsbKeyboardDevice->DevicePath\r
     );\r
 \r
-  UsbKeyboardDevice->Signature                  = USB_KB_DEV_SIGNATURE;\r
-  UsbKeyboardDevice->SimpleInput.Reset          = USBKeyboardReset;\r
-  UsbKeyboardDevice->SimpleInput.ReadKeyStroke  = USBKeyboardReadKeyStroke;\r
+  UsbKeyboardDevice->Signature                 = USB_KB_DEV_SIGNATURE;\r
+  UsbKeyboardDevice->SimpleInput.Reset         = USBKeyboardReset;\r
+  UsbKeyboardDevice->SimpleInput.ReadKeyStroke = USBKeyboardReadKeyStroke;\r
 \r
   UsbKeyboardDevice->SimpleInputEx.Reset               = USBKeyboardResetEx;\r
   UsbKeyboardDevice->SimpleInputEx.ReadKeyStrokeEx     = USBKeyboardReadKeyStrokeEx;\r
@@ -279,6 +281,7 @@ USBKeyboardDriverBindingStart (
   if (!EFI_ERROR (Status)) {\r
     Status = gBS->SetTimer (UsbKeyboardDevice->TimerEvent, TimerPeriodic, KEYBOARD_TIMER_INTERVAL);\r
   }\r
+\r
   if (EFI_ERROR (Status)) {\r
     goto ErrorExit;\r
   }\r
@@ -337,27 +340,26 @@ USBKeyboardDriverBindingStart (
   }\r
 \r
   UsbKeyboardDevice->ControllerHandle = Controller;\r
-  Status = InitKeyboardLayout (UsbKeyboardDevice);\r
+  Status                              = InitKeyboardLayout (UsbKeyboardDevice);\r
   if (EFI_ERROR (Status)) {\r
     gBS->UninstallMultipleProtocolInterfaces (\r
-      Controller,\r
-      &gEfiSimpleTextInProtocolGuid,\r
-      &UsbKeyboardDevice->SimpleInput,\r
-      &gEfiSimpleTextInputExProtocolGuid,\r
-      &UsbKeyboardDevice->SimpleInputEx,\r
-      NULL\r
-      );\r
+           Controller,\r
+           &gEfiSimpleTextInProtocolGuid,\r
+           &UsbKeyboardDevice->SimpleInput,\r
+           &gEfiSimpleTextInputExProtocolGuid,\r
+           &UsbKeyboardDevice->SimpleInputEx,\r
+           NULL\r
+           );\r
     goto ErrorExit;\r
   }\r
 \r
-\r
   //\r
   // Reset USB Keyboard Device exhaustively.\r
   //\r
   Status = UsbKeyboardDevice->SimpleInputEx.Reset (\r
-                                            &UsbKeyboardDevice->SimpleInputEx,\r
-                                            TRUE\r
-                                            );\r
+                                              &UsbKeyboardDevice->SimpleInputEx,\r
+                                              TRUE\r
+                                              );\r
   if (EFI_ERROR (Status)) {\r
     gBS->UninstallMultipleProtocolInterfaces (\r
            Controller,\r
@@ -375,7 +377,7 @@ USBKeyboardDriverBindingStart (
   //\r
   EndpointAddr    = UsbKeyboardDevice->IntEndpointDescriptor.EndpointAddress;\r
   PollingInterval = UsbKeyboardDevice->IntEndpointDescriptor.Interval;\r
-  PacketSize      = (UINT8) (UsbKeyboardDevice->IntEndpointDescriptor.MaxPacketSize);\r
+  PacketSize      = (UINT8)(UsbKeyboardDevice->IntEndpointDescriptor.MaxPacketSize);\r
 \r
   Status = UsbIo->UsbAsyncInterruptTransfer (\r
                     UsbIo,\r
@@ -418,30 +420,36 @@ USBKeyboardDriverBindingStart (
   gBS->RestoreTPL (OldTpl);\r
   return EFI_SUCCESS;\r
 \r
-//\r
-// Error handler\r
-//\r
+  //\r
+  // Error handler\r
+  //\r
 ErrorExit:\r
   if (UsbKeyboardDevice != NULL) {\r
     if (UsbKeyboardDevice->TimerEvent != NULL) {\r
       gBS->CloseEvent (UsbKeyboardDevice->TimerEvent);\r
     }\r
+\r
     if (UsbKeyboardDevice->SimpleInput.WaitForKey != NULL) {\r
       gBS->CloseEvent (UsbKeyboardDevice->SimpleInput.WaitForKey);\r
     }\r
+\r
     if (UsbKeyboardDevice->SimpleInputEx.WaitForKeyEx != NULL) {\r
       gBS->CloseEvent (UsbKeyboardDevice->SimpleInputEx.WaitForKeyEx);\r
     }\r
+\r
     if (UsbKeyboardDevice->KeyNotifyProcessEvent != NULL) {\r
       gBS->CloseEvent (UsbKeyboardDevice->KeyNotifyProcessEvent);\r
     }\r
+\r
     if (UsbKeyboardDevice->KeyboardLayoutEvent != NULL) {\r
       ReleaseKeyboardLayoutResources (UsbKeyboardDevice);\r
       gBS->CloseEvent (UsbKeyboardDevice->KeyboardLayoutEvent);\r
     }\r
+\r
     FreePool (UsbKeyboardDevice);\r
     UsbKeyboardDevice = NULL;\r
   }\r
+\r
   gBS->CloseProtocol (\r
          Controller,\r
          &gEfiUsbIoProtocolGuid,\r
@@ -453,10 +461,8 @@ ErrorExit1:
   gBS->RestoreTPL (OldTpl);\r
 \r
   return Status;\r
-\r
 }\r
 \r
-\r
 /**\r
   Stop the USB keyboard device handled by this driver.\r
 \r
@@ -475,20 +481,20 @@ ErrorExit1:
 EFI_STATUS\r
 EFIAPI\r
 USBKeyboardDriverBindingStop (\r
-  IN  EFI_DRIVER_BINDING_PROTOCOL    *This,\r
-  IN  EFI_HANDLE                     Controller,\r
-  IN  UINTN                          NumberOfChildren,\r
-  IN  EFI_HANDLE                     *ChildHandleBuffer\r
+  IN  EFI_DRIVER_BINDING_PROTOCOL  *This,\r
+  IN  EFI_HANDLE                   Controller,\r
+  IN  UINTN                        NumberOfChildren,\r
+  IN  EFI_HANDLE                   *ChildHandleBuffer\r
   )\r
 {\r
-  EFI_STATUS                     Status;\r
-  EFI_SIMPLE_TEXT_INPUT_PROTOCOL *SimpleInput;\r
-  USB_KB_DEV                     *UsbKeyboardDevice;\r
+  EFI_STATUS                      Status;\r
+  EFI_SIMPLE_TEXT_INPUT_PROTOCOL  *SimpleInput;\r
+  USB_KB_DEV                      *UsbKeyboardDevice;\r
 \r
   Status = gBS->OpenProtocol (\r
                   Controller,\r
                   &gEfiSimpleTextInProtocolGuid,\r
-                  (VOID **) &SimpleInput,\r
+                  (VOID **)&SimpleInput,\r
                   This->DriverBindingHandle,\r
                   Controller,\r
                   EFI_OPEN_PROTOCOL_GET_PROTOCOL\r
@@ -583,7 +589,7 @@ USBKeyboardDriverBindingStop (
                                   data for the key that was pressed.\r
 \r
   @retval EFI_SUCCESS             The keystroke information was returned.\r
-  @retval EFI_NOT_READY           There was no keystroke data availiable.\r
+  @retval EFI_NOT_READY           There was no keystroke data available.\r
   @retval EFI_DEVICE_ERROR        The keystroke information was not returned due to\r
                                   hardware errors.\r
   @retval EFI_INVALID_PARAMETER   KeyData is NULL.\r
@@ -592,8 +598,8 @@ USBKeyboardDriverBindingStop (
 **/\r
 EFI_STATUS\r
 USBKeyboardReadKeyStrokeWorker (\r
-  IN OUT USB_KB_DEV                 *UsbKeyboardDevice,\r
-     OUT EFI_KEY_DATA               *KeyData\r
+  IN OUT USB_KB_DEV  *UsbKeyboardDevice,\r
+  OUT EFI_KEY_DATA   *KeyData\r
   )\r
 {\r
   if (KeyData == NULL) {\r
@@ -629,12 +635,12 @@ USBKeyboardReadKeyStrokeWorker (
 EFI_STATUS\r
 EFIAPI\r
 USBKeyboardReset (\r
-  IN  EFI_SIMPLE_TEXT_INPUT_PROTOCOL   *This,\r
-  IN  BOOLEAN                          ExtendedVerification\r
+  IN  EFI_SIMPLE_TEXT_INPUT_PROTOCOL  *This,\r
+  IN  BOOLEAN                         ExtendedVerification\r
   )\r
 {\r
-  EFI_STATUS          Status;\r
-  USB_KB_DEV          *UsbKeyboardDevice;\r
+  EFI_STATUS  Status;\r
+  USB_KB_DEV  *UsbKeyboardDevice;\r
 \r
   UsbKeyboardDevice = USB_KB_DEV_FROM_THIS (This);\r
 \r
@@ -675,7 +681,6 @@ USBKeyboardReset (
   return EFI_SUCCESS;\r
 }\r
 \r
-\r
 /**\r
   Reads the next keystroke from the input device.\r
 \r
@@ -684,7 +689,7 @@ USBKeyboardReset (
                                information for the key that was pressed.\r
 \r
   @retval EFI_SUCCESS          The keystroke information was returned.\r
-  @retval EFI_NOT_READY        There was no keystroke data availiable.\r
+  @retval EFI_NOT_READY        There was no keystroke data available.\r
   @retval EFI_DEVICE_ERROR     The keystroke information was not returned due to\r
                                hardware errors.\r
 \r
@@ -692,13 +697,13 @@ USBKeyboardReset (
 EFI_STATUS\r
 EFIAPI\r
 USBKeyboardReadKeyStroke (\r
-  IN  EFI_SIMPLE_TEXT_INPUT_PROTOCOL   *This,\r
-  OUT EFI_INPUT_KEY                    *Key\r
+  IN  EFI_SIMPLE_TEXT_INPUT_PROTOCOL  *This,\r
+  OUT EFI_INPUT_KEY                   *Key\r
   )\r
 {\r
-  USB_KB_DEV   *UsbKeyboardDevice;\r
-  EFI_STATUS   Status;\r
-  EFI_KEY_DATA KeyData;\r
+  USB_KB_DEV    *UsbKeyboardDevice;\r
+  EFI_STATUS    Status;\r
+  EFI_KEY_DATA  KeyData;\r
 \r
   UsbKeyboardDevice = USB_KB_DEV_FROM_THIS (This);\r
 \r
@@ -712,21 +717,23 @@ USBKeyboardReadKeyStroke (
     if (EFI_ERROR (Status)) {\r
       return Status;\r
     }\r
+\r
     //\r
     // SimpleTextIn Protocol doesn't support partial keystroke;\r
     //\r
-    if (KeyData.Key.ScanCode == CHAR_NULL && KeyData.Key.UnicodeChar == SCAN_NULL) {\r
+    if ((KeyData.Key.ScanCode == CHAR_NULL) && (KeyData.Key.UnicodeChar == SCAN_NULL)) {\r
       continue;\r
     }\r
+\r
     //\r
     // Translate the CTRL-Alpha characters to their corresponding control value\r
     // (ctrl-a = 0x0001 through ctrl-Z = 0x001A)\r
     //\r
     if ((KeyData.KeyState.KeyShiftState & (EFI_LEFT_CONTROL_PRESSED | EFI_RIGHT_CONTROL_PRESSED)) != 0) {\r
-      if (KeyData.Key.UnicodeChar >= L'a' && KeyData.Key.UnicodeChar <= L'z') {\r
-        KeyData.Key.UnicodeChar = (CHAR16) (KeyData.Key.UnicodeChar - L'a' + 1);\r
-      } else if (KeyData.Key.UnicodeChar >= L'A' && KeyData.Key.UnicodeChar <= L'Z') {\r
-        KeyData.Key.UnicodeChar = (CHAR16) (KeyData.Key.UnicodeChar - L'A' + 1);\r
+      if ((KeyData.Key.UnicodeChar >= L'a') && (KeyData.Key.UnicodeChar <= L'z')) {\r
+        KeyData.Key.UnicodeChar = (CHAR16)(KeyData.Key.UnicodeChar - L'a' + 1);\r
+      } else if ((KeyData.Key.UnicodeChar >= L'A') && (KeyData.Key.UnicodeChar <= L'Z')) {\r
+        KeyData.Key.UnicodeChar = (CHAR16)(KeyData.Key.UnicodeChar - L'A' + 1);\r
       }\r
     }\r
 \r
@@ -735,7 +742,6 @@ USBKeyboardReadKeyStroke (
   }\r
 }\r
 \r
-\r
 /**\r
   Event notification function registered for EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL.WaitForKeyEx\r
   and EFI_SIMPLE_TEXT_INPUT_PROTOCOL.WaitForKey.\r
@@ -747,15 +753,15 @@ USBKeyboardReadKeyStroke (
 VOID\r
 EFIAPI\r
 USBKeyboardWaitForKey (\r
-  IN  EFI_EVENT               Event,\r
-  IN  VOID                    *Context\r
+  IN  EFI_EVENT  Event,\r
+  IN  VOID       *Context\r
   )\r
 {\r
-  USB_KB_DEV  *UsbKeyboardDevice;\r
-  EFI_KEY_DATA KeyData;\r
-  EFI_TPL      OldTpl;\r
+  USB_KB_DEV    *UsbKeyboardDevice;\r
+  EFI_KEY_DATA  KeyData;\r
+  EFI_TPL       OldTpl;\r
 \r
-  UsbKeyboardDevice = (USB_KB_DEV *) Context;\r
+  UsbKeyboardDevice = (USB_KB_DEV *)Context;\r
 \r
   //\r
   // Enter critical section\r
@@ -763,7 +769,7 @@ USBKeyboardWaitForKey (
   OldTpl = gBS->RaiseTPL (TPL_NOTIFY);\r
 \r
   //\r
-  // WaitforKey doesn't suppor the partial key.\r
+  // WaitforKey doesn't support the partial key.\r
   // Considering if the partial keystroke is enabled, there maybe a partial\r
   // keystroke in the queue, so here skip the partial keystroke and get the\r
   // next key from the queue\r
@@ -777,13 +783,15 @@ USBKeyboardWaitForKey (
       UsbKeyboardDevice->EfiKeyQueue.Buffer[UsbKeyboardDevice->EfiKeyQueue.Head],\r
       sizeof (EFI_KEY_DATA)\r
       );\r
-    if (KeyData.Key.ScanCode == SCAN_NULL && KeyData.Key.UnicodeChar == CHAR_NULL) {\r
+    if ((KeyData.Key.ScanCode == SCAN_NULL) && (KeyData.Key.UnicodeChar == CHAR_NULL)) {\r
       Dequeue (&UsbKeyboardDevice->EfiKeyQueue, &KeyData, sizeof (EFI_KEY_DATA));\r
       continue;\r
     }\r
+\r
     gBS->SignalEvent (Event);\r
     break;\r
   }\r
+\r
   //\r
   // Leave critical section and return\r
   //\r
@@ -799,16 +807,16 @@ USBKeyboardWaitForKey (
 VOID\r
 EFIAPI\r
 USBKeyboardTimerHandler (\r
-  IN  EFI_EVENT                 Event,\r
-  IN  VOID                      *Context\r
+  IN  EFI_EVENT  Event,\r
+  IN  VOID       *Context\r
   )\r
 {\r
-  EFI_STATUS                    Status;\r
-  USB_KB_DEV                    *UsbKeyboardDevice;\r
-  UINT8                         KeyCode;\r
-  EFI_KEY_DATA                  KeyData;\r
+  EFI_STATUS    Status;\r
+  USB_KB_DEV    *UsbKeyboardDevice;\r
+  UINT8         KeyCode;\r
+  EFI_KEY_DATA  KeyData;\r
 \r
-  UsbKeyboardDevice = (USB_KB_DEV *) Context;\r
+  UsbKeyboardDevice = (USB_KB_DEV *)Context;\r
 \r
   //\r
   // Fetch raw data from the USB keyboard buffer,\r
@@ -816,7 +824,7 @@ USBKeyboardTimerHandler (
   //\r
   Status = USBParseKey (UsbKeyboardDevice, &KeyCode);\r
   if (EFI_ERROR (Status)) {\r
-    return ;\r
+    return;\r
   }\r
 \r
   //\r
@@ -824,7 +832,7 @@ USBKeyboardTimerHandler (
   //\r
   Status = UsbKeyCodeToEfiInputKey (UsbKeyboardDevice, KeyCode, &KeyData);\r
   if (EFI_ERROR (Status)) {\r
-    return ;\r
+    return;\r
   }\r
 \r
   //\r
@@ -844,17 +852,18 @@ USBKeyboardTimerHandler (
 **/\r
 EFI_STATUS\r
 KbdFreeNotifyList (\r
-  IN OUT LIST_ENTRY           *NotifyList\r
+  IN OUT LIST_ENTRY  *NotifyList\r
   )\r
 {\r
-  KEYBOARD_CONSOLE_IN_EX_NOTIFY *NotifyNode;\r
-  LIST_ENTRY                    *Link;\r
+  KEYBOARD_CONSOLE_IN_EX_NOTIFY  *NotifyNode;\r
+  LIST_ENTRY                     *Link;\r
 \r
   if (NotifyList == NULL) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
+\r
   while (!IsListEmpty (NotifyList)) {\r
-    Link = GetFirstNode (NotifyList);\r
+    Link       = GetFirstNode (NotifyList);\r
     NotifyNode = CR (Link, KEYBOARD_CONSOLE_IN_EX_NOTIFY, NotifyEntry, USB_KB_CONSOLE_IN_EX_NOTIFY_SIGNATURE);\r
     RemoveEntryList (Link);\r
     FreePool (NotifyNode);\r
@@ -870,7 +879,7 @@ KbdFreeNotifyList (
   @param  InputData         A pointer to keystroke data for the key that was pressed.\r
 \r
   @retval TRUE              Key pressed matches a registered key.\r
-  @retval FLASE             Key pressed does not matches a registered key.\r
+  @retval FALSE             Key pressed does not matches a registered key.\r
 \r
 **/\r
 BOOLEAN\r
@@ -882,19 +891,23 @@ IsKeyRegistered (
   ASSERT (RegsiteredData != NULL && InputData != NULL);\r
 \r
   if ((RegsiteredData->Key.ScanCode    != InputData->Key.ScanCode) ||\r
-      (RegsiteredData->Key.UnicodeChar != InputData->Key.UnicodeChar)) {\r
+      (RegsiteredData->Key.UnicodeChar != InputData->Key.UnicodeChar))\r
+  {\r
     return FALSE;\r
   }\r
 \r
   //\r
   // Assume KeyShiftState/KeyToggleState = 0 in Registered key data means these state could be ignored.\r
   //\r
-  if (RegsiteredData->KeyState.KeyShiftState != 0 &&\r
-      RegsiteredData->KeyState.KeyShiftState != InputData->KeyState.KeyShiftState) {\r
+  if ((RegsiteredData->KeyState.KeyShiftState != 0) &&\r
+      (RegsiteredData->KeyState.KeyShiftState != InputData->KeyState.KeyShiftState))\r
+  {\r
     return FALSE;\r
   }\r
-  if (RegsiteredData->KeyState.KeyToggleState != 0 &&\r
-      RegsiteredData->KeyState.KeyToggleState != InputData->KeyState.KeyToggleState) {\r
+\r
+  if ((RegsiteredData->KeyState.KeyToggleState != 0) &&\r
+      (RegsiteredData->KeyState.KeyToggleState != InputData->KeyState.KeyToggleState))\r
+  {\r
     return FALSE;\r
   }\r
 \r
@@ -904,6 +917,7 @@ IsKeyRegistered (
 //\r
 // Simple Text Input Ex protocol functions\r
 //\r
+\r
 /**\r
   Resets the input device hardware.\r
 \r
@@ -933,8 +947,8 @@ USBKeyboardResetEx (
   IN BOOLEAN                            ExtendedVerification\r
   )\r
 {\r
-  EFI_STATUS                Status;\r
-  USB_KB_DEV                *UsbKeyboardDevice;\r
+  EFI_STATUS  Status;\r
+  USB_KB_DEV  *UsbKeyboardDevice;\r
 \r
   UsbKeyboardDevice = TEXT_INPUT_EX_USB_KB_DEV_FROM_THIS (This);\r
 \r
@@ -947,7 +961,6 @@ USBKeyboardResetEx (
   UsbKeyboardDevice->KeyState.KeyToggleState = EFI_TOGGLE_STATE_VALID;\r
 \r
   return EFI_SUCCESS;\r
-\r
 }\r
 \r
 /**\r
@@ -967,11 +980,11 @@ USBKeyboardResetEx (
 EFI_STATUS\r
 EFIAPI\r
 USBKeyboardReadKeyStrokeEx (\r
-  IN  EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL *This,\r
-  OUT EFI_KEY_DATA                      *KeyData\r
+  IN  EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL  *This,\r
+  OUT EFI_KEY_DATA                       *KeyData\r
   )\r
 {\r
-  USB_KB_DEV                        *UsbKeyboardDevice;\r
+  USB_KB_DEV  *UsbKeyboardDevice;\r
 \r
   if (KeyData == NULL) {\r
     return EFI_INVALID_PARAMETER;\r
@@ -980,7 +993,6 @@ USBKeyboardReadKeyStrokeEx (
   UsbKeyboardDevice = TEXT_INPUT_EX_USB_KB_DEV_FROM_THIS (This);\r
 \r
   return USBKeyboardReadKeyStrokeWorker (UsbKeyboardDevice, KeyData);\r
-\r
 }\r
 \r
 /**\r
@@ -1004,7 +1016,7 @@ USBKeyboardSetState (
   IN EFI_KEY_TOGGLE_STATE               *KeyToggleState\r
   )\r
 {\r
-  USB_KB_DEV                        *UsbKeyboardDevice;\r
+  USB_KB_DEV  *UsbKeyboardDevice;\r
 \r
   if (KeyToggleState == NULL) {\r
     return EFI_INVALID_PARAMETER;\r
@@ -1013,7 +1025,8 @@ USBKeyboardSetState (
   UsbKeyboardDevice = TEXT_INPUT_EX_USB_KB_DEV_FROM_THIS (This);\r
 \r
   if (((UsbKeyboardDevice->KeyState.KeyToggleState & EFI_TOGGLE_STATE_VALID) != EFI_TOGGLE_STATE_VALID) ||\r
-      ((*KeyToggleState & EFI_TOGGLE_STATE_VALID) != EFI_TOGGLE_STATE_VALID)) {\r
+      ((*KeyToggleState & EFI_TOGGLE_STATE_VALID) != EFI_TOGGLE_STATE_VALID))\r
+  {\r
     return EFI_UNSUPPORTED;\r
   }\r
 \r
@@ -1021,20 +1034,23 @@ USBKeyboardSetState (
   // Update the status light\r
   //\r
 \r
-  UsbKeyboardDevice->ScrollOn   = FALSE;\r
-  UsbKeyboardDevice->NumLockOn  = FALSE;\r
-  UsbKeyboardDevice->CapsOn     = FALSE;\r
+  UsbKeyboardDevice->ScrollOn            = FALSE;\r
+  UsbKeyboardDevice->NumLockOn           = FALSE;\r
+  UsbKeyboardDevice->CapsOn              = FALSE;\r
   UsbKeyboardDevice->IsSupportPartialKey = FALSE;\r
 \r
   if ((*KeyToggleState & EFI_SCROLL_LOCK_ACTIVE) == EFI_SCROLL_LOCK_ACTIVE) {\r
     UsbKeyboardDevice->ScrollOn = TRUE;\r
   }\r
+\r
   if ((*KeyToggleState & EFI_NUM_LOCK_ACTIVE) == EFI_NUM_LOCK_ACTIVE) {\r
     UsbKeyboardDevice->NumLockOn = TRUE;\r
   }\r
+\r
   if ((*KeyToggleState & EFI_CAPS_LOCK_ACTIVE) == EFI_CAPS_LOCK_ACTIVE) {\r
     UsbKeyboardDevice->CapsOn = TRUE;\r
   }\r
+\r
   if ((*KeyToggleState & EFI_KEY_STATE_EXPOSED) == EFI_KEY_STATE_EXPOSED) {\r
     UsbKeyboardDevice->IsSupportPartialKey = TRUE;\r
   }\r
@@ -1044,7 +1060,6 @@ USBKeyboardSetState (
   UsbKeyboardDevice->KeyState.KeyToggleState = *KeyToggleState;\r
 \r
   return EFI_SUCCESS;\r
-\r
 }\r
 \r
 /**\r
@@ -1075,13 +1090,13 @@ USBKeyboardRegisterKeyNotify (
   OUT VOID                               **NotifyHandle\r
   )\r
 {\r
-  USB_KB_DEV                        *UsbKeyboardDevice;\r
-  KEYBOARD_CONSOLE_IN_EX_NOTIFY     *NewNotify;\r
-  LIST_ENTRY                        *Link;\r
-  LIST_ENTRY                        *NotifyList;\r
-  KEYBOARD_CONSOLE_IN_EX_NOTIFY     *CurrentNotify;\r
+  USB_KB_DEV                     *UsbKeyboardDevice;\r
+  KEYBOARD_CONSOLE_IN_EX_NOTIFY  *NewNotify;\r
+  LIST_ENTRY                     *Link;\r
+  LIST_ENTRY                     *NotifyList;\r
+  KEYBOARD_CONSOLE_IN_EX_NOTIFY  *CurrentNotify;\r
 \r
-  if (KeyData == NULL || NotifyHandle == NULL || KeyNotificationFunction == NULL) {\r
+  if ((KeyData == NULL) || (NotifyHandle == NULL) || (KeyNotificationFunction == NULL)) {\r
     return EFI_INVALID_PARAMETER;\r
   }\r
 \r
@@ -1094,7 +1109,8 @@ USBKeyboardRegisterKeyNotify (
 \r
   for (Link = GetFirstNode (NotifyList);\r
        !IsNull (NotifyList, Link);\r
-       Link = GetNextNode (NotifyList, Link)) {\r
+       Link = GetNextNode (NotifyList, Link))\r
+  {\r
     CurrentNotify = CR (\r
                       Link,\r
                       KEYBOARD_CONSOLE_IN_EX_NOTIFY,\r
@@ -1112,7 +1128,7 @@ USBKeyboardRegisterKeyNotify (
   //\r
   // Allocate resource to save the notification function\r
   //\r
-  NewNotify = (KEYBOARD_CONSOLE_IN_EX_NOTIFY *) AllocateZeroPool (sizeof (KEYBOARD_CONSOLE_IN_EX_NOTIFY));\r
+  NewNotify = (KEYBOARD_CONSOLE_IN_EX_NOTIFY *)AllocateZeroPool (sizeof (KEYBOARD_CONSOLE_IN_EX_NOTIFY));\r
   if (NewNotify == NULL) {\r
     return EFI_OUT_OF_RESOURCES;\r
   }\r
@@ -1122,11 +1138,9 @@ USBKeyboardRegisterKeyNotify (
   CopyMem (&NewNotify->KeyData, KeyData, sizeof (EFI_KEY_DATA));\r
   InsertTailList (&UsbKeyboardDevice->NotifyList, &NewNotify->NotifyEntry);\r
 \r
-\r
   *NotifyHandle = NewNotify;\r
 \r
   return EFI_SUCCESS;\r
-\r
 }\r
 \r
 /**\r
@@ -1146,10 +1160,10 @@ USBKeyboardUnregisterKeyNotify (
   IN VOID                               *NotificationHandle\r
   )\r
 {\r
-  USB_KB_DEV                        *UsbKeyboardDevice;\r
-  KEYBOARD_CONSOLE_IN_EX_NOTIFY     *CurrentNotify;\r
-  LIST_ENTRY                        *Link;\r
-  LIST_ENTRY                        *NotifyList;\r
+  USB_KB_DEV                     *UsbKeyboardDevice;\r
+  KEYBOARD_CONSOLE_IN_EX_NOTIFY  *CurrentNotify;\r
+  LIST_ENTRY                     *Link;\r
+  LIST_ENTRY                     *NotifyList;\r
 \r
   if (NotificationHandle == NULL) {\r
     return EFI_INVALID_PARAMETER;\r
@@ -1163,7 +1177,8 @@ USBKeyboardUnregisterKeyNotify (
   NotifyList = &UsbKeyboardDevice->NotifyList;\r
   for (Link = GetFirstNode (NotifyList);\r
        !IsNull (NotifyList, Link);\r
-       Link = GetNextNode (NotifyList, Link)) {\r
+       Link = GetNextNode (NotifyList, Link))\r
+  {\r
     CurrentNotify = CR (\r
                       Link,\r
                       KEYBOARD_CONSOLE_IN_EX_NOTIFY,\r
@@ -1196,19 +1211,19 @@ USBKeyboardUnregisterKeyNotify (
 VOID\r
 EFIAPI\r
 KeyNotifyProcessHandler (\r
-  IN  EFI_EVENT                 Event,\r
-  IN  VOID                      *Context\r
+  IN  EFI_EVENT  Event,\r
+  IN  VOID       *Context\r
   )\r
 {\r
-  EFI_STATUS                    Status;\r
-  USB_KB_DEV                    *UsbKeyboardDevice;\r
-  EFI_KEY_DATA                  KeyData;\r
-  LIST_ENTRY                    *Link;\r
-  LIST_ENTRY                    *NotifyList;\r
-  KEYBOARD_CONSOLE_IN_EX_NOTIFY *CurrentNotify;\r
-  EFI_TPL                       OldTpl;\r
+  EFI_STATUS                     Status;\r
+  USB_KB_DEV                     *UsbKeyboardDevice;\r
+  EFI_KEY_DATA                   KeyData;\r
+  LIST_ENTRY                     *Link;\r
+  LIST_ENTRY                     *NotifyList;\r
+  KEYBOARD_CONSOLE_IN_EX_NOTIFY  *CurrentNotify;\r
+  EFI_TPL                        OldTpl;\r
 \r
-  UsbKeyboardDevice = (USB_KB_DEV *) Context;\r
+  UsbKeyboardDevice = (USB_KB_DEV *)Context;\r
 \r
   //\r
   // Invoke notification functions.\r
@@ -1227,6 +1242,7 @@ KeyNotifyProcessHandler (
     if (EFI_ERROR (Status)) {\r
       break;\r
     }\r
+\r
     for (Link = GetFirstNode (NotifyList); !IsNull (NotifyList, Link); Link = GetNextNode (NotifyList, Link)) {\r
       CurrentNotify = CR (Link, KEYBOARD_CONSOLE_IN_EX_NOTIFY, NotifyEntry, USB_KB_CONSOLE_IN_EX_NOTIFY_SIGNATURE);\r
       if (IsKeyRegistered (&CurrentNotify->KeyData, &KeyData)) {\r
@@ -1235,4 +1251,3 @@ KeyNotifyProcessHandler (
     }\r
   }\r
 }\r
-\r