This library is mainly used by SMM Core to start performance logging to ensure that\r
SMM Performance and PerformanceEx Protocol are installed at the very beginning of SMM phase.\r
\r
-Copyright (c) 2011 - 2012, Intel Corporation. All rights reserved.<BR>\r
+ Caution: This module requires additional review when modified.\r
+ This driver will have external input - performance data and communicate buffer in SMM mode.\r
+ This external input must be validated carefully to avoid security issue like\r
+ buffer overflow, integer overflow.\r
+\r
+ SmmPerformanceHandlerEx(), SmmPerformanceHandler() will receive untrusted input and do basic validation.\r
+\r
+Copyright (c) 2011 - 2013, Intel Corporation. All rights reserved.<BR>\r
This program and the accompanying materials\r
are licensed and made available under the terms and conditions of the BSD License\r
which accompanies this distribution. The full text of the license may be found at\r
)\r
{\r
UINT32 Index;\r
+ UINT32 Index2;\r
UINT32 NumberOfEntries;\r
GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;\r
\r
NumberOfEntries = mGaugeData->NumberOfEntries;\r
GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);\r
\r
+ Index2 = 0;\r
+\r
for (Index = 0; Index < NumberOfEntries; Index++) {\r
- if ((GaugeEntryExArray[Index].Handle == (EFI_PHYSICAL_ADDRESS) (UINTN) Handle) &&\r
- AsciiStrnCmp (GaugeEntryExArray[Index].Token, Token, SMM_PERFORMANCE_STRING_LENGTH) == 0 &&\r
- AsciiStrnCmp (GaugeEntryExArray[Index].Module, Module, SMM_PERFORMANCE_STRING_LENGTH) == 0 &&\r
- (GaugeEntryExArray[Index].Identifier == Identifier) &&\r
- GaugeEntryExArray[Index].EndTimeStamp == 0) {\r
+ Index2 = NumberOfEntries - 1 - Index;\r
+ if (GaugeEntryExArray[Index2].EndTimeStamp == 0 &&\r
+ (GaugeEntryExArray[Index2].Handle == (EFI_PHYSICAL_ADDRESS) (UINTN) Handle) &&\r
+ AsciiStrnCmp (GaugeEntryExArray[Index2].Token, Token, SMM_PERFORMANCE_STRING_LENGTH) == 0 &&\r
+ AsciiStrnCmp (GaugeEntryExArray[Index2].Module, Module, SMM_PERFORMANCE_STRING_LENGTH) == 0 &&\r
+ (GaugeEntryExArray[Index2].Identifier == Identifier)) {\r
+ Index = Index2;\r
break;\r
}\r
}\r
EFI_STATUS Status;\r
GAUGE_DATA_ENTRY_EX *GaugeEntryEx;\r
\r
+ GaugeEntryEx = NULL;\r
+\r
Status = GetGaugeEx (LogEntryKey, &GaugeEntryEx);\r
if (EFI_ERROR (Status)) {\r
return Status;\r
return FALSE;\r
}\r
\r
+/**\r
+ This function check if the address refered by Buffer and Length is valid.\r
+\r
+ @param Buffer the buffer address to be checked.\r
+ @param Length the buffer length to be checked.\r
+\r
+ @retval TRUE this address is valid.\r
+ @retval FALSE this address is NOT valid.\r
+**/\r
+BOOLEAN\r
+IsAddressValid (\r
+ IN UINTN Buffer,\r
+ IN UINTN Length\r
+ )\r
+{\r
+ if (Buffer > (MAX_ADDRESS - Length)) {\r
+ //\r
+ // Overflow happen\r
+ //\r
+ return FALSE;\r
+ }\r
+ if (IsAddressInSmram ((EFI_PHYSICAL_ADDRESS)Buffer, (UINT64)Length)) {\r
+ return FALSE;\r
+ }\r
+ return TRUE;\r
+}\r
+\r
/**\r
Communication service SMI Handler entry.\r
\r
This SMI handler provides services for the performance wrapper driver.\r
+ \r
+ Caution: This function may receive untrusted input.\r
+ Communicate buffer and buffer size are external input, so this function will do basic validation.\r
\r
@param[in] DispatchHandle The unique handle assigned to this handler by SmiHandlerRegister().\r
@param[in] RegisterContext Points to an optional handler context which was specified when the\r
SMM_PERF_COMMUNICATE_EX *SmmPerfCommData;\r
GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;\r
UINTN DataSize;\r
+ GAUGE_DATA_ENTRY_EX *GaugeDataEx;\r
+ UINTN NumberOfEntries;\r
+ UINTN LogEntryKey;\r
+ UINTN TempCommBufferSize;\r
\r
GaugeEntryExArray = NULL;\r
\r
- ASSERT (CommBuffer != NULL);\r
+ //\r
+ // If input is invalid, stop processing this SMI\r
+ //\r
+ if (CommBuffer == NULL || CommBufferSize == NULL) {\r
+ return EFI_SUCCESS;\r
+ }\r
+\r
+ TempCommBufferSize = *CommBufferSize;\r
\r
+ if(TempCommBufferSize < sizeof (SMM_PERF_COMMUNICATE_EX)) {\r
+ return EFI_SUCCESS;\r
+ }\r
+\r
+ if (!IsAddressValid ((UINTN)CommBuffer, TempCommBufferSize)) {\r
+ DEBUG ((EFI_D_ERROR, "SmmPerformanceHandlerEx: SMM communcation data buffer in SMRAM or overflow!\n"));\r
+ return EFI_SUCCESS;\r
+ }\r
+ \r
SmmPerfCommData = (SMM_PERF_COMMUNICATE_EX *)CommBuffer;\r
\r
switch (SmmPerfCommData->Function) {\r
break;\r
\r
case SMM_PERF_FUNCTION_GET_GAUGE_DATA :\r
- if ( SmmPerfCommData->GaugeDataEx == NULL || SmmPerfCommData->NumberOfEntries == 0 ||\r
- (SmmPerfCommData->LogEntryKey + SmmPerfCommData->NumberOfEntries) > mGaugeData->NumberOfEntries) {\r
+ GaugeDataEx = SmmPerfCommData->GaugeDataEx;\r
+ NumberOfEntries = SmmPerfCommData->NumberOfEntries;\r
+ LogEntryKey = SmmPerfCommData->LogEntryKey;\r
+ if (GaugeDataEx == NULL || NumberOfEntries == 0 || LogEntryKey > mGaugeData->NumberOfEntries ||\r
+ NumberOfEntries > mGaugeData->NumberOfEntries || (LogEntryKey + NumberOfEntries) > mGaugeData->NumberOfEntries) {\r
Status = EFI_INVALID_PARAMETER;\r
break;\r
}\r
//\r
// Sanity check\r
//\r
- DataSize = SmmPerfCommData->NumberOfEntries * sizeof(GAUGE_DATA_ENTRY_EX);\r
- if (IsAddressInSmram ((EFI_PHYSICAL_ADDRESS)(UINTN)SmmPerfCommData->GaugeDataEx, DataSize)) {\r
- DEBUG ((EFI_D_ERROR, "Smm Performance Data buffer is in SMRAM!\n"));\r
+ DataSize = NumberOfEntries * sizeof(GAUGE_DATA_ENTRY_EX);\r
+ if (!IsAddressValid ((UINTN)GaugeDataEx, DataSize)) {\r
+ DEBUG ((EFI_D_ERROR, "SmmPerformanceHandlerEx: SMM Performance Data buffer in SMRAM or overflow!\n"));\r
Status = EFI_ACCESS_DENIED;\r
- break ;\r
+ break;\r
}\r
\r
GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);\r
CopyMem(\r
- (UINT8 *) (SmmPerfCommData->GaugeDataEx),\r
- (UINT8 *) &GaugeEntryExArray[SmmPerfCommData->LogEntryKey],\r
+ (UINT8 *) GaugeDataEx,\r
+ (UINT8 *) &GaugeEntryExArray[LogEntryKey],\r
DataSize\r
);\r
Status = EFI_SUCCESS;\r
break;\r
\r
default:\r
- ASSERT (FALSE);\r
Status = EFI_UNSUPPORTED;\r
}\r
\r
+\r
SmmPerfCommData->ReturnStatus = Status;\r
+ \r
return EFI_SUCCESS;\r
}\r
\r
\r
This SMI handler provides services for the performance wrapper driver.\r
\r
+ Caution: This function may receive untrusted input.\r
+ Communicate buffer and buffer size are external input, so this function will do basic validation.\r
+\r
@param[in] DispatchHandle The unique handle assigned to this handler by SmiHandlerRegister().\r
@param[in] RegisterContext Points to an optional handler context which was specified when the\r
handler was registered.\r
GAUGE_DATA_ENTRY_EX *GaugeEntryExArray;\r
UINTN DataSize;\r
UINTN Index;\r
+ GAUGE_DATA_ENTRY *GaugeData;\r
+ UINTN NumberOfEntries;\r
UINTN LogEntryKey;\r
+ UINTN TempCommBufferSize;\r
\r
GaugeEntryExArray = NULL;\r
\r
- ASSERT (CommBuffer != NULL);\r
+ //\r
+ // If input is invalid, stop processing this SMI\r
+ //\r
+ if (CommBuffer == NULL || CommBufferSize == NULL) {\r
+ return EFI_SUCCESS;\r
+ }\r
+\r
+ TempCommBufferSize = *CommBufferSize;\r
+\r
+ if(TempCommBufferSize < sizeof (SMM_PERF_COMMUNICATE)) {\r
+ return EFI_SUCCESS;\r
+ }\r
+\r
+ if (!IsAddressValid ((UINTN)CommBuffer, TempCommBufferSize)) {\r
+ DEBUG ((EFI_D_ERROR, "SmmPerformanceHandler: SMM communcation data buffer in SMRAM or overflow!\n"));\r
+ return EFI_SUCCESS;\r
+ }\r
\r
SmmPerfCommData = (SMM_PERF_COMMUNICATE *)CommBuffer;\r
\r
break;\r
\r
case SMM_PERF_FUNCTION_GET_GAUGE_DATA :\r
- if ( SmmPerfCommData->GaugeData == NULL || SmmPerfCommData->NumberOfEntries == 0 ||\r
- (SmmPerfCommData->LogEntryKey + SmmPerfCommData->NumberOfEntries) > mGaugeData->NumberOfEntries) {\r
+ GaugeData = SmmPerfCommData->GaugeData;\r
+ NumberOfEntries = SmmPerfCommData->NumberOfEntries;\r
+ LogEntryKey = SmmPerfCommData->LogEntryKey;\r
+ if (GaugeData == NULL || NumberOfEntries == 0 || LogEntryKey > mGaugeData->NumberOfEntries ||\r
+ NumberOfEntries > mGaugeData->NumberOfEntries || (LogEntryKey + NumberOfEntries) > mGaugeData->NumberOfEntries) {\r
Status = EFI_INVALID_PARAMETER;\r
break;\r
}\r
//\r
// Sanity check\r
//\r
- DataSize = SmmPerfCommData->NumberOfEntries * sizeof(GAUGE_DATA_ENTRY);\r
- if (IsAddressInSmram ((EFI_PHYSICAL_ADDRESS)(UINTN)SmmPerfCommData->GaugeData, DataSize)) {\r
- DEBUG ((EFI_D_ERROR, "Smm Performance Data buffer is in SMRAM!\n"));\r
+ DataSize = NumberOfEntries * sizeof(GAUGE_DATA_ENTRY);\r
+ if (!IsAddressValid ((UINTN)GaugeData, DataSize)) {\r
+ DEBUG ((EFI_D_ERROR, "SmmPerformanceHandler: SMM Performance Data buffer in SMRAM or overflow!\n"));\r
Status = EFI_ACCESS_DENIED;\r
- break ;\r
+ break;\r
}\r
\r
GaugeEntryExArray = (GAUGE_DATA_ENTRY_EX *) (mGaugeData + 1);\r
\r
- LogEntryKey = SmmPerfCommData->LogEntryKey;\r
- for (Index = 0; Index < SmmPerfCommData->NumberOfEntries; Index++) {\r
+ for (Index = 0; Index < NumberOfEntries; Index++) {\r
CopyMem(\r
- (UINT8 *) &(SmmPerfCommData->GaugeData[Index]),\r
+ (UINT8 *) &GaugeData[Index],\r
(UINT8 *) &GaugeEntryExArray[LogEntryKey++],\r
sizeof (GAUGE_DATA_ENTRY)\r
);\r
break;\r
\r
default:\r
- ASSERT (FALSE);\r
Status = EFI_UNSUPPORTED;\r
}\r
\r
+\r
SmmPerfCommData->ReturnStatus = Status;\r
+ \r
return EFI_SUCCESS;\r
}\r
\r
projects / mirror_edk2.git / blobdiff