MdeModulePkg/UdfDxe: ASSERT for false positives of NULL ptr deref

[mirror_edk2.git] / MdeModulePkg / Universal / Disk / UdfDxe / FileSystemOperations.c

diff --git a/MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c b/MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c
index 638f31bd821832d3cec4fa19652611220a026ce9..8b58cc9eb16df6e1a10a00f2edb2290cf0070094 100644 (file)
--- a/MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c
+++ b/MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c
@@ -1404,6 +1404,15 @@ InternalFindFile (
 \r
       break;\r
     }\r
+    //\r
+    // After calling function ReadDirectoryEntry(), if 'FileIdentifierDesc' is\r
+    // NULL, then the 'Status' must be EFI_OUT_OF_RESOURCES. Hence, if the code\r
+    // reaches here, 'FileIdentifierDesc' must be not NULL.\r
+    //\r
+    // The ASSERT here is for addressing a false positive NULL pointer\r
+    // dereference issue raised from static analysis.\r
+    //\r
+    ASSERT (FileIdentifierDesc != NULL);\r
 \r
     if (FileIdentifierDesc->FileCharacteristics & PARENT_FILE) {\r
       //\r