it was root caused to be Spec issue instead of code issue. It should be Action inste...

[mirror_edk2.git] / MdeModulePkg / Universal / Network / IScsiDxe / IScsiCHAP.c

diff --git a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiCHAP.c b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiCHAP.c
index ad68cd9d4c7436772f4837401df5917ebacfa605..6ee32f486118d6df54fd470315a4d6b741ac7063 100644 (file)
--- a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiCHAP.c
+++ b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiCHAP.c
@@ -30,7 +30,7 @@ EFI_GUID  mIScsiCHAPAuthInfoGuid = ISCSI_CHAP_AUTH_INFO_GUID;
   @retval EFI_SUCCESS             The expected hash value was caculatedly successfully.\r
   @retval EFI_PROTOCOL_ERROR      The length of the secret should be at least the \r
                                   length of the hash value for the hashing algorithm chosen.\r
-  @retval Others                  Some unexpected error happened.                                \r
+  @retval Others                  Other errors as indicated.                                \r
 **/\r
 EFI_STATUS\r
 IScsiCHAPCalculateResponse (\r
@@ -82,7 +82,7 @@ IScsiCHAPCalculateResponse (
 \r
   @retval EFI_SUCCESS               The response from target passed authentication.\r
   @retval EFI_SECURITY_VIOLATION    The response from target was not expected value.\r
-  @retval Others                    Some unexpected error happened.\r
+  @retval Others                    Other errors as indicated.\r
 **/\r
 EFI_STATUS\r
 IScsiCHAPAuthTarget (\r
@@ -118,17 +118,15 @@ IScsiCHAPAuthTarget (
   negotiation stage.\r
   \r
   @param[in] Conn             The iSCSI connection.\r
-  @param[in] Transit          The transit flag of the latest iSCSI Login Response.\r
 \r
   @retval EFI_SUCCESS          The Login Response passed the CHAP validation.\r
   @retval EFI_OUT_OF_RESOURCES Failed to allocate memory.\r
   @retval EFI_PROTOCOL_ERROR   Some kind of protocol error happend.\r
-  @retval Others               Some unexpected error happend.\r
+  @retval Others               Other errors as indicated.\r
 **/\r
 EFI_STATUS\r
 IScsiCHAPOnRspReceived (\r
-  IN ISCSI_CONNECTION  *Conn,\r
-  IN BOOLEAN           Transit\r
+  IN ISCSI_CONNECTION  *Conn\r
   )\r
 {\r
   EFI_STATUS                Status;\r
@@ -306,8 +304,8 @@ ON_EXIT:
   This function fills the CHAP authentication information into the login PDU\r
   during the security negotiation stage in the iSCSI connection login.\r
 \r
-  @param[in]  Conn             The iSCSI connection.\r
-  @param[in]  Pdu              The PDU to send out.\r
+  @param[in]       Conn        The iSCSI connection.\r
+  @param[in, out]  Pdu         The PDU to send out.\r
 \r
   @retval EFI_SUCCESS          All check passed and the phase-related CHAP\r
                                authentication info is filled into the iSCSI PDU.\r
@@ -316,8 +314,8 @@ ON_EXIT:
 **/\r
 EFI_STATUS\r
 IScsiCHAPToSendReq (\r
-  IN ISCSI_CONNECTION  *Conn,\r
-  IN NET_BUF           *Pdu\r
+  IN      ISCSI_CONNECTION  *Conn,\r
+  IN OUT  NET_BUF           *Pdu\r
   )\r
 {\r
   EFI_STATUS                Status;\r