Change functional static variable to Global variable. No STATIC modifier is recommend...

[mirror_edk2.git] / MdeModulePkg / Universal / Network / PxeBcDxe / Pxe_loadfile.c

diff --git a/MdeModulePkg/Universal/Network/PxeBcDxe/Pxe_loadfile.c b/MdeModulePkg/Universal/Network/PxeBcDxe/Pxe_loadfile.c
index e430757ce4603f713f2241242169c0799bd95cdf..a15b873bc4c2280e29f14fddbad31b3481d5d245 100644 (file)
--- a/MdeModulePkg/Universal/Network/PxeBcDxe/Pxe_loadfile.c
+++ b/MdeModulePkg/Universal/Network/PxeBcDxe/Pxe_loadfile.c
@@ -1,6 +1,6 @@
 /** @file\r
 \r
-Copyright (c) 2004 - 2007, Intel Corporation\r
+Copyright (c) 2004 - 2008, Intel Corporation\r
 All rights reserved. This program and the accompanying materials\r
 are licensed and made available under the terms and conditions of the BSD License\r
 which accompanies this distribution.  The full text of the license may be found at\r
@@ -39,7 +39,7 @@ typedef union {
   UINT8                     *BytePtr;\r
 } UNION_PTR;\r
 \r
-\r
+UINTN  mPropeller;\r
 \r
 /**\r
   PxeBc callback routine for status updates and aborts.\r
@@ -58,7 +58,6 @@ typedef union {
                                                       -\r
 \r
 **/\r
-STATIC\r
 EFI_PXE_BASE_CODE_CALLBACK_STATUS\r
 EFIAPI\r
 bc_callback (\r
@@ -69,13 +68,11 @@ bc_callback (
   IN EFI_PXE_BASE_CODE_PACKET             * PacketPtr OPTIONAL\r
   )\r
 {\r
-  STATIC UINTN  Propeller;\r
-\r
   EFI_INPUT_KEY Key;\r
   UINTN         Row;\r
   UINTN         Col;\r
 \r
-  Propeller = 0;\r
+  mPropeller = 0;\r
   //\r
   // Resolve Warning 4 unreferenced parameter problem\r
   //\r
@@ -140,16 +137,16 @@ bc_callback (
     Row = gST->ConOut->Mode->CursorRow;\r
     Col = gST->ConOut->Mode->CursorColumn;\r
 \r
-    AsciiPrint ("%c", "/-\\|"[Propeller]);\r
+    AsciiPrint ("%c", "/-\\|"[mPropeller]);\r
     gST->ConOut->SetCursorPosition (gST->ConOut, Col, Row);\r
 \r
-    Propeller = (Propeller + 1) & 3;\r
+    mPropeller = (mPropeller + 1) & 3;\r
   }\r
 \r
   return EFI_PXE_BASE_CODE_CALLBACK_STATUS_CONTINUE;\r
 }\r
 \r
-STATIC EFI_PXE_BASE_CODE_CALLBACK_PROTOCOL  _bc_callback = {\r
+EFI_PXE_BASE_CODE_CALLBACK_PROTOCOL  _bc_callback = {\r
   EFI_PXE_BASE_CODE_CALLBACK_PROTOCOL_REVISION,\r
   &bc_callback\r
 };\r
@@ -163,7 +160,6 @@ STATIC EFI_PXE_BASE_CODE_CALLBACK_PROTOCOL  _bc_callback = {
   @return None\r
 \r
 **/\r
-STATIC\r
 VOID\r
 PrintIpv4 (\r
   UINT8 *Ptr\r
@@ -183,7 +179,6 @@ PrintIpv4 (
   @return None\r
 \r
 **/\r
-STATIC\r
 VOID\r
 ShowMyInfo (\r
   IN PXE_BASECODE_DEVICE *Private\r
@@ -257,7 +252,6 @@ ShowMyInfo (
   @retval LOCAL_BOOT\r
 \r
 **/\r
-STATIC\r
 EFI_STATUS\r
 DoPrompt (\r
   PXE_BASECODE_DEVICE *Private,\r
@@ -447,7 +441,6 @@ DoPrompt (
   @return None\r
 \r
 **/\r
-STATIC\r
 VOID\r
 PrintMenuItem (\r
   PXE_BOOT_MENU_ENTRY *MenuItemPtr\r
@@ -475,7 +468,6 @@ PrintMenuItem (
   @retval LOCAL_BOOT\r
 \r
 **/\r
-STATIC\r
 EFI_STATUS\r
 DoMenu (\r
   PXE_BASECODE_DEVICE *Private,\r
@@ -765,7 +757,6 @@ DoMenu (
   @return Value from DHCP option\r
 \r
 **/\r
-STATIC\r
 UINT16\r
 GetValue (\r
   DHCPV4_OP_STRUCT *OpPtr\r
@@ -789,7 +780,6 @@ GetValue (
   @return Pointer to opcode, may be NULL\r
 \r
 **/\r
-STATIC\r
 UINT8 *\r
 _PxeBcFindOpt (\r
   UINT8 *BufferPtr,\r
@@ -837,7 +827,6 @@ _PxeBcFindOpt (
   @return Pointer to option in packet\r
 \r
 **/\r
-STATIC\r
 UINT8 *\r
 PxeBcFindDhcpOpt (\r
   EFI_PXE_BASE_CODE_PACKET  *PacketPtr,\r
@@ -937,7 +926,6 @@ PxeBcFindDhcpOpt (
   @return EFI_PROTOCOL_ERROR -\r
 \r
 **/\r
-STATIC\r
 EFI_STATUS\r
 DownloadFile (\r
   IN PXE_BASECODE_DEVICE  *Private,\r
@@ -1178,7 +1166,6 @@ DownloadFile (
   @retval EFI_NOT_READY\r
 \r
 **/\r
-STATIC\r
 EFI_STATUS\r
 LoadfileStart (\r
   IN PXE_BASECODE_DEVICE  *Private,\r
@@ -1329,7 +1316,7 @@ LoadFile (
   //\r
   // The following line is only used for passing ICC build.\r
   //\r
-  DEBUG ((EFI_D_INFO, "FilePath = %x\n", FilePath));\r
+  DEBUG ((EFI_D_INFO, "FilePath = %p\n", FilePath));\r
 \r
   //\r
   //\r