Clean up Acpi definitions according to Code Review results.

[mirror_edk2.git] / MdePkg / Include / IndustryStandard / Acpi1_0.h

diff --git a/MdePkg/Include/IndustryStandard/Acpi1_0.h b/MdePkg/Include/IndustryStandard/Acpi1_0.h
index c107da9bd4103a54778cff5479440d0a32a1b5e5..4fc05e6fce07ff17b79c8764cd72c87aa802986f 100644 (file)
--- a/MdePkg/Include/IndustryStandard/Acpi1_0.h
+++ b/MdePkg/Include/IndustryStandard/Acpi1_0.h
@@ -1,7 +1,7 @@
 /** @file   \r
        ACPI 1.0b definitions from the ACPI Specification, revision 1.0b\r
 \r
-  Copyright (c) 2006 - 2007, Intel Corporation\r
+  Copyright (c) 2006 - 2008, Intel Corporation\r
   All rights reserved. This program and the accompanying materials                          \r
   are licensed and made available under the terms and conditions of the BSD License         \r
   which accompanies this distribution.  The full text of the license may be found at        \r
@@ -42,11 +42,14 @@ typedef struct {
 \r
 #pragma pack()\r
 //\r
-// Define for Pci Host Bridge Resource Allocation\r
+// Define for Desriptor\r
 //\r
 #define ACPI_ADDRESS_SPACE_DESCRIPTOR 0x8A\r
 #define ACPI_END_TAG_DESCRIPTOR       0x79\r
 \r
+//\r
+// Resource Type\r
+//\r
 #define ACPI_ADDRESS_SPACE_TYPE_MEM   0x00\r
 #define ACPI_ADDRESS_SPACE_TYPE_IO    0x01\r
 #define ACPI_ADDRESS_SPACE_TYPE_BUS   0x02\r
@@ -56,11 +59,11 @@ typedef struct {
 ///\r
 #define ACPI_TIMER_FREQUENCY       3579545\r
 \r
+\r
 //\r
-// Make sure structures match spec\r
+// The commond definition of QWORD, DWORD, and WORD\r
+// Address Space Descriptors\r
 //\r
-#pragma pack(1)\r
-\r
 typedef struct {\r
   UINT8   Desc;\r
   UINT16  Len;\r
@@ -115,9 +118,6 @@ typedef struct {
 #define EFI_ACPI_MEMORY_RESOURCE_SPECIFIC_FLAG_TYPE_TRANSLATION          (1 << 5)\r
 #define EFI_ACPI_MEMORY_RESOURCE_SPECIFIC_FLAG_TYPE_STATIC               (0 << 5)\r
 \r
-#pragma pack()\r
-\r
-\r
 //\r
 // Ensure proper structure formats\r
 //\r
@@ -139,8 +139,8 @@ typedef struct {
 \r
 //\r
 // Root System Description Table\r
-// No definition needed as it is a common description table header followed by a\r
-// variable number of UINT32 table pointers.\r
+// No definition needed as it is a common description table header, the same with \r
+// EFI_ACPI_DESCRIPTION_HEADER, followed by a variable number of UINT32 table pointers.\r
 //\r
 \r
 ///\r
@@ -256,7 +256,7 @@ typedef struct {
 \r
 //\r
 // Multiple APIC Description Table APIC structure types\r
-// All other values between 0x09 an 0xFF are reserved and\r
+// All other values between 0x05 an 0xFF are reserved and\r
 // will be ignored by OSPM.\r
 //\r
 #define EFI_ACPI_1_0_PROCESSOR_LOCAL_APIC           0x00\r