]> git.proxmox.com Git - mirror_edk2.git/blobdiff - NetworkPkg/DnsDxe/DnsImpl.c
PcAtChipsetPkg/PciHostBridgeDxe/PciHostBridge.c: rewrap leading comments
[mirror_edk2.git] / NetworkPkg / DnsDxe / DnsImpl.c
index c227093986ba1831e240c21faa530d82a559b710..42d51f0ed7a2c2972e53b231bd5b3540f047a3be 100644 (file)
@@ -1049,6 +1049,7 @@ IsValidDnsResponse (
       continue;\r
     } else {\r
       TxString = NetbufGetByte (Packet, 0, NULL);\r
+      ASSERT (TxString != NULL);\r
       DnsHeader = (DNS_HEADER *) TxString;\r
       QueryName = (CHAR8 *) (TxString + sizeof (*DnsHeader));\r
       QuerySection = (DNS_QUERY_SECTION *) (QueryName + AsciiStrLen (QueryName) + 1);\r
@@ -1426,7 +1427,8 @@ DnsOnPacketReceived (
   ASSERT (Packet != NULL);\r
   \r
   RcvString = NetbufGetByte (Packet, 0, NULL);\r
-\r
+  ASSERT (RcvString != NULL);\r
+  \r
   //\r
   // Parse Dns Response\r
   //\r
@@ -1572,8 +1574,8 @@ ConstructDNSQueryIp (
   //\r
   // Fill header\r
   //\r
-  DnsHeader = (DNS_HEADER *)Frag.Bulk; \r
-  DnsHeader->Identification = (UINT16)AsmReadTsc ();\r
+  DnsHeader = (DNS_HEADER *) Frag.Bulk; \r
+  DnsHeader->Identification = (UINT16)NET_RANDOM (NetRandomInitSeed());\r
   DnsHeader->Flags.Uint16 = 0x0000;\r
   DnsHeader->Flags.Bits.RD = 1;\r
   DnsHeader->Flags.Bits.OpCode = DNS_FLAGS_OPCODE_STANDARD;\r
@@ -1583,12 +1585,12 @@ ConstructDNSQueryIp (
   DnsHeader->AuthorityNum = 0;\r
   DnsHeader->AditionalNum = 0;\r
 \r
-  DnsHeader->Identification = HTONS(DnsHeader->Identification);\r
-  DnsHeader->Flags.Uint16 = HTONS(DnsHeader->Flags.Uint16);\r
-  DnsHeader->QuestionsNum = HTONS(DnsHeader->QuestionsNum);\r
-  DnsHeader->AnswersNum = HTONS(DnsHeader->AnswersNum);\r
-  DnsHeader->AuthorityNum = HTONS(DnsHeader->AuthorityNum);\r
-  DnsHeader->AditionalNum = HTONS(DnsHeader->AditionalNum);\r
+  DnsHeader->Identification = HTONS (DnsHeader->Identification);\r
+  DnsHeader->Flags.Uint16 = HTONS (DnsHeader->Flags.Uint16);\r
+  DnsHeader->QuestionsNum = HTONS (DnsHeader->QuestionsNum);\r
+  DnsHeader->AnswersNum = HTONS (DnsHeader->AnswersNum);\r
+  DnsHeader->AuthorityNum = HTONS (DnsHeader->AuthorityNum);\r
+  DnsHeader->AditionalNum = HTONS (DnsHeader->AditionalNum);\r
 \r
   Frag.Len = sizeof (*DnsHeader);\r
 \r