]> git.proxmox.com Git - mirror_edk2.git/blobdiff - StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c
StandaloneMmPkg: fix pointer/int casts against 32bit architectures
[mirror_edk2.git] / StandaloneMmPkg / Library / StandaloneMmCoreEntryPoint / AArch64 / StandaloneMmCoreEntryPoint.c
index 59391df724ad86334528e084022ba028559fe545..b445d6942e4f13b56a192fce3602b6cfb0dbed74 100644 (file)
@@ -23,18 +23,24 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include <Library/BaseLib.h>\r
 #include <Library/BaseMemoryLib.h>\r
 #include <Library/SerialPortLib.h>\r
+#include <Library/PcdLib.h>\r
 \r
 #include <IndustryStandard/ArmStdSmc.h>\r
 #include <IndustryStandard/ArmMmSvc.h>\r
+#include <IndustryStandard/ArmFfaSvc.h>\r
 \r
 #define SPM_MAJOR_VER_MASK        0xFFFF0000\r
 #define SPM_MINOR_VER_MASK        0x0000FFFF\r
 #define SPM_MAJOR_VER_SHIFT       16\r
+#define FFA_NOT_SUPPORTED         -1\r
 \r
-CONST UINT32 SPM_MAJOR_VER = 0;\r
-CONST UINT32 SPM_MINOR_VER = 1;\r
+STATIC CONST UINT32 mSpmMajorVer = SPM_MAJOR_VERSION;\r
+STATIC CONST UINT32 mSpmMinorVer = SPM_MINOR_VERSION;\r
 \r
-CONST UINT8 BOOT_PAYLOAD_VERSION = 1;\r
+STATIC CONST UINT32 mSpmMajorVerFfa = SPM_MAJOR_VERSION_FFA;\r
+STATIC CONST UINT32 mSpmMinorVerFfa = SPM_MINOR_VERSION_FFA;\r
+\r
+#define BOOT_PAYLOAD_VERSION      1\r
 \r
 PI_MM_ARM_TF_CPU_DRIVER_ENTRYPOINT      CpuDriverEntryPoint = NULL;\r
 \r
@@ -114,6 +120,7 @@ DelegatedEventLoop (
   IN ARM_SVC_ARGS *EventCompleteSvcArgs\r
   )\r
 {\r
+  BOOLEAN FfaEnabled;\r
   EFI_STATUS Status;\r
   UINTN SvcStatus;\r
 \r
@@ -125,16 +132,32 @@ DelegatedEventLoop (
     DEBUG ((DEBUG_INFO, "X1 :  0x%x\n", (UINT32) EventCompleteSvcArgs->Arg1));\r
     DEBUG ((DEBUG_INFO, "X2 :  0x%x\n", (UINT32) EventCompleteSvcArgs->Arg2));\r
     DEBUG ((DEBUG_INFO, "X3 :  0x%x\n", (UINT32) EventCompleteSvcArgs->Arg3));\r
-\r
-    Status = CpuDriverEntryPoint (\r
-               EventCompleteSvcArgs->Arg0,\r
-               EventCompleteSvcArgs->Arg3,\r
-               EventCompleteSvcArgs->Arg1\r
-               );\r
-\r
-    if (EFI_ERROR (Status)) {\r
-      DEBUG ((DEBUG_ERROR, "Failed delegated event 0x%x, Status 0x%x\n",\r
-              EventCompleteSvcArgs->Arg0, Status));\r
+    DEBUG ((DEBUG_INFO, "X4 :  0x%x\n", (UINT32) EventCompleteSvcArgs->Arg4));\r
+    DEBUG ((DEBUG_INFO, "X5 :  0x%x\n", (UINT32) EventCompleteSvcArgs->Arg5));\r
+    DEBUG ((DEBUG_INFO, "X6 :  0x%x\n", (UINT32) EventCompleteSvcArgs->Arg6));\r
+    DEBUG ((DEBUG_INFO, "X7 :  0x%x\n", (UINT32) EventCompleteSvcArgs->Arg7));\r
+\r
+    FfaEnabled = FeaturePcdGet (PcdFfaEnable);\r
+    if (FfaEnabled) {\r
+      Status = CpuDriverEntryPoint (\r
+                 EventCompleteSvcArgs->Arg0,\r
+                 EventCompleteSvcArgs->Arg6,\r
+                 EventCompleteSvcArgs->Arg3\r
+                 );\r
+      if (EFI_ERROR (Status)) {\r
+        DEBUG ((DEBUG_ERROR, "Failed delegated event 0x%x, Status 0x%x\n",\r
+          EventCompleteSvcArgs->Arg3, Status));\r
+      }\r
+    } else {\r
+      Status = CpuDriverEntryPoint (\r
+                 EventCompleteSvcArgs->Arg0,\r
+                 EventCompleteSvcArgs->Arg3,\r
+                 EventCompleteSvcArgs->Arg1\r
+                 );\r
+      if (EFI_ERROR (Status)) {\r
+        DEBUG ((DEBUG_ERROR, "Failed delegated event 0x%x, Status 0x%x\n",\r
+          EventCompleteSvcArgs->Arg0, Status));\r
+      }\r
     }\r
 \r
     switch (Status) {\r
@@ -158,8 +181,16 @@ DelegatedEventLoop (
       break;\r
     }\r
 \r
-    EventCompleteSvcArgs->Arg0 = ARM_SVC_ID_SP_EVENT_COMPLETE_AARCH64;\r
-    EventCompleteSvcArgs->Arg1 = SvcStatus;\r
+    if (FfaEnabled) {\r
+      EventCompleteSvcArgs->Arg0 = ARM_SVC_ID_FFA_MSG_SEND_DIRECT_RESP_AARCH64;\r
+      EventCompleteSvcArgs->Arg1 = 0;\r
+      EventCompleteSvcArgs->Arg2 = 0;\r
+      EventCompleteSvcArgs->Arg3 = ARM_SVC_ID_SP_EVENT_COMPLETE_AARCH64;\r
+      EventCompleteSvcArgs->Arg4 = SvcStatus;\r
+    } else {\r
+      EventCompleteSvcArgs->Arg0 = ARM_SVC_ID_SP_EVENT_COMPLETE_AARCH64;\r
+      EventCompleteSvcArgs->Arg1 = SvcStatus;\r
+    }\r
   }\r
 }\r
 \r
@@ -174,19 +205,34 @@ EFI_STATUS
 GetSpmVersion (VOID)\r
 {\r
   EFI_STATUS   Status;\r
-  UINT16       SpmMajorVersion;\r
-  UINT16       SpmMinorVersion;\r
+  UINT16       CalleeSpmMajorVer;\r
+  UINT16       CallerSpmMajorVer;\r
+  UINT16       CalleeSpmMinorVer;\r
+  UINT16       CallerSpmMinorVer;\r
   UINT32       SpmVersion;\r
   ARM_SVC_ARGS SpmVersionArgs;\r
 \r
-  SpmVersionArgs.Arg0 = ARM_SVC_ID_SPM_VERSION_AARCH32;\r
+  if (FeaturePcdGet (PcdFfaEnable)) {\r
+    SpmVersionArgs.Arg0 = ARM_SVC_ID_FFA_VERSION_AARCH32;\r
+    SpmVersionArgs.Arg1 = mSpmMajorVerFfa << SPM_MAJOR_VER_SHIFT;\r
+    SpmVersionArgs.Arg1 |= mSpmMinorVerFfa;\r
+    CallerSpmMajorVer = mSpmMajorVerFfa;\r
+    CallerSpmMinorVer = mSpmMinorVerFfa;\r
+  } else {\r
+    SpmVersionArgs.Arg0 = ARM_SVC_ID_SPM_VERSION_AARCH32;\r
+    CallerSpmMajorVer = mSpmMajorVer;\r
+    CallerSpmMinorVer = mSpmMinorVer;\r
+  }\r
 \r
   ArmCallSvc (&SpmVersionArgs);\r
 \r
   SpmVersion = SpmVersionArgs.Arg0;\r
+  if (SpmVersion == FFA_NOT_SUPPORTED) {\r
+    return EFI_UNSUPPORTED;\r
+  }\r
 \r
-  SpmMajorVersion = ((SpmVersion & SPM_MAJOR_VER_MASK) >> SPM_MAJOR_VER_SHIFT);\r
-  SpmMinorVersion = ((SpmVersion & SPM_MINOR_VER_MASK) >> 0);\r
+  CalleeSpmMajorVer = ((SpmVersion & SPM_MAJOR_VER_MASK) >> SPM_MAJOR_VER_SHIFT);\r
+  CalleeSpmMinorVer = ((SpmVersion & SPM_MINOR_VER_MASK) >> 0);\r
 \r
   // Different major revision values indicate possibly incompatible functions.\r
   // For two revisions, A and B, for which the major revision values are\r
@@ -195,23 +241,49 @@ GetSpmVersion (VOID)
   // revision A must work in a compatible way with revision B.\r
   // However, it is possible for revision B to have a higher\r
   // function count than revision A.\r
-  if ((SpmMajorVersion == SPM_MAJOR_VER) &&\r
-      (SpmMinorVersion >= SPM_MINOR_VER))\r
+  if ((CalleeSpmMajorVer == CallerSpmMajorVer) &&\r
+      (CalleeSpmMinorVer >= CallerSpmMinorVer))\r
   {\r
     DEBUG ((DEBUG_INFO, "SPM Version: Major=0x%x, Minor=0x%x\n",\r
-           SpmMajorVersion, SpmMinorVersion));\r
+           CalleeSpmMajorVer, CalleeSpmMinorVer));\r
     Status = EFI_SUCCESS;\r
   }\r
   else\r
   {\r
-    DEBUG ((DEBUG_INFO, "Incompatible SPM Versions.\n Current Version: Major=0x%x, Minor=0x%x.\n Expected: Major=0x%x, Minor>=0x%x.\n",\r
-            SpmMajorVersion, SpmMinorVersion, SPM_MAJOR_VER, SPM_MINOR_VER));\r
+    DEBUG ((DEBUG_INFO, "Incompatible SPM Versions.\n Callee Version: Major=0x%x, Minor=0x%x.\n Caller: Major=0x%x, Minor>=0x%x.\n",\r
+            CalleeSpmMajorVer, CalleeSpmMinorVer, CallerSpmMajorVer, CallerSpmMinorVer));\r
     Status = EFI_UNSUPPORTED;\r
   }\r
 \r
   return Status;\r
 }\r
 \r
+/**\r
+  Initialize parameters to be sent via SVC call.\r
+\r
+  @param[out]     InitMmFoundationSvcArgs  Args structure\r
+  @param[out]     Ret                      Return Code\r
+\r
+**/\r
+STATIC\r
+VOID\r
+InitArmSvcArgs (\r
+  OUT ARM_SVC_ARGS *InitMmFoundationSvcArgs,\r
+  OUT INT32 *Ret\r
+  )\r
+{\r
+  if (FeaturePcdGet (PcdFfaEnable)) {\r
+    InitMmFoundationSvcArgs->Arg0 = ARM_SVC_ID_FFA_MSG_SEND_DIRECT_RESP_AARCH64;\r
+    InitMmFoundationSvcArgs->Arg1 = 0;\r
+    InitMmFoundationSvcArgs->Arg2 = 0;\r
+    InitMmFoundationSvcArgs->Arg3 = ARM_SVC_ID_SP_EVENT_COMPLETE_AARCH64;\r
+    InitMmFoundationSvcArgs->Arg4 = *Ret;\r
+  } else {\r
+    InitMmFoundationSvcArgs->Arg0 = ARM_SVC_ID_SP_EVENT_COMPLETE_AARCH64;\r
+    InitMmFoundationSvcArgs->Arg1 = *Ret;\r
+  }\r
+}\r
+\r
 /**\r
   The entry point of Standalone MM Foundation.\r
 \r
@@ -234,6 +306,7 @@ _ModuleEntryPoint (
   EFI_SECURE_PARTITION_BOOT_INFO          *PayloadBootInfo;\r
   ARM_SVC_ARGS                            InitMmFoundationSvcArgs;\r
   EFI_STATUS                              Status;\r
+  INT32                                   Ret;\r
   UINT32                                  SectionHeaderOffset;\r
   UINT16                                  NumberOfSections;\r
   VOID                                    *HobStart;\r
@@ -255,7 +328,7 @@ _ModuleEntryPoint (
 \r
   // Locate PE/COFF File information for the Standalone MM core module\r
   Status = LocateStandaloneMmCorePeCoffData (\r
-             (EFI_FIRMWARE_VOLUME_HEADER *) PayloadBootInfo->SpImageBase,\r
+             (EFI_FIRMWARE_VOLUME_HEADER *) (UINTN) PayloadBootInfo->SpImageBase,\r
              &TeData,\r
              &TeDataSize\r
              );\r
@@ -325,8 +398,16 @@ _ModuleEntryPoint (
   DEBUG ((DEBUG_INFO, "Shared Cpu Driver EP 0x%lx\n", (UINT64) CpuDriverEntryPoint));\r
 \r
 finish:\r
+  if (Status == RETURN_UNSUPPORTED) {\r
+    Ret = -1;\r
+  } else if (Status == RETURN_INVALID_PARAMETER) {\r
+    Ret = -2;\r
+  } else if (Status == EFI_NOT_FOUND) {\r
+    Ret = -7;\r
+  } else {\r
+    Ret = 0;\r
+  }\r
   ZeroMem (&InitMmFoundationSvcArgs, sizeof(InitMmFoundationSvcArgs));\r
-  InitMmFoundationSvcArgs.Arg0 = ARM_SVC_ID_SP_EVENT_COMPLETE_AARCH64;\r
-  InitMmFoundationSvcArgs.Arg1 = Status;\r
+  InitArmSvcArgs (&InitMmFoundationSvcArgs, &Ret);\r
   DelegatedEventLoop (&InitMmFoundationSvcArgs);\r
 }\r