UefiCpuPkg/PiSmmCpuDxeSmm: Make code consistent with comments

[mirror_edk2.git] / UefiCpuPkg / CpuS3DataDxe / CpuS3Data.c

diff --git a/UefiCpuPkg/CpuS3DataDxe/CpuS3Data.c b/UefiCpuPkg/CpuS3DataDxe/CpuS3Data.c
index 3e8c8b383c9d08f1ed1804ec1d9a9b80e2a723a1..2be335d9190369c2d8183131018f1854f9b22936 100644 (file)
--- a/UefiCpuPkg/CpuS3DataDxe/CpuS3Data.c
+++ b/UefiCpuPkg/CpuS3DataDxe/CpuS3Data.c
@@ -12,13 +12,7 @@ and customized if these additional features are required.
 Copyright (c) 2013 - 2017, Intel Corporation. All rights reserved.<BR>\r
 Copyright (c) 2015, Red Hat, Inc.\r
 \r
-This program and the accompanying materials\r
-are licensed and made available under the terms and conditions of the BSD License\r
-which accompanies this distribution.  The full text of the license may be found at\r
-http://opensource.org/licenses/bsd-license.php\r
-\r
-THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,\r
-WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.\r
+SPDX-License-Identifier: BSD-2-Clause-Patent\r
 \r
 **/\r
 \r
@@ -47,9 +41,7 @@ typedef struct {
 } ACPI_CPU_DATA_EX;\r
 \r
 /**\r
-  Allocate EfiACPIMemoryNVS below 4G memory address.\r
-\r
-  This function allocates EfiACPIMemoryNVS below 4G memory address.\r
+  Allocate EfiACPIMemoryNVS memory.\r
 \r
   @param[in] Size   Size of memory to allocate.\r
 \r
@@ -57,7 +49,7 @@ typedef struct {
 \r
 **/\r
 VOID *\r
-AllocateAcpiNvsMemoryBelow4G (\r
+AllocateAcpiNvsMemory (\r
   IN UINTN  Size\r
   )\r
 {\r
@@ -65,9 +57,8 @@ AllocateAcpiNvsMemoryBelow4G (
   EFI_STATUS            Status;\r
   VOID                  *Buffer;\r
 \r
-  Address = BASE_4GB - 1;\r
   Status  = gBS->AllocatePages (\r
-                   AllocateMaxAddress,\r
+                   AllocateAnyPages,\r
                    EfiACPIMemoryNVS,\r
                    EFI_SIZE_TO_PAGES (Size),\r
                    &Address\r
@@ -230,9 +221,13 @@ CpuS3DataInitialize (
   AcpiCpuData->MtrrTable    = (EFI_PHYSICAL_ADDRESS)(UINTN)&AcpiCpuDataEx->MtrrTable;\r
 \r
   //\r
-  // Allocate stack space for all CPUs\r
+  // Allocate stack space for all CPUs.\r
+  // Use ACPI NVS memory type because this data will be directly used by APs\r
+  // in S3 resume phase in long mode. Also during S3 resume, the stack buffer\r
+  // will only be used as scratch space. i.e. we won't read anything from it\r
+  // before we write to it, in PiSmmCpuDxeSmm.\r
   //\r
-  Stack = AllocateAcpiNvsMemoryBelow4G (NumberOfCpus * AcpiCpuData->StackSize);\r
+  Stack = AllocateAcpiNvsMemory (NumberOfCpus * AcpiCpuData->StackSize);\r
   ASSERT (Stack != NULL);\r
   AcpiCpuData->StackAddress = (EFI_PHYSICAL_ADDRESS)(UINTN)Stack;\r
 \r
@@ -258,6 +253,8 @@ CpuS3DataInitialize (
   if (OldAcpiCpuData != NULL) {\r
     AcpiCpuData->RegisterTable           = OldAcpiCpuData->RegisterTable;\r
     AcpiCpuData->PreSmmInitRegisterTable = OldAcpiCpuData->PreSmmInitRegisterTable;\r
+    AcpiCpuData->ApLocation              = OldAcpiCpuData->ApLocation;\r
+    CopyMem (&AcpiCpuData->CpuStatus, &OldAcpiCpuData->CpuStatus, sizeof (CPU_STATUS_INFORMATION));\r
   } else {\r
     //\r
     // Allocate buffer for empty RegisterTable and PreSmmInitRegisterTable for all CPUs\r