]> git.proxmox.com Git - mirror_edk2.git/blobdiff - UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c
UefiCpuPkg/RegisterCpuFeaturesLib: Remove debug message.
[mirror_edk2.git] / UefiCpuPkg / Library / RegisterCpuFeaturesLib / CpuFeaturesInitialize.c
index 1e25ba8b3288cfa9d32ea93cf05b2e26f2978f93..fb0535edd67a50fdaf9aa9bf2e8ed1d3c0e798e5 100644 (file)
@@ -9,26 +9,21 @@
 #include "RegisterCpuFeatures.h"\r
 \r
 CHAR16 *mDependTypeStr[]   = {L"None", L"Thread", L"Core", L"Package", L"Invalid" };\r
-CHAR16 *mRegisterTypeStr[] = {L"MSR", L"CR", L"MMIO", L"CACHE", L"SEMAP", L"INVALID" };\r
 \r
 /**\r
   Worker function to save PcdCpuFeaturesCapability.\r
 \r
   @param[in]  SupportedFeatureMask  The pointer to CPU feature bits mask buffer\r
-  @param[in]  FeatureMaskSize       CPU feature bits mask buffer size.\r
+  @param[in]  BitMaskSize           CPU feature bits mask buffer size.\r
 \r
 **/\r
 VOID\r
 SetCapabilityPcd (\r
   IN UINT8               *SupportedFeatureMask,\r
-  IN UINT32              FeatureMaskSize\r
+  IN UINTN               BitMaskSize\r
   )\r
 {\r
   EFI_STATUS             Status;\r
-  UINTN                  BitMaskSize;\r
-\r
-  BitMaskSize = PcdGetSize (PcdCpuFeaturesCapability);\r
-  ASSERT (FeatureMaskSize == BitMaskSize);\r
 \r
   Status = PcdSetPtrS (PcdCpuFeaturesCapability, &BitMaskSize, SupportedFeatureMask);\r
   ASSERT_EFI_ERROR (Status);\r
@@ -38,16 +33,16 @@ SetCapabilityPcd (
   Worker function to save PcdCpuFeaturesSetting.\r
 \r
   @param[in]  SupportedFeatureMask  The pointer to CPU feature bits mask buffer\r
+  @param[in]  BitMaskSize           CPU feature bits mask buffer size.\r
 **/\r
 VOID\r
 SetSettingPcd (\r
-  IN UINT8               *SupportedFeatureMask\r
+  IN UINT8               *SupportedFeatureMask,\r
+  IN UINTN               BitMaskSize\r
   )\r
 {\r
   EFI_STATUS             Status;\r
-  UINTN                  BitMaskSize;\r
 \r
-  BitMaskSize = PcdGetSize (PcdCpuFeaturesSetting);\r
   Status = PcdSetPtrS (PcdCpuFeaturesSetting, &BitMaskSize, SupportedFeatureMask);\r
   ASSERT_EFI_ERROR (Status);\r
 }\r
@@ -272,19 +267,20 @@ SupportedMaskOr (
 \r
   @param[in]  SupportedFeatureMask  The pointer to CPU feature bits mask buffer\r
   @param[in]  AndFeatureBitMask     The feature bit mask to do AND operation\r
+  @param[in]  BitMaskSize           CPU feature bits mask buffer size.\r
+\r
 **/\r
 VOID\r
 SupportedMaskAnd (\r
   IN       UINT8               *SupportedFeatureMask,\r
-  IN CONST UINT8               *AndFeatureBitMask\r
+  IN CONST UINT8               *AndFeatureBitMask,\r
+  IN       UINT32              BitMaskSize\r
   )\r
 {\r
   UINTN                  Index;\r
-  UINTN                  BitMaskSize;\r
   UINT8                  *Data1;\r
   CONST UINT8            *Data2;\r
 \r
-  BitMaskSize = PcdGetSize (PcdCpuFeaturesSetting);\r
   Data1 = SupportedFeatureMask;\r
   Data2 = AndFeatureBitMask;\r
   for (Index = 0; Index < BitMaskSize; Index++) {\r
@@ -297,19 +293,19 @@ SupportedMaskAnd (
 \r
   @param[in]  SupportedFeatureMask  The pointer to CPU feature bits mask buffer\r
   @param[in]  AndFeatureBitMask     The feature bit mask to do XOR operation\r
+  @param[in]  BitMaskSize           CPU feature bits mask buffer size.\r
 **/\r
 VOID\r
 SupportedMaskCleanBit (\r
   IN UINT8               *SupportedFeatureMask,\r
-  IN UINT8               *AndFeatureBitMask\r
+  IN UINT8               *AndFeatureBitMask,\r
+  IN UINT32              BitMaskSize\r
   )\r
 {\r
   UINTN                  Index;\r
-  UINTN                  BitMaskSize;\r
   UINT8                  *Data1;\r
   UINT8                  *Data2;\r
 \r
-  BitMaskSize = PcdGetSize (PcdCpuFeaturesSetting);\r
   Data1 = SupportedFeatureMask;\r
   Data2 = AndFeatureBitMask;\r
   for (Index = 0; Index < BitMaskSize; Index++) {\r
@@ -323,6 +319,7 @@ SupportedMaskCleanBit (
 \r
   @param[in]  SupportedFeatureMask   The pointer to CPU feature bits mask buffer\r
   @param[in]  ComparedFeatureBitMask The feature bit mask to be compared\r
+  @param[in]  BitMaskSize            CPU feature bits mask buffer size.\r
 \r
   @retval TRUE   The ComparedFeatureBitMask is set in CPU feature supported bits\r
                  mask buffer.\r
@@ -332,16 +329,14 @@ SupportedMaskCleanBit (
 BOOLEAN\r
 IsBitMaskMatch (\r
   IN UINT8               *SupportedFeatureMask,\r
-  IN UINT8               *ComparedFeatureBitMask\r
+  IN UINT8               *ComparedFeatureBitMask,\r
+  IN UINT32              BitMaskSize\r
   )\r
 {\r
   UINTN                  Index;\r
-  UINTN                  BitMaskSize;\r
   UINT8                  *Data1;\r
   UINT8                  *Data2;\r
 \r
-  BitMaskSize = PcdGetSize (PcdCpuFeaturesSetting);\r
-\r
   Data1 = SupportedFeatureMask;\r
   Data2 = ComparedFeatureBitMask;\r
   for (Index = 0; Index < BitMaskSize; Index++) {\r
@@ -557,14 +552,14 @@ AnalysisProcessorFeatures (
     //\r
     // Calculate the last capability on all processors\r
     //\r
-    SupportedMaskAnd (CpuFeaturesData->CapabilityPcd, CpuInitOrder->FeaturesSupportedMask);\r
+    SupportedMaskAnd (CpuFeaturesData->CapabilityPcd, CpuInitOrder->FeaturesSupportedMask, CpuFeaturesData->BitMaskSize);\r
   }\r
   //\r
   // Calculate the last setting\r
   //\r
   CpuFeaturesData->SettingPcd = AllocateCopyPool (CpuFeaturesData->BitMaskSize, CpuFeaturesData->CapabilityPcd);\r
   ASSERT (CpuFeaturesData->SettingPcd != NULL);\r
-  SupportedMaskAnd (CpuFeaturesData->SettingPcd, PcdGetPtr (PcdCpuFeaturesSetting));\r
+  SupportedMaskAnd (CpuFeaturesData->SettingPcd, PcdGetPtr (PcdCpuFeaturesSetting), CpuFeaturesData->BitMaskSize);\r
 \r
   //\r
   // Dump the last CPU feature list\r
@@ -574,8 +569,8 @@ AnalysisProcessorFeatures (
     Entry = GetFirstNode (&CpuFeaturesData->FeatureList);\r
     while (!IsNull (&CpuFeaturesData->FeatureList, Entry)) {\r
       CpuFeature = CPU_FEATURE_ENTRY_FROM_LINK (Entry);\r
-      if (IsBitMaskMatch (CpuFeature->FeatureMask, CpuFeaturesData->CapabilityPcd)) {\r
-        if (IsBitMaskMatch (CpuFeature->FeatureMask, CpuFeaturesData->SettingPcd)) {\r
+      if (IsBitMaskMatch (CpuFeature->FeatureMask, CpuFeaturesData->CapabilityPcd, CpuFeaturesData->BitMaskSize)) {\r
+        if (IsBitMaskMatch (CpuFeature->FeatureMask, CpuFeaturesData->SettingPcd, CpuFeaturesData->BitMaskSize)) {\r
           DEBUG ((DEBUG_INFO, "[Enable   ] "));\r
         } else {\r
           DEBUG ((DEBUG_INFO, "[Disable  ] "));\r
@@ -583,22 +578,22 @@ AnalysisProcessorFeatures (
       } else {\r
         DEBUG ((DEBUG_INFO, "[Unsupport] "));\r
       }\r
-      DumpCpuFeature (CpuFeature);\r
+      DumpCpuFeature (CpuFeature, CpuFeaturesData->BitMaskSize);\r
       Entry = Entry->ForwardLink;\r
     }\r
     DEBUG ((DEBUG_INFO, "PcdCpuFeaturesCapability:\n"));\r
-    DumpCpuFeatureMask (CpuFeaturesData->CapabilityPcd);\r
+    DumpCpuFeatureMask (CpuFeaturesData->CapabilityPcd, CpuFeaturesData->BitMaskSize);\r
     DEBUG ((DEBUG_INFO, "Origin PcdCpuFeaturesSetting:\n"));\r
-    DumpCpuFeatureMask (PcdGetPtr (PcdCpuFeaturesSetting));\r
+    DumpCpuFeatureMask (PcdGetPtr (PcdCpuFeaturesSetting), CpuFeaturesData->BitMaskSize);\r
     DEBUG ((DEBUG_INFO, "Final PcdCpuFeaturesSetting:\n"));\r
-    DumpCpuFeatureMask (CpuFeaturesData->SettingPcd);\r
+    DumpCpuFeatureMask (CpuFeaturesData->SettingPcd, CpuFeaturesData->BitMaskSize);\r
   );\r
 \r
   //\r
   // Save PCDs and display CPU PCDs\r
   //\r
   SetCapabilityPcd (CpuFeaturesData->CapabilityPcd, CpuFeaturesData->BitMaskSize);\r
-  SetSettingPcd (CpuFeaturesData->SettingPcd);\r
+  SetSettingPcd (CpuFeaturesData->SettingPcd, CpuFeaturesData->BitMaskSize);\r
 \r
   for (ProcessorNumber = 0; ProcessorNumber < NumberOfCpus; ProcessorNumber++) {\r
     CpuInitOrder = &CpuFeaturesData->InitOrder[ProcessorNumber];\r
@@ -608,7 +603,7 @@ AnalysisProcessorFeatures (
       // Insert each feature into processor's order list\r
       //\r
       CpuFeature = CPU_FEATURE_ENTRY_FROM_LINK (Entry);\r
-      if (IsBitMaskMatch (CpuFeature->FeatureMask, CpuFeaturesData->CapabilityPcd)) {\r
+      if (IsBitMaskMatch (CpuFeature->FeatureMask, CpuFeaturesData->CapabilityPcd, CpuFeaturesData->BitMaskSize)) {\r
         CpuFeatureInOrder = AllocateCopyPool (sizeof (CPU_FEATURES_ENTRY), CpuFeature);\r
         ASSERT (CpuFeatureInOrder != NULL);\r
         InsertTailList (&CpuInitOrder->OrderList, &CpuFeatureInOrder->Link);\r
@@ -624,18 +619,18 @@ AnalysisProcessorFeatures (
       CpuFeatureInOrder = CPU_FEATURE_ENTRY_FROM_LINK (Entry);\r
 \r
       Success = FALSE;\r
-      if (IsBitMaskMatch (CpuFeatureInOrder->FeatureMask, CpuFeaturesData->SettingPcd)) {\r
+      if (IsBitMaskMatch (CpuFeatureInOrder->FeatureMask, CpuFeaturesData->SettingPcd, CpuFeaturesData->BitMaskSize)) {\r
         Status = CpuFeatureInOrder->InitializeFunc (ProcessorNumber, CpuInfo, CpuFeatureInOrder->ConfigData, TRUE);\r
         if (EFI_ERROR (Status)) {\r
           //\r
           // Clean the CpuFeatureInOrder->FeatureMask in setting PCD.\r
           //\r
-          SupportedMaskCleanBit (CpuFeaturesData->SettingPcd, CpuFeatureInOrder->FeatureMask);\r
+          SupportedMaskCleanBit (CpuFeaturesData->SettingPcd, CpuFeatureInOrder->FeatureMask, CpuFeaturesData->BitMaskSize);\r
           if (CpuFeatureInOrder->FeatureName != NULL) {\r
             DEBUG ((DEBUG_WARN, "Warning :: Failed to enable Feature: Name = %a.\n", CpuFeatureInOrder->FeatureName));\r
           } else {\r
             DEBUG ((DEBUG_WARN, "Warning :: Failed to enable Feature: Mask = "));\r
-            DumpCpuFeatureMask (CpuFeatureInOrder->FeatureMask);\r
+            DumpCpuFeatureMask (CpuFeatureInOrder->FeatureMask, CpuFeaturesData->BitMaskSize);\r
           }\r
         } else {\r
           Success = TRUE;\r
@@ -647,7 +642,7 @@ AnalysisProcessorFeatures (
             DEBUG ((DEBUG_WARN, "Warning :: Failed to disable Feature: Name = %a.\n", CpuFeatureInOrder->FeatureName));\r
           } else {\r
             DEBUG ((DEBUG_WARN, "Warning :: Failed to disable Feature: Mask = "));\r
-            DumpCpuFeatureMask (CpuFeatureInOrder->FeatureMask);\r
+            DumpCpuFeatureMask (CpuFeatureInOrder->FeatureMask, CpuFeaturesData->BitMaskSize);\r
           }\r
         } else {\r
           Success = TRUE;\r
@@ -699,7 +694,7 @@ AnalysisProcessorFeatures (
     // again during initialize the features.\r
     //\r
     DEBUG ((DEBUG_INFO, "Dump final value for PcdCpuFeaturesSetting:\n"));\r
-    DumpCpuFeatureMask (CpuFeaturesData->SettingPcd);\r
+    DumpCpuFeatureMask (CpuFeaturesData->SettingPcd, CpuFeaturesData->BitMaskSize);\r
 \r
     //\r
     // Dump the RegisterTable\r
@@ -776,7 +771,6 @@ ProgramProcessorRegister (
   UINT32                    PackageThreadsCount;\r
   UINT32                    CurrentThread;\r
   UINTN                     ProcessorIndex;\r
-  UINTN                     ThreadIndex;\r
   UINTN                     ValidThreadCount;\r
   UINT32                    *ValidCoreCountPerPackage;\r
 \r
@@ -789,26 +783,6 @@ ProgramProcessorRegister (
 \r
     RegisterTableEntry = &RegisterTableEntryHead[Index];\r
 \r
-    DEBUG_CODE_BEGIN ();\r
-      //\r
-      // Wait for the AP to release the MSR spin lock.\r
-      //\r
-      while (!AcquireSpinLockOrFail (&CpuFlags->ConsoleLogLock)) {\r
-        CpuPause ();\r
-      }\r
-      ThreadIndex = ApLocation->Package * CpuStatus->MaxCoreCount * CpuStatus->MaxThreadCount +\r
-              ApLocation->Core * CpuStatus->MaxThreadCount +\r
-              ApLocation->Thread;\r
-      DEBUG ((\r
-        DEBUG_INFO,\r
-        "Processor = %08lu, Index %08lu, Type = %s!\n",\r
-        (UINT64)ThreadIndex,\r
-        (UINT64)Index,\r
-        mRegisterTypeStr[MIN ((REGISTER_TYPE)RegisterTableEntry->RegisterType, InvalidReg)]\r
-        ));\r
-      ReleaseSpinLock (&CpuFlags->ConsoleLogLock);\r
-    DEBUG_CODE_END ();\r
-\r
     //\r
     // Check the type of specified register\r
     //\r
@@ -1078,7 +1052,7 @@ CpuFeaturesDetect (
     //\r
     // Wakeup all APs for data collection.\r
     //\r
-    StartupAPsWorker (CollectProcessorData, NULL);\r
+    StartupAllAPsWorker (CollectProcessorData, NULL);\r
   }\r
 \r
   //\r