import 15.2.0 Octopus source

[ceph.git] / ceph / src / pybind / mgr / dashboard / ci / check_grafana_uids.py

diff --git a/ceph/src/pybind/mgr/dashboard/ci/check_grafana_uids.py b/ceph/src/pybind/mgr/dashboard/ci/check_grafana_uids.py
index 134bb6e7fbd3242de754324f3192ff18eca32114..fac3b9953971551d1c392a5997ff94caedb55113 100644 (file)
--- a/ceph/src/pybind/mgr/dashboard/ci/check_grafana_uids.py
+++ b/ceph/src/pybind/mgr/dashboard/ci/check_grafana_uids.py
@@ -85,6 +85,13 @@ def get_grafana_dashboards(base_dir):
         with open(json_file) as f:
             dashboard_config = json.load(f)
             uid = dashboard_config.get('uid')
+
+            # Grafana dashboard checks
+            title = dashboard_config['title']
+            assert len(title) > 0, \
+                "Title not found in '{}'".format(json_file)
+            assert len(dashboard_config.get('links', [])) == 0, \
+                "Links found in '{}'".format(json_file)
             if not uid:
                 continue
             if uid in dashboards:
@@ -92,9 +99,10 @@ def get_grafana_dashboards(base_dir):
                 error_msg = 'Duplicated UID {} found, already defined in {}'.\
                     format(uid, dashboards[uid]['file'])
                 exit(error_msg)
+
             dashboards[uid] = {
                 'file': json_file,
-                'title': dashboard_config['title']
+                'title': title
             }
     return dashboards