update ceph source to reef 18.1.2

[ceph.git] / ceph / src / rocksdb / utilities / table_properties_collectors / compact_on_deletion_collector_test.cc

diff --git a/ceph/src/rocksdb/utilities/table_properties_collectors/compact_on_deletion_collector_test.cc b/ceph/src/rocksdb/utilities/table_properties_collectors/compact_on_deletion_collector_test.cc
index 40cb04abb66a8db9974bcc40124d941cd2d8ea34..88aeb8d5c92fb3acfbd5c09a988847816ddd602a 100644 (file)
--- a/ceph/src/rocksdb/utilities/table_properties_collectors/compact_on_deletion_collector_test.cc
+++ b/ceph/src/rocksdb/utilities/table_properties_collectors/compact_on_deletion_collector_test.cc
@@ -38,10 +38,11 @@ TEST(CompactOnDeletionCollector, DeletionRatio) {
           factory->CreateTablePropertiesCollector(context));
       for (size_t i = 0; i < kTotalEntries; i++) {
         // All entries are deletion entries.
-        collector->AddUserKey("hello", "rocksdb", kEntryDelete, 0, 0);
+        ASSERT_OK(
+            collector->AddUserKey("hello", "rocksdb", kEntryDelete, 0, 0));
         ASSERT_FALSE(collector->NeedCompact());
       }
-      collector->Finish(nullptr);
+      ASSERT_OK(collector->Finish(nullptr));
       ASSERT_FALSE(collector->NeedCompact());
     }
   }
@@ -58,13 +59,15 @@ TEST(CompactOnDeletionCollector, DeletionRatio) {
             factory->CreateTablePropertiesCollector(context));
         for (size_t i = 0; i < kTotalEntries; i++) {
           if (i < actual_deletion_entries) {
-            collector->AddUserKey("hello", "rocksdb", kEntryDelete, 0, 0);
+            ASSERT_OK(
+                collector->AddUserKey("hello", "rocksdb", kEntryDelete, 0, 0));
           } else {
-            collector->AddUserKey("hello", "rocksdb", kEntryPut, 0, 0);
+            ASSERT_OK(
+                collector->AddUserKey("hello", "rocksdb", kEntryPut, 0, 0));
           }
           ASSERT_FALSE(collector->NeedCompact());
         }
-        collector->Finish(nullptr);
+        ASSERT_OK(collector->Finish(nullptr));
         if (delta >= 0) {
           // >= deletion_ratio
           ASSERT_TRUE(collector->NeedCompact());
@@ -77,10 +80,10 @@ TEST(CompactOnDeletionCollector, DeletionRatio) {
 }
 
 TEST(CompactOnDeletionCollector, SlidingWindow) {
-  const int kWindowSizes[] =
-      {1000, 10000, 10000, 127, 128, 129, 255, 256, 257, 2, 10000};
-  const int kDeletionTriggers[] =
-      {500, 9500, 4323, 47, 61, 128, 250, 250, 250, 2, 2};
+  const int kWindowSizes[] = {1000, 10000, 10000, 127, 128,  129,
+                              255,  256,   257,   2,   10000};
+  const int kDeletionTriggers[] = {500, 9500, 4323, 47, 61, 128,
+                                   250, 250,  250,  2,  2};
   TablePropertiesCollectorFactory::Context context;
   context.column_family_id =
       TablePropertiesCollectorFactory::Context::kUnknownColumnFamily;
@@ -123,22 +126,24 @@ TEST(CompactOnDeletionCollector, SlidingWindow) {
         int deletions = 0;
         for (int i = 0; i < kPaddedWindowSize; ++i) {
           if (i % kSample < delete_rate) {
-            collector->AddUserKey("hello", "rocksdb", kEntryDelete, 0, 0);
+            ASSERT_OK(
+                collector->AddUserKey("hello", "rocksdb", kEntryDelete, 0, 0));
             deletions++;
           } else {
-            collector->AddUserKey("hello", "rocksdb", kEntryPut, 0, 0);
+            ASSERT_OK(
+                collector->AddUserKey("hello", "rocksdb", kEntryPut, 0, 0));
           }
         }
-        if (collector->NeedCompact() !=
-            (deletions >= kNumDeletionTrigger) &&
+        if (collector->NeedCompact() != (deletions >= kNumDeletionTrigger) &&
             std::abs(deletions - kNumDeletionTrigger) > kBias) {
-          fprintf(stderr, "[Error] collector->NeedCompact() != (%d >= %d)"
+          fprintf(stderr,
+                  "[Error] collector->NeedCompact() != (%d >= %d)"
                   " with kWindowSize = %d and kNumDeletionTrigger = %d\n",
-                  deletions, kNumDeletionTrigger,
-                  kWindowSize, kNumDeletionTrigger);
+                  deletions, kNumDeletionTrigger, kWindowSize,
+                  kNumDeletionTrigger);
           ASSERT_TRUE(false);
         }
-        collector->Finish(nullptr);
+        ASSERT_OK(collector->Finish(nullptr));
       }
     }
 
@@ -154,33 +159,37 @@ TEST(CompactOnDeletionCollector, SlidingWindow) {
         for (int section = 0; section < 5; ++section) {
           int initial_entries = rnd.Uniform(kWindowSize) + kWindowSize;
           for (int i = 0; i < initial_entries; ++i) {
-            collector->AddUserKey("hello", "rocksdb", kEntryPut, 0, 0);
+            ASSERT_OK(
+                collector->AddUserKey("hello", "rocksdb", kEntryPut, 0, 0));
           }
         }
         for (int i = 0; i < kPaddedWindowSize; ++i) {
           if (i % kSample < delete_rate) {
-            collector->AddUserKey("hello", "rocksdb", kEntryDelete, 0, 0);
+            ASSERT_OK(
+                collector->AddUserKey("hello", "rocksdb", kEntryDelete, 0, 0));
             deletions++;
           } else {
-            collector->AddUserKey("hello", "rocksdb", kEntryPut, 0, 0);
+            ASSERT_OK(
+                collector->AddUserKey("hello", "rocksdb", kEntryPut, 0, 0));
           }
         }
         for (int section = 0; section < 5; ++section) {
           int ending_entries = rnd.Uniform(kWindowSize) + kWindowSize;
           for (int i = 0; i < ending_entries; ++i) {
-            collector->AddUserKey("hello", "rocksdb", kEntryPut, 0, 0);
+            ASSERT_OK(
+                collector->AddUserKey("hello", "rocksdb", kEntryPut, 0, 0));
           }
         }
         if (collector->NeedCompact() != (deletions >= kNumDeletionTrigger) &&
             std::abs(deletions - kNumDeletionTrigger) > kBias) {
-          fprintf(stderr, "[Error] collector->NeedCompact() %d != (%d >= %d)"
+          fprintf(stderr,
+                  "[Error] collector->NeedCompact() %d != (%d >= %d)"
                   " with kWindowSize = %d, kNumDeletionTrigger = %d\n",
-                  collector->NeedCompact(),
-                  deletions, kNumDeletionTrigger, kWindowSize,
-                  kNumDeletionTrigger);
+                  collector->NeedCompact(), deletions, kNumDeletionTrigger,
+                  kWindowSize, kNumDeletionTrigger);
           ASSERT_TRUE(false);
         }
-        collector->Finish(nullptr);
+        ASSERT_OK(collector->Finish(nullptr));
       }
     }
 
@@ -199,20 +208,23 @@ TEST(CompactOnDeletionCollector, SlidingWindow) {
         for (int section = 0; section < 200; ++section) {
           for (int i = 0; i < kPaddedWindowSize; ++i) {
             if (i < kDeletionsPerSection) {
-              collector->AddUserKey("hello", "rocksdb", kEntryDelete, 0, 0);
+              ASSERT_OK(collector->AddUserKey("hello", "rocksdb", kEntryDelete,
+                                              0, 0));
             } else {
-              collector->AddUserKey("hello", "rocksdb", kEntryPut, 0, 0);
+              ASSERT_OK(
+                  collector->AddUserKey("hello", "rocksdb", kEntryPut, 0, 0));
             }
           }
         }
         if (collector->NeedCompact() &&
             std::abs(kDeletionsPerSection - kNumDeletionTrigger) > kBias) {
-          fprintf(stderr, "[Error] collector->NeedCompact() != false"
+          fprintf(stderr,
+                  "[Error] collector->NeedCompact() != false"
                   " with kWindowSize = %d and kNumDeletionTrigger = %d\n",
                   kWindowSize, kNumDeletionTrigger);
           ASSERT_TRUE(false);
         }
-        collector->Finish(nullptr);
+        ASSERT_OK(collector->Finish(nullptr));
       }
     }
   }