check if load is successfull in GeneralMailStatistics

[pmg-gui.git] / js / LDAPConfig.js

diff --git a/js/LDAPConfig.js b/js/LDAPConfig.js
index 27a94429d266c60d1067ba6f19641e23e07fcc98..71760df4e6b2c166ef721b1d0dce586a096e65b2 100644 (file)
--- a/js/LDAPConfig.js
+++ b/js/LDAPConfig.js
@@ -1,4 +1,11 @@
 /*global Proxmox*/
+/*jslint confusion: true*/
+/* reload is function and string,
+ * height is number and string,
+ * hidden is bool and string,
+ * bind is function and object,
+ * callback is function and string
+ */
 Ext.define('pmg-ldap-config', {
     extend: 'Ext.data.Model',
     fields: [ 'profile', 'server1', 'server2', 'comment',
@@ -65,7 +72,7 @@ Ext.define('PMG.LDAPInputPanel', {
                xtype: 'proxmoxtextfield',
                fieldLabel: gettext('Server'),
                allowBlank: true,
-               deleteEmpty: me.create ? false : true,
+               deleteEmpty: me.isCreate ? false : true,
                vtype: 'IP64Address',
                name: 'server2'
            },
@@ -73,7 +80,7 @@ Ext.define('PMG.LDAPInputPanel', {
                xtype: 'proxmoxintegerfield',
                name: 'port',
                emptyText: gettext('Default'),
-               deleteEmpty: me.create ? false : true,
+               deleteEmpty: me.isCreate ? false : true,
                minValue: 1,
                maxValue: 65535,
                fieldLabel: gettext('Port')
@@ -104,42 +111,42 @@ Ext.define('PMG.LDAPInputPanel', {
            {
                xtype: 'proxmoxtextfield',
                allowBlank: true,
-               deleteEmpty: me.create ? false : true,
+               deleteEmpty: me.isCreate ? false : true,
                name: 'basedn',
                fieldLabel: gettext('Base DN')
            },
            {
                xtype: 'proxmoxtextfield',
                allowBlank: true,
-               deleteEmpty: me.create ? false : true,
+               deleteEmpty: me.isCreate ? false : true,
                name: 'groupbasedn',
                fieldLabel: gettext('Base DN for Groups')
            },
            {
                xtype: 'proxmoxtextfield',
                allowBlank: true,
-               deleteEmpty: me.create ? false : true,
+               deleteEmpty: me.isCreate ? false : true,
                name: 'mailattr',
                fieldLabel: gettext('EMail attribute name(s)')
            },
            {
                xtype: 'proxmoxtextfield',
                allowBlank: true,
-               deleteEmpty: me.create ? false : true,
+               deleteEmpty: me.isCreate ? false : true,
                name: 'accountattr',
                fieldLabel: gettext('Account attribute name')
            },
            {
                xtype: 'proxmoxtextfield',
                allowBlank: true,
-               deleteEmpty: me.create ? false : true,
+               deleteEmpty: me.isCreate ? false : true,
                name: 'filter',
                fieldLabel: gettext('LDAP filter')
            },
            {
                xtype: 'proxmoxtextfield',
                allowBlank: true,
-               deleteEmpty: me.create ? false : true,
+               deleteEmpty: me.isCreate ? false : true,
                name: 'groupclass',
                fieldLabel: gettext('Group objectclass')
            }
@@ -168,9 +175,9 @@ Ext.define('PMG.LDAPEdit', {
     initComponent : function() {
        var me = this;
 
-       me.create = me.profileId ? false : true;
+       me.isCreate = me.profileId ? false : true;
 
-       if (me.create) {
+       if (me.isCreate) {
             me.url = '/api2/extjs/config/ldap';
             me.method = 'POST';
        } else {
@@ -179,7 +186,7 @@ Ext.define('PMG.LDAPEdit', {
        }
 
        var ipanel = Ext.create('PMG.LDAPInputPanel', {
-           create: me.create,
+           isCreate: me.isCreate,
            profileId: me.profileId
        });
 
@@ -191,7 +198,7 @@ Ext.define('PMG.LDAPEdit', {
 
        me.callParent();
 
-       if (!me.create) {
+       if (!me.isCreate) {
            me.load({
                success:  function(response, options) {
                    var values = response.result.data;
@@ -315,7 +322,6 @@ Ext.define('PMG.LDAPConfig', {
        showInfo: function(grid, selected) {
            var me = this;
            var viewModel = me.getViewModel();
-           var grid = me.lookup('data');
            if (selected[0]) {
                var name = selected[0].data.profile;
                viewModel.set('selected', true);
@@ -364,9 +370,7 @@ Ext.define('PMG.LDAPConfig', {
        }
     },
 
-    layout: {
-       type: 'border',
-    },
+    layout: 'border',
 
     items: [
        {
@@ -457,7 +461,7 @@ Ext.define('PMG.LDAPConfigGrid', {
            win.show();
        },
 
-       new: function() {
+       newProfile: function() {
            var me = this;
            var win = Ext.createWidget('pmgLDAPEdit', {});
            win.on('destroy', me.reload, me);
@@ -496,10 +500,10 @@ Ext.define('PMG.LDAPConfigGrid', {
 
     store: {
        model: 'pmg-ldap-config',
-       sorters: {
+       sorters: [{
            property: 'profile',
            order: 'DESC'
-       }
+       }]
     },
 
     tbar: [
@@ -511,7 +515,7 @@ Ext.define('PMG.LDAPConfigGrid', {
        },
        {
            text: gettext('Create'),
-           handler: 'new'
+           handler: 'newProfile'
        },
        {
            xtype: 'proxmoxStdRemoveButton',