quarantine: refactor spamquarantine controller

[pmg-gui.git] / js / SystemOptions.js

diff --git a/js/SystemOptions.js b/js/SystemOptions.js
index 4be49bd6a7e7c82aa612bc585d2971978d2ffb9e..675dde446f48b7c0d5b4df1bb8626f2f2738c8ec 100644 (file)
--- a/js/SystemOptions.js
+++ b/js/SystemOptions.js
@@ -1,4 +1,3 @@
-/*global Proxmox*/
 Ext.define('PMG.SystemOptions', {
     extend: 'Proxmox.grid.ObjectGrid',
     xtype: 'pmgSystemOptions',
@@ -9,31 +8,32 @@ Ext.define('PMG.SystemOptions', {
 
     url: '/api2/json/config/admin',
     editorConfig: {
-       url: '/api2/extjs/config/admin'
+       url: '/api2/extjs/config/admin',
+       onlineHelp: 'pmgconfig_systemconfig',
     },
 
     controller: {
        xclass: 'Ext.app.ViewController',
 
        onEdit: function() {
-           var me = this.getView();
-           me.run_editor();
-       }
+           let view = this.getView();
+           view.run_editor();
+       },
     },
 
     tbar: [{
        text: gettext('Edit'),
        xtype: 'proxmoxButton',
        disabled: true,
-       handler: 'onEdit'
+       handler: 'onEdit',
     }],
 
     listeners: {
-       itemdblclick: 'onEdit'
+       itemdblclick: 'onEdit',
     },
 
     add_proxy_row: function(name, text, opts) {
-       var me = this;
+       let me = this;
 
        opts = opts || {};
        me.rows = me.rows || {};
@@ -44,6 +44,7 @@ Ext.define('PMG.SystemOptions', {
            header: text,
            editor: {
                xtype: 'proxmoxWindowEdit',
+               onlineHelp: 'pmgconfig_systemconfig',
                subject: text,
                items: {
                    xtype: 'proxmoxtextfield',
@@ -53,20 +54,20 @@ Ext.define('PMG.SystemOptions', {
                    emptyText: Proxmox.Utils.noneText,
                    labelWidth: Proxmox.Utils.compute_min_label_width(
                        text, opts.labelWidth),
-                   fieldLabel: text
-               }
-           }
+                   fieldLabel: text,
+               },
+           },
        };
     },
 
-    initComponent : function() {
-       var me = this;
+    initComponent: function() {
+       let me = this;
 
-       me.add_boolean_row('dailyreport', gettext('Send daily reports'),
-                          { defaultValue: 1});
+       me.add_boolean_row('dailyreport', gettext('Send daily admin reports'),
+                          { defaultValue: 1 });
 
        me.add_boolean_row('advfilter', gettext('Use advanced statistic filters'),
-                          { defaultValue: 1});
+                          { defaultValue: 1 });
 
        me.add_integer_row('statlifetime', gettext('User statistic lifetime (days)'),
                           { minValue: 1, defaultValue: 7, deleteEmpty: true });
@@ -79,7 +80,7 @@ Ext.define('PMG.SystemOptions', {
        me.callParent();
 
        me.on('activate', me.rstore.startUpdate);
+       me.on('deactivate', me.rstore.stopUpdate);
        me.on('destroy', me.rstore.stopUpdate);
-    }
-})
-
+    },
+});