]> git.proxmox.com Git - qemu.git/blobdiff - slirp/tcp_input.c
rng-egd: remove redundant free
[qemu.git] / slirp / tcp_input.c
index 8789303c8b1dc4eeb4591e77aae1c9a39d904349..f946db8dc07eaed24fa0f9ffffdd12a88c32ce76 100644 (file)
 #include <slirp.h>
 #include "ip_icmp.h"
 
-struct socket tcb;
-
 #define        TCPREXMTTHRESH 3
-struct socket *tcp_last_so = &tcb;
-
-tcp_seq tcp_iss;                /* tcp initial send seq # */
 
 #define TCP_PAWS_IDLE  (24 * 24 * 60 * 60 * PR_SLOWHZ)
 
@@ -75,13 +70,10 @@ tcp_seq tcp_iss;                /* tcp initial send seq # */
                        tp->t_flags |= TF_DELACK; \
                (tp)->rcv_nxt += (ti)->ti_len; \
                flags = (ti)->ti_flags & TH_FIN; \
-               STAT(tcpstat.tcps_rcvpack++);         \
-               STAT(tcpstat.tcps_rcvbyte += (ti)->ti_len);   \
                if (so->so_emu) { \
                       if (tcp_emu((so),(m))) sbappend((so), (m)); \
               } else \
                       sbappend((so), (m)); \
-/*               sorwakeup(so); */ \
        } else {\
                (flags) = tcp_reass((tp), (ti), (m)); \
                tp->t_flags |= TF_ACKNOW; \
@@ -95,13 +87,10 @@ tcp_seq tcp_iss;                /* tcp initial send seq # */
                tp->t_flags |= TF_DELACK; \
                (tp)->rcv_nxt += (ti)->ti_len; \
                flags = (ti)->ti_flags & TH_FIN; \
-               STAT(tcpstat.tcps_rcvpack++);        \
-               STAT(tcpstat.tcps_rcvbyte += (ti)->ti_len);  \
                if (so->so_emu) { \
                        if (tcp_emu((so),(m))) sbappend(so, (m)); \
                } else \
                        sbappend((so), (m)); \
-/*             sorwakeup(so); */ \
        } else { \
                (flags) = tcp_reass((tp), (ti), (m)); \
                tp->t_flags |= TF_ACKNOW; \
@@ -147,9 +136,7 @@ tcp_reass(register struct tcpcb *tp, register struct tcpiphdr *ti,
                i = q->ti_seq + q->ti_len - ti->ti_seq;
                if (i > 0) {
                        if (i >= ti->ti_len) {
-                               STAT(tcpstat.tcps_rcvduppack++);
-                               STAT(tcpstat.tcps_rcvdupbyte += ti->ti_len);
-                               m_freem(m);
+                               m_free(m);
                                /*
                                 * Try to present any queued data
                                 * at the left window edge to the user.
@@ -164,8 +151,6 @@ tcp_reass(register struct tcpcb *tp, register struct tcpiphdr *ti,
                }
                q = tcpiphdr_next(q);
        }
-       STAT(tcpstat.tcps_rcvoopack++);
-       STAT(tcpstat.tcps_rcvoobyte += ti->ti_len);
        ti->ti_mbuf = m;
 
        /*
@@ -185,7 +170,7 @@ tcp_reass(register struct tcpcb *tp, register struct tcpiphdr *ti,
                q = tcpiphdr_next(q);
                m = tcpiphdr_prev(q)->ti_mbuf;
                remque(tcpiphdr2qlink(tcpiphdr_prev(q)));
-               m_freem(m);
+               m_free(m);
        }
 
        /*
@@ -211,9 +196,8 @@ present:
                remque(tcpiphdr2qlink(ti));
                m = ti->ti_mbuf;
                ti = tcpiphdr_next(ti);
-/*             if (so->so_state & SS_FCANTRCVMORE) */
                if (so->so_state & SS_FCANTSENDMORE)
-                       m_freem(m);
+                       m_free(m);
                else {
                        if (so->so_emu) {
                                if (tcp_emu(so,m)) sbappend(so, m);
@@ -221,7 +205,6 @@ present:
                                sbappend(so, m);
                }
        } while (ti != (struct tcpiphdr *)tp && ti->ti_seq == tp->rcv_nxt);
-/*     sorwakeup(so); */
        return (flags);
 }
 
@@ -241,15 +224,14 @@ tcp_input(struct mbuf *m, int iphlen, struct socket *inso)
        register int tiflags;
         struct socket *so = NULL;
        int todrop, acked, ourfinisacked, needoutput = 0;
-/*     int dropsocket = 0; */
        int iss = 0;
        u_long tiwin;
        int ret;
-/*     int ts_present = 0; */
     struct ex_list *ex_ptr;
+    Slirp *slirp;
 
        DEBUG_CALL("tcp_input");
-       DEBUG_ARGS((dfd," m = %8lx  iphlen = %2d  inso = %lx\n",
+       DEBUG_ARGS((dfd, " m = %8lx  iphlen = %2d  inso = %lx\n",
                    (long )m, iphlen, (long )inso ));
 
        /*
@@ -257,6 +239,7 @@ tcp_input(struct mbuf *m, int iphlen, struct socket *inso)
         */
        if (m == NULL) {
                so = inso;
+               slirp = so->slirp;
 
                /* Re-set a few variables */
                tp = sototcpcb(so);
@@ -268,9 +251,8 @@ tcp_input(struct mbuf *m, int iphlen, struct socket *inso)
 
                goto cont_conn;
        }
+       slirp = m->slirp;
 
-
-       STAT(tcpstat.tcps_rcvtotal++);
        /*
         * Get IP and TCP header together in first mbuf.
         * Note: IP leaves IP header in first mbuf.
@@ -298,13 +280,9 @@ tcp_input(struct mbuf *m, int iphlen, struct socket *inso)
         tcpiphdr2qlink(ti)->next = tcpiphdr2qlink(ti)->prev = NULL;
         memset(&ti->ti_i.ih_mbuf, 0 , sizeof(struct mbuf_ptr));
        ti->ti_x1 = 0;
-       ti->ti_len = htons((u_int16_t)tlen);
+       ti->ti_len = htons((uint16_t)tlen);
        len = sizeof(struct ip ) + tlen;
-       /* keep checksum for ICMP reply
-        * ti->ti_sum = cksum(m, len);
-        * if (ti->ti_sum) { */
        if(cksum(m, len)) {
-         STAT(tcpstat.tcps_rcvbadsum++);
          goto drop;
        }
 
@@ -314,7 +292,6 @@ tcp_input(struct mbuf *m, int iphlen, struct socket *inso)
         */
        off = ti->ti_off << 2;
        if (off < sizeof (struct tcphdr) || off > tlen) {
-         STAT(tcpstat.tcps_rcvbadoff++);
          goto drop;
        }
        tlen -= off;
@@ -322,25 +299,6 @@ tcp_input(struct mbuf *m, int iphlen, struct socket *inso)
        if (off > sizeof (struct tcphdr)) {
          optlen = off - sizeof (struct tcphdr);
          optp = mtod(m, caddr_t) + sizeof (struct tcpiphdr);
-
-               /*
-                * Do quick retrieval of timestamp options ("options
-                * prediction?").  If timestamp is the only option and it's
-                * formatted as recommended in RFC 1323 appendix A, we
-                * quickly get the values now and not bother calling
-                * tcp_dooptions(), etc.
-                */
-/*             if ((optlen == TCPOLEN_TSTAMP_APPA ||
- *                  (optlen > TCPOLEN_TSTAMP_APPA &&
- *                     optp[TCPOLEN_TSTAMP_APPA] == TCPOPT_EOL)) &&
- *                  *(u_int32_t *)optp == htonl(TCPOPT_TSTAMP_HDR) &&
- *                  (ti->ti_flags & TH_SYN) == 0) {
- *                     ts_present = 1;
- *                     ts_val = ntohl(*(u_int32_t *)(optp + 4));
- *                     ts_ecr = ntohl(*(u_int32_t *)(optp + 8));
- *                     optp = NULL;   / * we've parsed the options * /
- *             }
- */
        }
        tiflags = ti->ti_flags;
 
@@ -358,30 +316,19 @@ tcp_input(struct mbuf *m, int iphlen, struct socket *inso)
        m->m_data += sizeof(struct tcpiphdr)+off-sizeof(struct tcphdr);
        m->m_len  -= sizeof(struct tcpiphdr)+off-sizeof(struct tcphdr);
 
-    if (slirp_restrict) {
-        for (ex_ptr = exec_list; ex_ptr; ex_ptr = ex_ptr->ex_next) {
-            if (ex_ptr->ex_fport == ti->ti_dport &&
-                ti->ti_dst.s_addr == ex_ptr->ex_addr.s_addr) {
-                break;
-            }
-        }
-        if (!ex_ptr)
-            goto drop;
-    }
        /*
         * Locate pcb for segment.
         */
 findso:
-       so = tcp_last_so;
+       so = slirp->tcp_last_so;
        if (so->so_fport != ti->ti_dport ||
            so->so_lport != ti->ti_sport ||
            so->so_laddr.s_addr != ti->ti_src.s_addr ||
            so->so_faddr.s_addr != ti->ti_dst.s_addr) {
-               so = solookup(&tcb, ti->ti_src, ti->ti_sport,
+               so = solookup(&slirp->tcb, ti->ti_src, ti->ti_sport,
                               ti->ti_dst, ti->ti_dport);
                if (so)
-                       tcp_last_so = so;
-               STAT(tcpstat.tcps_socachemiss++);
+                       slirp->tcp_last_so = so;
        }
 
        /*
@@ -398,10 +345,26 @@ findso:
         * as if it was LISTENING, and continue...
         */
         if (so == NULL) {
+          if (slirp->restricted) {
+            /* Any hostfwds will have an existing socket, so we only get here
+             * for non-hostfwd connections. These should be dropped, unless it
+             * happens to be a guestfwd.
+             */
+            for (ex_ptr = slirp->exec_list; ex_ptr; ex_ptr = ex_ptr->ex_next) {
+                if (ex_ptr->ex_fport == ti->ti_dport &&
+                    ti->ti_dst.s_addr == ex_ptr->ex_addr.s_addr) {
+                    break;
+                }
+            }
+            if (!ex_ptr) {
+                goto dropwithreset;
+            }
+          }
+
          if ((tiflags & (TH_SYN|TH_FIN|TH_RST|TH_URG|TH_ACK)) != TH_SYN)
            goto dropwithreset;
 
-         if ((so = socreate()) == NULL)
+         if ((so = socreate(slirp)) == NULL)
            goto dropwithreset;
          if (tcp_attach(so) < 0) {
            free(so); /* Not sofree (if it failed, it's not insqued) */
@@ -411,9 +374,6 @@ findso:
          sbreserve(&so->so_snd, TCP_SNDSPACE);
          sbreserve(&so->so_rcv, TCP_RCVSPACE);
 
-         /*            tcp_last_so = so; */  /* XXX ? */
-         /*            tp = sototcpcb(so);    */
-
          so->so_laddr = ti->ti_src;
          so->so_lport = ti->ti_sport;
          so->so_faddr = ti->ti_dst;
@@ -442,12 +402,7 @@ findso:
        if (tp->t_state == TCPS_CLOSED)
                goto drop;
 
-       /* Unscale the window into a 32-bit value. */
-/*     if ((tiflags & TH_SYN) == 0)
- *             tiwin = ti->ti_win << tp->snd_scale;
- *     else
- */
-               tiwin = ti->ti_win;
+       tiwin = ti->ti_win;
 
        /*
         * Segment received on connection.
@@ -465,8 +420,6 @@ findso:
         */
        if (optp && tp->t_state != TCPS_LISTEN)
                tcp_dooptions(tp, (u_char *)optp, optlen, ti);
-/* , */
-/*                     &ts_present, &ts_val, &ts_ecr); */
 
        /*
         * Header prediction: check for the two common cases
@@ -488,20 +441,9 @@ findso:
         */
        if (tp->t_state == TCPS_ESTABLISHED &&
            (tiflags & (TH_SYN|TH_FIN|TH_RST|TH_URG|TH_ACK)) == TH_ACK &&
-/*         (!ts_present || TSTMP_GEQ(ts_val, tp->ts_recent)) && */
            ti->ti_seq == tp->rcv_nxt &&
            tiwin && tiwin == tp->snd_wnd &&
            tp->snd_nxt == tp->snd_max) {
-               /*
-                * If last ACK falls within this segment's sequence numbers,
-                *  record the timestamp.
-                */
-/*             if (ts_present && SEQ_LEQ(ti->ti_seq, tp->last_ack_sent) &&
- *                SEQ_LT(tp->last_ack_sent, ti->ti_seq + ti->ti_len)) {
- *                     tp->ts_recent_age = tcp_now;
- *                     tp->ts_recent = ts_val;
- *             }
- */
                if (ti->ti_len == 0) {
                        if (SEQ_GT(ti->ti_ack, tp->snd_una) &&
                            SEQ_LEQ(ti->ti_ack, tp->snd_max) &&
@@ -509,19 +451,13 @@ findso:
                                /*
                                 * this is a pure ack for outstanding data.
                                 */
-                               STAT(tcpstat.tcps_predack++);
-/*                             if (ts_present)
- *                                     tcp_xmit_timer(tp, tcp_now-ts_ecr+1);
- *                             else
- */                                 if (tp->t_rtt &&
-                                           SEQ_GT(ti->ti_ack, tp->t_rtseq))
+                               if (tp->t_rtt &&
+                                   SEQ_GT(ti->ti_ack, tp->t_rtseq))
                                        tcp_xmit_timer(tp, tp->t_rtt);
                                acked = ti->ti_ack - tp->snd_una;
-                               STAT(tcpstat.tcps_rcvackpack++);
-                               STAT(tcpstat.tcps_rcvackbyte += acked);
                                sbdrop(&so->so_snd, acked);
                                tp->snd_una = ti->ti_ack;
-                               m_freem(m);
+                               m_free(m);
 
                                /*
                                 * If all outstanding data are acked, stop
@@ -537,13 +473,6 @@ findso:
                                else if (tp->t_timer[TCPT_PERSIST] == 0)
                                        tp->t_timer[TCPT_REXMT] = tp->t_rxtcur;
 
-                               /*
-                                * There's room in so_snd, sowwakup will read()
-                                * from the socket if we can
-                                */
-/*                             if (so->so_snd.sb_flags & SB_NOTIFY)
- *                                     sowwakeup(so);
- */
                                /*
                                 * This is called because sowwakeup might have
                                 * put data into so_snd.  Since we don't so sowwakeup,
@@ -562,10 +491,7 @@ findso:
                         * with nothing on the reassembly queue and
                         * we have enough buffer space to take it.
                         */
-                       STAT(tcpstat.tcps_preddat++);
                        tp->rcv_nxt += ti->ti_len;
-                       STAT(tcpstat.tcps_rcvpack++);
-                       STAT(tcpstat.tcps_rcvbyte += ti->ti_len);
                        /*
                         * Add data to socket buffer.
                         */
@@ -574,13 +500,6 @@ findso:
                        } else
                                sbappend(so, m);
 
-                       /*
-                        * XXX This is called when data arrives.  Later, check
-                        * if we can actually write() to the socket
-                        * XXX Need to check? It's be NON_BLOCKING
-                        */
-/*                     sorwakeup(so); */
-
                        /*
                         * If this is a short packet, then ACK now - with Nagel
                         *      congestion avoidance sender won't send more until
@@ -640,27 +559,22 @@ findso:
           * If this is destined for the control address, then flag to
           * tcp_ctl once connected, otherwise connect
           */
-         if ((so->so_faddr.s_addr & vnetwork_mask.s_addr) ==
-             vnetwork_addr.s_addr) {
-           if (so->so_faddr.s_addr != vhost_addr.s_addr &&
-               so->so_faddr.s_addr != vnameserver_addr.s_addr) {
-#if 0
-             if(lastbyte==CTL_CMD || lastbyte==CTL_EXEC) {
-               /* Command or exec adress */
-               so->so_state |= SS_CTL;
-             } else
-#endif
-              {
+         if ((so->so_faddr.s_addr & slirp->vnetwork_mask.s_addr) ==
+             slirp->vnetwork_addr.s_addr) {
+           if (so->so_faddr.s_addr != slirp->vhost_addr.s_addr &&
+               so->so_faddr.s_addr != slirp->vnameserver_addr.s_addr) {
                /* May be an add exec */
-               for(ex_ptr = exec_list; ex_ptr; ex_ptr = ex_ptr->ex_next) {
+               for (ex_ptr = slirp->exec_list; ex_ptr;
+                    ex_ptr = ex_ptr->ex_next) {
                  if(ex_ptr->ex_fport == so->so_fport &&
                     so->so_faddr.s_addr == ex_ptr->ex_addr.s_addr) {
                    so->so_state |= SS_CTL;
                    break;
                  }
                }
-             }
-             if(so->so_state & SS_CTL) goto cont_input;
+               if (so->so_state & SS_CTL) {
+                   goto cont_input;
+               }
            }
            /* CTL_ALIAS: Do nothing, tcp_fconnect will be called on it */
          }
@@ -672,7 +586,7 @@ findso:
 
          if((tcp_fconnect(so) == -1) && (errno != EINPROGRESS) && (errno != EWOULDBLOCK)) {
            u_char code=ICMP_UNREACH_NET;
-           DEBUG_MISC((dfd," tcp fconnect errno = %d-%s\n",
+           DEBUG_MISC((dfd, " tcp fconnect errno = %d-%s\n",
                        errno,strerror(errno)));
            if(errno == ECONNREFUSED) {
              /* ACK the SYN, send RST to refuse the connection */
@@ -689,7 +603,7 @@ findso:
              *ip=save_ip;
              icmp_error(m, ICMP_UNREACH,code, 0,strerror(errno));
            }
-           tp = tcp_close(tp);
+            tcp_close(tp);
            m_free(m);
          } else {
            /*
@@ -702,6 +616,7 @@ findso:
            so->so_ti = ti;
            tp->t_timer[TCPT_KEEP] = TCPTV_KEEP_INIT;
            tp->t_state = TCPS_SYN_RECEIVED;
+           tcp_template(tp);
          }
          return;
 
@@ -718,21 +633,18 @@ findso:
 
          if (optp)
            tcp_dooptions(tp, (u_char *)optp, optlen, ti);
-         /* , */
-         /*                            &ts_present, &ts_val, &ts_ecr); */
 
          if (iss)
            tp->iss = iss;
          else
-           tp->iss = tcp_iss;
-         tcp_iss += TCP_ISSINCR/2;
+           tp->iss = slirp->tcp_iss;
+         slirp->tcp_iss += TCP_ISSINCR/2;
          tp->irs = ti->ti_seq;
          tcp_sendseqinit(tp);
          tcp_rcvseqinit(tp);
          tp->t_flags |= TF_ACKNOW;
          tp->t_state = TCPS_SYN_RECEIVED;
          tp->t_timer[TCPT_KEEP] = TCPTV_KEEP_INIT;
-         STAT(tcpstat.tcps_accepts++);
          goto trimthenstep6;
        } /* case TCPS_LISTEN */
 
@@ -755,8 +667,9 @@ findso:
                        goto dropwithreset;
 
                if (tiflags & TH_RST) {
-                       if (tiflags & TH_ACK)
-                               tp = tcp_drop(tp,0); /* XXX Check t_softerror! */
+                        if (tiflags & TH_ACK) {
+                                tcp_drop(tp, 0); /* XXX Check t_softerror! */
+                        }
                        goto drop;
                }
 
@@ -773,17 +686,9 @@ findso:
                tcp_rcvseqinit(tp);
                tp->t_flags |= TF_ACKNOW;
                if (tiflags & TH_ACK && SEQ_GT(tp->snd_una, tp->iss)) {
-                       STAT(tcpstat.tcps_connects++);
                        soisfconnected(so);
                        tp->t_state = TCPS_ESTABLISHED;
 
-                       /* Do window scaling on this connection? */
-/*                     if ((tp->t_flags & (TF_RCVD_SCALE|TF_REQ_SCALE)) ==
- *                             (TF_RCVD_SCALE|TF_REQ_SCALE)) {
- *                             tp->snd_scale = tp->requested_s_scale;
- *                             tp->rcv_scale = tp->request_r_scale;
- *                     }
- */
                        (void) tcp_reass(tp, (struct tcpiphdr *)0,
                                (struct mbuf *)0);
                        /*
@@ -807,8 +712,6 @@ trimthenstep6:
                        m_adj(m, -todrop);
                        ti->ti_len = tp->rcv_wnd;
                        tiflags &= ~TH_FIN;
-                       STAT(tcpstat.tcps_rcvpackafterwin++);
-                       STAT(tcpstat.tcps_rcvbyteafterwin += todrop);
                }
                tp->snd_wl1 = ti->ti_seq - 1;
                tp->rcv_up = ti->ti_seq;
@@ -816,40 +719,10 @@ trimthenstep6:
        } /* switch tp->t_state */
        /*
         * States other than LISTEN or SYN_SENT.
-        * First check timestamp, if present.
-        * Then check that at least some bytes of segment are within
+        * Check that at least some bytes of segment are within
         * receive window.  If segment begins before rcv_nxt,
         * drop leading data (and SYN); if nothing left, just ack.
-        *
-        * RFC 1323 PAWS: If we have a timestamp reply on this segment
-        * and it's less than ts_recent, drop it.
         */
-/*     if (ts_present && (tiflags & TH_RST) == 0 && tp->ts_recent &&
- *         TSTMP_LT(ts_val, tp->ts_recent)) {
- *
- */            /* Check to see if ts_recent is over 24 days old.  */
-/*             if ((int)(tcp_now - tp->ts_recent_age) > TCP_PAWS_IDLE) {
- */                    /*
- *                      * Invalidate ts_recent.  If this segment updates
- *                      * ts_recent, the age will be reset later and ts_recent
- *                      * will get a valid value.  If it does not, setting
- *                      * ts_recent to zero will at least satisfy the
- *                      * requirement that zero be placed in the timestamp
- *                      * echo reply when ts_recent isn't valid.  The
- *                      * age isn't reset until we get a valid ts_recent
- *                      * because we don't want out-of-order segments to be
- *                      * dropped when ts_recent is old.
- *                      */
-/*                     tp->ts_recent = 0;
- *             } else {
- *                     tcpstat.tcps_rcvduppack++;
- *                     tcpstat.tcps_rcvdupbyte += ti->ti_len;
- *                     tcpstat.tcps_pawsdrop++;
- *                     goto dropafterack;
- *             }
- *     }
- */
-
        todrop = tp->rcv_nxt - ti->ti_seq;
        if (todrop > 0) {
                if (tiflags & TH_SYN) {
@@ -879,11 +752,6 @@ trimthenstep6:
                         */
                        tp->t_flags |= TF_ACKNOW;
                        todrop = ti->ti_len;
-                       STAT(tcpstat.tcps_rcvduppack++);
-                       STAT(tcpstat.tcps_rcvdupbyte += todrop);
-               } else {
-                       STAT(tcpstat.tcps_rcvpartduppack++);
-                       STAT(tcpstat.tcps_rcvpartdupbyte += todrop);
                }
                m_adj(m, todrop);
                ti->ti_seq += todrop;
@@ -902,7 +770,6 @@ trimthenstep6:
        if ((so->so_state & SS_NOFDREF) &&
            tp->t_state > TCPS_CLOSE_WAIT && ti->ti_len) {
                tp = tcp_close(tp);
-               STAT(tcpstat.tcps_rcvafterclose++);
                goto dropwithreset;
        }
 
@@ -912,9 +779,7 @@ trimthenstep6:
         */
        todrop = (ti->ti_seq+ti->ti_len) - (tp->rcv_nxt+tp->rcv_wnd);
        if (todrop > 0) {
-               STAT(tcpstat.tcps_rcvpackafterwin++);
                if (todrop >= ti->ti_len) {
-                       STAT(tcpstat.tcps_rcvbyteafterwin += ti->ti_len);
                        /*
                         * If a new connection request is received
                         * while in TIME_WAIT, drop the old connection
@@ -937,28 +802,15 @@ trimthenstep6:
                         */
                        if (tp->rcv_wnd == 0 && ti->ti_seq == tp->rcv_nxt) {
                                tp->t_flags |= TF_ACKNOW;
-                               STAT(tcpstat.tcps_rcvwinprobe++);
-                       } else
+                       } else {
                                goto dropafterack;
-               } else
-                       STAT(tcpstat.tcps_rcvbyteafterwin += todrop);
+                       }
+               }
                m_adj(m, -todrop);
                ti->ti_len -= todrop;
                tiflags &= ~(TH_PUSH|TH_FIN);
        }
 
-       /*
-        * If last ACK falls within this segment's sequence numbers,
-        * record its timestamp.
-        */
-/*     if (ts_present && SEQ_LEQ(ti->ti_seq, tp->last_ack_sent) &&
- *         SEQ_LT(tp->last_ack_sent, ti->ti_seq + ti->ti_len +
- *                ((tiflags & (TH_SYN|TH_FIN)) != 0))) {
- *             tp->ts_recent_age = tcp_now;
- *             tp->ts_recent = ts_val;
- *     }
- */
-
        /*
         * If the RST bit is set examine the state:
         *    SYN_RECEIVED STATE:
@@ -972,24 +824,18 @@ trimthenstep6:
        if (tiflags&TH_RST) switch (tp->t_state) {
 
        case TCPS_SYN_RECEIVED:
-/*             so->so_error = ECONNREFUSED; */
-               goto close;
-
        case TCPS_ESTABLISHED:
        case TCPS_FIN_WAIT_1:
        case TCPS_FIN_WAIT_2:
        case TCPS_CLOSE_WAIT:
-/*             so->so_error = ECONNRESET; */
-       close:
                tp->t_state = TCPS_CLOSED;
-               STAT(tcpstat.tcps_drops++);
-               tp = tcp_close(tp);
+                tcp_close(tp);
                goto drop;
 
        case TCPS_CLOSING:
        case TCPS_LAST_ACK:
        case TCPS_TIME_WAIT:
-               tp = tcp_close(tp);
+                tcp_close(tp);
                goto drop;
        }
 
@@ -1021,7 +867,6 @@ trimthenstep6:
                if (SEQ_GT(tp->snd_una, ti->ti_ack) ||
                    SEQ_GT(ti->ti_ack, tp->snd_max))
                        goto dropwithreset;
-               STAT(tcpstat.tcps_connects++);
                tp->t_state = TCPS_ESTABLISHED;
                /*
                 * The sent SYN is ack'ed with our sequence number +1
@@ -1048,13 +893,6 @@ trimthenstep6:
                  soisfconnected(so);
                }
 
-               /* Do window scaling? */
-/*             if ((tp->t_flags & (TF_RCVD_SCALE|TF_REQ_SCALE)) ==
- *                     (TF_RCVD_SCALE|TF_REQ_SCALE)) {
- *                     tp->snd_scale = tp->requested_s_scale;
- *                     tp->rcv_scale = tp->request_r_scale;
- *             }
- */
                (void) tcp_reass(tp, (struct tcpiphdr *)0, (struct mbuf *)0);
                tp->snd_wl1 = ti->ti_seq - 1;
                /* Avoid ack processing; snd_una==ti_ack  =>  dup ack */
@@ -1079,8 +917,7 @@ trimthenstep6:
 
                if (SEQ_LEQ(ti->ti_ack, tp->snd_una)) {
                        if (ti->ti_len == 0 && tiwin == tp->snd_wnd) {
-                         STAT(tcpstat.tcps_rcvdupack++);
-                         DEBUG_MISC((dfd," dup ack  m = %lx  so = %lx \n",
+                         DEBUG_MISC((dfd, " dup ack  m = %lx  so = %lx\n",
                                      (long )m, (long )so));
                                /*
                                 * If we have outstanding data (other than
@@ -1147,27 +984,18 @@ trimthenstep6:
                        tp->snd_cwnd = tp->snd_ssthresh;
                tp->t_dupacks = 0;
                if (SEQ_GT(ti->ti_ack, tp->snd_max)) {
-                       STAT(tcpstat.tcps_rcvacktoomuch++);
                        goto dropafterack;
                }
                acked = ti->ti_ack - tp->snd_una;
-               STAT(tcpstat.tcps_rcvackpack++);
-               STAT(tcpstat.tcps_rcvackbyte += acked);
 
                /*
-                * If we have a timestamp reply, update smoothed
-                * round trip time.  If no timestamp is present but
-                * transmit timer is running and timed sequence
+                * If transmit timer is running and timed sequence
                 * number was acked, update smoothed round trip time.
                 * Since we now have an rtt measurement, cancel the
                 * timer backoff (cf., Phil Karn's retransmit alg.).
                 * Recompute the initial retransmit timer.
                 */
-/*             if (ts_present)
- *                     tcp_xmit_timer(tp, tcp_now-ts_ecr+1);
- *             else
- */
-                    if (tp->t_rtt && SEQ_GT(ti->ti_ack, tp->t_rtseq))
+               if (tp->t_rtt && SEQ_GT(ti->ti_ack, tp->t_rtseq))
                        tcp_xmit_timer(tp,tp->t_rtt);
 
                /*
@@ -1205,13 +1033,6 @@ trimthenstep6:
                        tp->snd_wnd -= acked;
                        ourfinisacked = 0;
                }
-               /*
-                * XXX sowwakup is called when data is acked and there's room for
-                * for more data... it should read() the socket
-                */
-/*             if (so->so_snd.sb_flags & SB_NOTIFY)
- *                     sowwakeup(so);
- */
                tp->snd_una = ti->ti_ack;
                if (SEQ_LT(tp->snd_nxt, tp->snd_una))
                        tp->snd_nxt = tp->snd_una;
@@ -1233,7 +1054,6 @@ trimthenstep6:
                                 * we'll hang forever.
                                 */
                                if (so->so_state & SS_FCANTRCVMORE) {
-                                       soisfdisconnected(so);
                                        tp->t_timer[TCPT_2MSL] = TCP_MAXIDLE;
                                }
                                tp->t_state = TCPS_FIN_WAIT_2;
@@ -1251,7 +1071,6 @@ trimthenstep6:
                                tp->t_state = TCPS_TIME_WAIT;
                                tcp_canceltimers(tp);
                                tp->t_timer[TCPT_2MSL] = 2 * TCPTV_MSL;
-                               soisfdisconnected(so);
                        }
                        break;
 
@@ -1263,7 +1082,7 @@ trimthenstep6:
                 */
                case TCPS_LAST_ACK:
                        if (ourfinisacked) {
-                               tp = tcp_close(tp);
+                                tcp_close(tp);
                                goto drop;
                        }
                        break;
@@ -1288,10 +1107,6 @@ step6:
            (SEQ_LT(tp->snd_wl1, ti->ti_seq) ||
            (tp->snd_wl1 == ti->ti_seq && (SEQ_LT(tp->snd_wl2, ti->ti_ack) ||
            (tp->snd_wl2 == ti->ti_ack && tiwin > tp->snd_wnd))))) {
-               /* keep track of pure window updates */
-               if (ti->ti_len == 0 &&
-                   tp->snd_wl2 == ti->ti_ack && tiwin > tp->snd_wnd)
-                       STAT(tcpstat.tcps_rcvwinupd++);
                tp->snd_wnd = tiwin;
                tp->snd_wl1 = ti->ti_seq;
                tp->snd_wl2 = ti->ti_ack;
@@ -1347,6 +1162,16 @@ step6:
                        tp->rcv_up = tp->rcv_nxt;
 dodata:
 
+       /*
+        * If this is a small packet, then ACK now - with Nagel
+        *      congestion avoidance sender won't send more until
+        *      he gets an ACK.
+        */
+       if (ti->ti_len && (unsigned)ti->ti_len <= 5 &&
+           ((struct tcpiphdr_2 *)ti)->first_char == (char)27) {
+               tp->t_flags |= TF_ACKNOW;
+       }
+
        /*
         * Process the segment text, merging it into the TCP sequencing queue,
         * and arranging for acknowledgment of receipt if necessary.
@@ -1358,12 +1183,6 @@ dodata:
        if ((ti->ti_len || (tiflags&TH_FIN)) &&
            TCPS_HAVERCVDFIN(tp->t_state) == 0) {
                TCP_REASS(tp, ti, m, so, tiflags);
-               /*
-                * Note the amount of data that peer has sent into
-                * our window, in order to estimate the sender's
-                * buffer size.
-                */
-               len = so->so_rcv.sb_datalen - (tp->rcv_adv - tp->rcv_nxt);
        } else {
                m_free(m);
                tiflags &= ~TH_FIN;
@@ -1384,7 +1203,6 @@ dodata:
                         * will got to TCPS_LAST_ACK, and use tcp_output()
                         * to send the FIN.
                         */
-/*                     sofcantrcvmore(so); */
                        sofwdrain(so);
 
                        tp->t_flags |= TF_ACKNOW;
@@ -1421,7 +1239,6 @@ dodata:
                        tp->t_state = TCPS_TIME_WAIT;
                        tcp_canceltimers(tp);
                        tp->t_timer[TCPT_2MSL] = 2 * TCPTV_MSL;
-                       soisfdisconnected(so);
                        break;
 
                /*
@@ -1433,25 +1250,6 @@ dodata:
                }
        }
 
-       /*
-        * If this is a small packet, then ACK now - with Nagel
-        *      congestion avoidance sender won't send more until
-        *      he gets an ACK.
-        *
-        * See above.
-        */
-/*     if (ti->ti_len && (unsigned)ti->ti_len < tp->t_maxseg) {
- */
-/*     if ((ti->ti_len && (unsigned)ti->ti_len < tp->t_maxseg &&
- *             (so->so_iptos & IPTOS_LOWDELAY) == 0) ||
- *            ((so->so_iptos & IPTOS_LOWDELAY) &&
- *            ((struct tcpiphdr_2 *)ti)->first_char == (char)27)) {
- */
-       if (ti->ti_len && (unsigned)ti->ti_len <= 5 &&
-           ((struct tcpiphdr_2 *)ti)->first_char == (char)27) {
-               tp->t_flags |= TF_ACKNOW;
-       }
-
        /*
         * Return any desired output.
         */
@@ -1467,7 +1265,7 @@ dropafterack:
         */
        if (tiflags & TH_RST)
                goto drop;
-       m_freem(m);
+       m_free(m);
        tp->t_flags |= TF_ACKNOW;
        (void) tcp_output(tp);
        return;
@@ -1489,22 +1287,16 @@ drop:
         * Drop space held by incoming segment and return.
         */
        m_free(m);
-
-       return;
 }
 
- /* , ts_present, ts_val, ts_ecr) */
-/*     int *ts_present;
- *     u_int32_t *ts_val, *ts_ecr;
- */
 static void
 tcp_dooptions(struct tcpcb *tp, u_char *cp, int cnt, struct tcpiphdr *ti)
 {
-       u_int16_t mss;
+       uint16_t mss;
        int opt, optlen;
 
        DEBUG_CALL("tcp_dooptions");
-       DEBUG_ARGS((dfd," tp = %lx  cnt=%i \n", (long )tp, cnt));
+       DEBUG_ARGS((dfd, " tp = %lx  cnt=%i\n", (long)tp, cnt));
 
        for (; cnt > 0; cnt -= optlen, cp += optlen) {
                opt = cp[0];
@@ -1531,35 +1323,6 @@ tcp_dooptions(struct tcpcb *tp, u_char *cp, int cnt, struct tcpiphdr *ti)
                        NTOHS(mss);
                        (void) tcp_mss(tp, mss);        /* sets t_maxseg */
                        break;
-
-/*             case TCPOPT_WINDOW:
- *                     if (optlen != TCPOLEN_WINDOW)
- *                             continue;
- *                     if (!(ti->ti_flags & TH_SYN))
- *                             continue;
- *                     tp->t_flags |= TF_RCVD_SCALE;
- *                     tp->requested_s_scale = min(cp[2], TCP_MAX_WINSHIFT);
- *                     break;
- */
-/*             case TCPOPT_TIMESTAMP:
- *                     if (optlen != TCPOLEN_TIMESTAMP)
- *                             continue;
- *                     *ts_present = 1;
- *                     memcpy((char *) ts_val, (char *)cp + 2, sizeof(*ts_val));
- *                     NTOHL(*ts_val);
- *                     memcpy((char *) ts_ecr, (char *)cp + 6, sizeof(*ts_ecr));
- *                     NTOHL(*ts_ecr);
- *
- */                    /*
- *                      * A timestamp received in a SYN makes
- *                      * it ok to send timestamp requests and replies.
- *                      */
-/*                     if (ti->ti_flags & TH_SYN) {
- *                             tp->t_flags |= TF_RCVD_TSTMP;
- *                             tp->ts_recent = *ts_val;
- *                             tp->ts_recent_age = tcp_now;
- *                     }
- */                    break;
                }
        }
 }
@@ -1617,7 +1380,6 @@ tcp_xmit_timer(register struct tcpcb *tp, int rtt)
        DEBUG_ARG("tp = %lx", (long)tp);
        DEBUG_ARG("rtt = %d", rtt);
 
-       STAT(tcpstat.tcps_rttupdated++);
        if (tp->t_srtt != 0) {
                /*
                 * srtt is stored as fixed point with 3 bits after the