]> git.proxmox.com Git - mirror_novnc.git/blobdiff - tests/test.helper.js
Use standard DOM identifiers for physical keys
[mirror_novnc.git] / tests / test.helper.js
index 0c68b16728fab08dd3231d831199416adc54d516..3d0afb55f969dcb2552d413102ba5e3851e1d0d3 100644 (file)
-// requires local modules: input/keysym, input/keysymdef, input/util
-
-var assert = chai.assert;
+var assert = chai.assert;
 var expect = chai.expect;
 
+import keysyms from '../core/input/keysymdef.js';
+import * as KeyboardUtil from "../core/input/util.js";
+
 describe('Helpers', function() {
     "use strict";
-    describe('keysymFromKeyCode', function() {
-        it('should map known keycodes to keysyms', function() {
-            expect(KeyboardUtil.keysymFromKeyCode(0x41, false), 'a').to.be.equal(0x61);
-            expect(KeyboardUtil.keysymFromKeyCode(0x41, true), 'A').to.be.equal(0x41);
-            expect(KeyboardUtil.keysymFromKeyCode(0xd, false), 'enter').to.be.equal(0xFF0D);
-            expect(KeyboardUtil.keysymFromKeyCode(0x11, false), 'ctrl').to.be.equal(0xFFE3);
-            expect(KeyboardUtil.keysymFromKeyCode(0x12, false), 'alt').to.be.equal(0xFFE9);
-            expect(KeyboardUtil.keysymFromKeyCode(0xe1, false), 'altgr').to.be.equal(0xFE03);
-            expect(KeyboardUtil.keysymFromKeyCode(0x1b, false), 'esc').to.be.equal(0xFF1B);
-            expect(KeyboardUtil.keysymFromKeyCode(0x26, false), 'up').to.be.equal(0xFF52);
-        });
-        it('should return null for unknown keycodes', function() {
-            expect(KeyboardUtil.keysymFromKeyCode(0xc0, false), 'DK æ').to.be.null;
-            expect(KeyboardUtil.keysymFromKeyCode(0xde, false), 'DK ø').to.be.null;
-        });
-    });
 
-    describe('keysyms.fromUnicode', function() {
+    describe('keysyms.lookup', function() {
         it('should map ASCII characters to keysyms', function() {
-            expect(keysyms.fromUnicode('a'.charCodeAt())).to.have.property('keysym', 0x61);
-            expect(keysyms.fromUnicode('A'.charCodeAt())).to.have.property('keysym', 0x41);
+            expect(keysyms.lookup('a'.charCodeAt())).to.be.equal(0x61);
+            expect(keysyms.lookup('A'.charCodeAt())).to.be.equal(0x41);
             });
         it('should map Latin-1 characters to keysyms', function() {
-            expect(keysyms.fromUnicode('ø'.charCodeAt())).to.have.property('keysym', 0xf8);
+            expect(keysyms.lookup('ø'.charCodeAt())).to.be.equal(0xf8);
 
-            expect(keysyms.fromUnicode('é'.charCodeAt())).to.have.property('keysym', 0xe9);
+            expect(keysyms.lookup('é'.charCodeAt())).to.be.equal(0xe9);
         });
         it('should map characters that are in Windows-1252 but not in Latin-1 to keysyms', function() {
-            expect(keysyms.fromUnicode('Š'.charCodeAt())).to.have.property('keysym', 0x01a9);
+            expect(keysyms.lookup('Š'.charCodeAt())).to.be.equal(0x01a9);
         });
         it('should map characters which aren\'t in Latin1 *or* Windows-1252 to keysyms', function() {
-            expect(keysyms.fromUnicode('ŵ'.charCodeAt())).to.have.property('keysym', 0x1000175);
+            expect(keysyms.lookup('ũ'.charCodeAt())).to.be.equal(0x03fd);
         });
         it('should map unknown codepoints to the Unicode range', function() {
-            expect(keysyms.fromUnicode('\n'.charCodeAt())).to.have.property('keysym', 0x100000a);
-            expect(keysyms.fromUnicode('\u{1F686}'.charCodeAt())).to.have.property('keysym', 0x101f686);
+            expect(keysyms.lookup('\n'.charCodeAt())).to.be.equal(0x100000a);
+            expect(keysyms.lookup('\u262D'.charCodeAt())).to.be.equal(0x100262d);
+        });
+        // This requires very recent versions of most browsers... skipping for now
+        it.skip('should map UCS-4 codepoints to the Unicode range', function() {
+            //expect(keysyms.lookup('\u{1F686}'.codePointAt())).to.be.equal(0x101f686);
         });
     });
 
-    describe('substituteCodepoint', function() {
-        it('should replace characters which don\'t have a keysym', function() {
-            expect(KeyboardUtil.substituteCodepoint('Ș'.charCodeAt())).to.equal('Ş'.charCodeAt());
-            expect(KeyboardUtil.substituteCodepoint('ș'.charCodeAt())).to.equal('ş'.charCodeAt());
-            expect(KeyboardUtil.substituteCodepoint('Ț'.charCodeAt())).to.equal('Ţ'.charCodeAt());
-            expect(KeyboardUtil.substituteCodepoint('ț'.charCodeAt())).to.equal('ţ'.charCodeAt());
+    describe('getKeycode', function() {
+        it('should pass through proper code', function() {
+            expect(KeyboardUtil.getKeycode({code: 'Semicolon'})).to.be.equal('Semicolon');
         });
-        it('should pass other characters through unchanged', function() {
-            expect(KeyboardUtil.substituteCodepoint('T'.charCodeAt())).to.equal('T'.charCodeAt());
+        it('should map legacy values', function() {
+            expect(KeyboardUtil.getKeycode({code: ''})).to.be.equal('Unidentified');
+            expect(KeyboardUtil.getKeycode({code: 'OSLeft'})).to.be.equal('MetaLeft');
         });
-    });
-
-    describe('nonCharacterKey', function() {
-        it('should  recognize the right keys', function() {
-            expect(KeyboardUtil.nonCharacterKey({keyCode: 0xd}), 'enter').to.be.defined;
-            expect(KeyboardUtil.nonCharacterKey({keyCode: 0x08}), 'backspace').to.be.defined;
-            expect(KeyboardUtil.nonCharacterKey({keyCode: 0x09}), 'tab').to.be.defined;
-            expect(KeyboardUtil.nonCharacterKey({keyCode: 0x10}), 'shift').to.be.defined;
-            expect(KeyboardUtil.nonCharacterKey({keyCode: 0x11}), 'ctrl').to.be.defined;
-            expect(KeyboardUtil.nonCharacterKey({keyCode: 0x12}), 'alt').to.be.defined;
-            expect(KeyboardUtil.nonCharacterKey({keyCode: 0xe0}), 'meta').to.be.defined;
+        it('should map keyCode to code when possible', function() {
+            expect(KeyboardUtil.getKeycode({keyCode: 0x14})).to.be.equal('CapsLock');
+            expect(KeyboardUtil.getKeycode({keyCode: 0x5b})).to.be.equal('MetaLeft');
+            expect(KeyboardUtil.getKeycode({keyCode: 0x35})).to.be.equal('Digit5');
+            expect(KeyboardUtil.getKeycode({keyCode: 0x65})).to.be.equal('Numpad5');
+        });
+        it('should map keyCode left/right side', function() {
+            expect(KeyboardUtil.getKeycode({keyCode: 0x10, location: 1})).to.be.equal('ShiftLeft');
+            expect(KeyboardUtil.getKeycode({keyCode: 0x10, location: 2})).to.be.equal('ShiftRight');
+            expect(KeyboardUtil.getKeycode({keyCode: 0x11, location: 1})).to.be.equal('ControlLeft');
+            expect(KeyboardUtil.getKeycode({keyCode: 0x11, location: 2})).to.be.equal('ControlRight');
+        });
+        it('should map keyCode on numpad', function() {
+            expect(KeyboardUtil.getKeycode({keyCode: 0x0d, location: 0})).to.be.equal('Enter');
+            expect(KeyboardUtil.getKeycode({keyCode: 0x0d, location: 3})).to.be.equal('NumpadEnter');
+            expect(KeyboardUtil.getKeycode({keyCode: 0x23, location: 0})).to.be.equal('End');
+            expect(KeyboardUtil.getKeycode({keyCode: 0x23, location: 3})).to.be.equal('Numpad1');
         });
-        it('should  not recognize character keys', function() {
-            expect(KeyboardUtil.nonCharacterKey({keyCode: 'A'}), 'A').to.be.null;
-            expect(KeyboardUtil.nonCharacterKey({keyCode: '1'}), '1').to.be.null;
-            expect(KeyboardUtil.nonCharacterKey({keyCode: '.'}), '.').to.be.null;
-            expect(KeyboardUtil.nonCharacterKey({keyCode: ' '}), 'space').to.be.null;
+        it('should return Unidentified when it cannot map the keyCode', function() {
+            expect(KeyboardUtil.getKeycode({keycode: 0x42})).to.be.equal('Unidentified');
+        });
+
+        describe('Fix Meta on macOS', function() {
+            var origNavigator;
+            beforeEach(function () {
+                // window.navigator is a protected read-only property in many
+                // environments, so we need to redefine it whilst running these
+                // tests.
+                origNavigator = Object.getOwnPropertyDescriptor(window, "navigator");
+                if (origNavigator === undefined) {
+                    // Object.getOwnPropertyDescriptor() doesn't work
+                    // properly in any version of IE
+                    this.skip();
+                }
+
+                Object.defineProperty(window, "navigator", {value: {}});
+                if (window.navigator.platform !== undefined) {
+                    // Object.defineProperty() doesn't work properly in old
+                    // versions of Chrome
+                    this.skip();
+                }
+
+                window.navigator.platform = "Mac x86_64";
+            });
+            afterEach(function () {
+                Object.defineProperty(window, "navigator", origNavigator);
+            });
+
+            it('should respect ContextMenu on modern browser', function() {
+                expect(KeyboardUtil.getKeycode({code: 'ContextMenu', keyCode: 0x5d})).to.be.equal('ContextMenu');
+            });
+            it('should translate legacy ContextMenu to MetaRight', function() {
+                expect(KeyboardUtil.getKeycode({keyCode: 0x5d})).to.be.equal('MetaRight');
+            });
         });
     });
 
     describe('getKeysym', function() {
         it('should prefer char', function() {
-            expect(KeyboardUtil.getKeysym({char : 'a', charCode: 'Š'.charCodeAt(), keyCode: 0x42, which: 0x43})).to.have.property('keysym', 0x61);
+            expect(KeyboardUtil.getKeysym({char : 'a', charCode: 'Š'.charCodeAt(), keyCode: 0x42, which: 0x43})).to.be.equal(0x61);
         });
         it('should use charCode if no char', function() {
-            expect(KeyboardUtil.getKeysym({char : '', charCode: 'Š'.charCodeAt(), keyCode: 0x42, which: 0x43})).to.have.property('keysym', 0x01a9);
-            expect(KeyboardUtil.getKeysym({charCode: 'Š'.charCodeAt(), keyCode: 0x42, which: 0x43})).to.have.property('keysym', 0x01a9);
-            expect(KeyboardUtil.getKeysym({char : 'hello', charCode: 'Š'.charCodeAt(), keyCode: 0x42, which: 0x43})).to.have.property('keysym', 0x01a9);
+            expect(KeyboardUtil.getKeysym({char : '', charCode: 'Š'.charCodeAt(), keyCode: 0x42, which: 0x43})).to.be.equal(0x01a9);
+            expect(KeyboardUtil.getKeysym({charCode: 'Š'.charCodeAt(), keyCode: 0x42, which: 0x43})).to.be.equal(0x01a9);
+            expect(KeyboardUtil.getKeysym({char : 'hello', charCode: 'Š'.charCodeAt(), keyCode: 0x42, which: 0x43})).to.be.equal(0x01a9);
         });
         it('should use keyCode if no charCode', function() {
-            expect(KeyboardUtil.getKeysym({keyCode: 0x42, which: 0x43, shiftKey: false})).to.have.property('keysym', 0x62);
-            expect(KeyboardUtil.getKeysym({keyCode: 0x42, which: 0x43, shiftKey: true})).to.have.property('keysym', 0x42);
+            expect(KeyboardUtil.getKeysym({keyCode: 0x42, which: 0x43, shiftKey: false})).to.be.equal(0x62);
+            expect(KeyboardUtil.getKeysym({keyCode: 0x42, which: 0x43, shiftKey: true})).to.be.equal(0x42);
+        });
+        it('should return null for unknown keycodes', function() {
+            expect(KeyboardUtil.getKeysym({keyCode: 0xc0, which: 0xc1, shiftKey:false})).to.be.null;
+            expect(KeyboardUtil.getKeysym({keyCode: 0xde, which: 0xdf, shiftKey:false})).to.be.null;
         });
         it('should use which if no keyCode', function() {
-            expect(KeyboardUtil.getKeysym({which: 0x43, shiftKey: false})).to.have.property('keysym', 0x63);
-            expect(KeyboardUtil.getKeysym({which: 0x43, shiftKey: true})).to.have.property('keysym', 0x43);
+            expect(KeyboardUtil.getKeysym({which: 0x43, shiftKey: false})).to.be.equal(0x63);
+            expect(KeyboardUtil.getKeysym({which: 0x43, shiftKey: true})).to.be.equal(0x43);
         });
-        it('should substitute where applicable', function() {
-            expect(KeyboardUtil.getKeysym({char : 'Ș'})).to.have.property('keysym', 0x1aa);
+
+        describe('Non-character keys', function() {
+            it('should recognize the right keys', function() {
+                expect(KeyboardUtil.getKeysym({keyCode: 0x0d})).to.be.equal(0xFF0D);
+                expect(KeyboardUtil.getKeysym({keyCode: 0x08})).to.be.equal(0xFF08);
+                expect(KeyboardUtil.getKeysym({keyCode: 0x09})).to.be.equal(0xFF09);
+                expect(KeyboardUtil.getKeysym({keyCode: 0x10})).to.be.equal(0xFFE1);
+                expect(KeyboardUtil.getKeysym({keyCode: 0x11})).to.be.equal(0xFFE3);
+                expect(KeyboardUtil.getKeysym({keyCode: 0x12})).to.be.equal(0xFFE9);
+                expect(KeyboardUtil.getKeysym({keyCode: 0xe0})).to.be.equal(0xFFE7);
+                expect(KeyboardUtil.getKeysym({keyCode: 0xe1})).to.be.equal(0xFE03);
+                expect(KeyboardUtil.getKeysym({keyCode: 0x1b})).to.be.equal(0xFF1B);
+                expect(KeyboardUtil.getKeysym({keyCode: 0x26})).to.be.equal(0xFF52);
+            });
+            it('should not recognize character keys', function() {
+                expect(KeyboardUtil.getKeysym({keyCode: 'A'})).to.be.null;
+                expect(KeyboardUtil.getKeysym({keyCode: '1'})).to.be.null;
+                expect(KeyboardUtil.getKeysym({keyCode: '.'})).to.be.null;
+                expect(KeyboardUtil.getKeysym({keyCode: ' '})).to.be.null;
+            });
         });
     });
 
@@ -146,13 +192,13 @@ describe('Helpers', function() {
                 expect(sync.keydown({
                     keyCode: 0x41,
                     ctrlKey: true,
-                })).to.be.deep.equal([{keysym: keysyms.lookup(0xffe3), type: 'keydown'}]);
+                })).to.be.deep.equal([{keysym: 0xffe3, type: 'keydown'}]);
             });
             it('should sync if modifier is suddenly up', function() {
                 expect(sync.keydown({
                     keyCode: 0x41,
                     ctrlKey: false
-                })).to.be.deep.equal([{keysym: keysyms.lookup(0xffe3), type: 'keyup'}]);
+                })).to.be.deep.equal([{keysym: 0xffe3, type: 'keyup'}]);
             });
         });
         describe('Toggle Alt', function() {
@@ -161,13 +207,13 @@ describe('Helpers', function() {
                 expect(sync.keydown({
                     keyCode: 0x41,
                     altKey: true,
-                })).to.be.deep.equal([{keysym: keysyms.lookup(0xffe9), type: 'keydown'}]);
+                })).to.be.deep.equal([{keysym: 0xffe9, type: 'keydown'}]);
             });
             it('should sync if modifier is suddenly up', function() {
                 expect(sync.keydown({
                     keyCode: 0x41,
                     altKey: false
-                })).to.be.deep.equal([{keysym: keysyms.lookup(0xffe9), type: 'keyup'}]);
+                })).to.be.deep.equal([{keysym: 0xffe9, type: 'keyup'}]);
             });
         });
         describe('Toggle AltGr', function() {
@@ -176,13 +222,13 @@ describe('Helpers', function() {
                 expect(sync.keydown({
                     keyCode: 0x41,
                     altGraphKey: true,
-                })).to.be.deep.equal([{keysym: keysyms.lookup(0xfe03), type: 'keydown'}]);
+                })).to.be.deep.equal([{keysym: 0xfe03, type: 'keydown'}]);
             });
             it('should sync if modifier is suddenly up', function() {
                 expect(sync.keydown({
                     keyCode: 0x41,
                     altGraphKey: false
-                })).to.be.deep.equal([{keysym: keysyms.lookup(0xfe03), type: 'keyup'}]);
+                })).to.be.deep.equal([{keysym: 0xfe03, type: 'keyup'}]);
             });
         });
         describe('Toggle Shift', function() {
@@ -191,13 +237,13 @@ describe('Helpers', function() {
                 expect(sync.keydown({
                     keyCode: 0x41,
                     shiftKey: true,
-                })).to.be.deep.equal([{keysym: keysyms.lookup(0xffe1), type: 'keydown'}]);
+                })).to.be.deep.equal([{keysym: 0xffe1, type: 'keydown'}]);
             });
             it('should sync if modifier is suddenly up', function() {
                 expect(sync.keydown({
                     keyCode: 0x41,
                     shiftKey: false
-                })).to.be.deep.equal([{keysym: keysyms.lookup(0xffe1), type: 'keyup'}]);
+                })).to.be.deep.equal([{keysym: 0xffe1, type: 'keyup'}]);
             });
         });
         describe('Toggle Meta', function() {
@@ -206,13 +252,13 @@ describe('Helpers', function() {
                 expect(sync.keydown({
                     keyCode: 0x41,
                     metaKey: true,
-                })).to.be.deep.equal([{keysym: keysyms.lookup(0xffe7), type: 'keydown'}]);
+                })).to.be.deep.equal([{keysym: 0xffe7, type: 'keydown'}]);
             });
             it('should sync if modifier is suddenly up', function() {
                 expect(sync.keydown({
                     keyCode: 0x41,
                     metaKey: false
-                })).to.be.deep.equal([{keysym: keysyms.lookup(0xffe7), type: 'keyup'}]);
+                })).to.be.deep.equal([{keysym: 0xffe7, type: 'keyup'}]);
             });
         });
         describe('Modifier keyevents', function() {
@@ -240,14 +286,14 @@ describe('Helpers', function() {
                 expect(KeyboardUtil.ModifierSync().keydown({
                     keyCode: 0x11,
                     altKey: true
-                })).to.be.deep.equal([{keysym: keysyms.lookup(0xffe9), type: 'keydown'}]);
+                })).to.be.deep.equal([{keysym: 0xffe9, type: 'keydown'}]);
             })
         });
         describe('sync modifiers on non-key events', function() {
             it('should generate sync events when receiving non-keyboard events', function() {
                 expect(KeyboardUtil.ModifierSync().syncAny({
                     altKey: true
-                })).to.be.deep.equal([{keysym: keysyms.lookup(0xffe9), type: 'keydown'}]);
+                })).to.be.deep.equal([{keysym: 0xffe9, type: 'keydown'}]);
             });
         });
         describe('do not treat shift as a modifier key', function() {