]> git.proxmox.com Git - mirror_zfs.git/commit - cmd/zfs/zfs_main.c
cppcheck: (error) Null pointer dereference: who_perm
authorBrian Behlendorf <behlendorf1@llnl.gov>
Mon, 16 Dec 2019 23:49:28 +0000 (15:49 -0800)
committerBrian Behlendorf <behlendorf1@llnl.gov>
Thu, 19 Dec 2019 01:25:23 +0000 (17:25 -0800)
commit1e49b288cbb2ffa14b0031d8db77beef6e01974a
treef609c84bf1cb715248692c43e3b35c7d37d00bbc
parent070402f112bcfbf53b7da9bedc9453721b159e96
cppcheck: (error) Null pointer dereference: who_perm

As indicated by the VERIFY the local who_perm variable can never
be NULL in parse_fs_perm().  Due to the existence of the is_set
conditional, which is always true, cppcheck 1.88 was reporting
a possible NULL reference.  Resolve the issue by removing the
extraneous is_set variable.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #9732
cmd/zfs/zfs_main.c