]> git.proxmox.com Git - mirror_zfs.git/commit - config/kernel-dentry-operations.m4
Fix false ENOENT on snapshot control dentries
authorNed Bass <bass6@llnl.gov>
Mon, 14 Jan 2013 21:59:14 +0000 (13:59 -0800)
committerBrian Behlendorf <behlendorf1@llnl.gov>
Thu, 17 Jan 2013 00:28:54 +0000 (16:28 -0800)
commitf1a05fa11484d67161606fd1ecf50bf2abc25ced
tree674f566861abf0ab8005ca1d6eebfaeddc0ac54f
parent94a9bb4709111f5fadb434cce1af6ccb6534e241
Fix false ENOENT on snapshot control dentries

Lookups in the snapshot control directory for an existing snapshot
fail with ENOENT if an earlier lookup failed before the snapshot was
created.  This is because the earlier lookup causes a negative dentry
to be cached which is never invalidated.

The bug can be reproduced as follows (the second ls should succeed):

 $ ls /tank/.zfs/snapshot/s
 ls: cannot access /tank/.zfs/snapshot/s: No such file or directory
 $ zfs snap tank@s
 $ ls /tank/.zfs/snapshot/s
 ls: cannot access /tank/.zfs/snapshot/s: No such file or directory

To remedy this, always invalidate cached dentries in the snapshot
control directory.  Since these entries never exist on disk there is
no significant performance penalty for the extra lookups.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #1192
config/kernel-dentry-operations.m4 [new file with mode: 0644]
config/kernel.m4
include/linux/dcache_compat.h
module/zfs/zpl_ctldir.c