]> git.proxmox.com Git - mirror_zfs.git/commit - include/sys/fs/zfs.h
Check ashift validity in 'zpool add'
authorLOLi <loli10K@users.noreply.github.com>
Wed, 29 Mar 2017 00:21:11 +0000 (02:21 +0200)
committerBrian Behlendorf <behlendorf1@llnl.gov>
Wed, 29 Mar 2017 00:21:11 +0000 (17:21 -0700)
commitff61d1a4959065aa99d52489438f6737765987c6
treefd69cf41719b077ee6408b19cba70ae15c6491db
parent12aec7dcd9b1f4c86eb71d5b9dc737433ee93167
Check ashift validity in 'zpool add'

df83110 added the ability to specify a custom "ashift" value from the command
line in 'zpool add' and 'zpool attach'. This commit adds additional checks to
the provided ashift to prevent invalid values from being used, which could
result in disastrous consequences for the whole pool.

Additionally provide ASHIFT_MAX and ASHIFT_MIN definitions in spa.h.

Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: loli10K <ezomori.nozomu@gmail.com>
Closes #5878
cmd/zpool/zpool_vdev.c
include/sys/fs/zfs.h
include/sys/spa.h
lib/libzfs/libzfs_pool.c
module/zfs/vdev.c
tests/runfiles/linux.run
tests/zfs-tests/tests/functional/cli_root/zpool_add/Makefile.am
tests/zfs-tests/tests/functional/cli_root/zpool_add/add-o_ashift.ksh [new file with mode: 0644]