]> git.proxmox.com Git - mirror_zfs.git/commit - module/zfs/vdev_label.c
OpenZFS 9189 - Add debug to vdev_label_read_config when txg check fails
authorPavel Zakharov <pavel.zakharov@delphix.com>
Wed, 14 Sep 2016 15:01:40 +0000 (11:01 -0400)
committerBrian Behlendorf <behlendorf1@llnl.gov>
Mon, 14 May 2018 18:32:49 +0000 (14:32 -0400)
commit38a19edd34f6a3fc0c8d0f6b9750fc2df2856c9f
tree92b240d1deee9efddbc699ca0327da51ca86ce56
parentdb7d07e14ba4b964f64058e2c3d121d32f8d53c4
OpenZFS 9189 - Add debug to vdev_label_read_config when txg check fails

These changes were added to help debug issue #9187.

Essentially, in the original bug, vdev_validate() seems to fails in
vdev_label_read_config() and prints "failed reading config". This could
happen because either:
1. The labels are actually corrupt and zio_wait() fails for all of them
2. The labels were discarded because they didn't pass the txg check.

Beyond 9187, having debug info when case 2 happens could be useful in
other scenarios, such as zpool import.

Authored by: Pavel Zakharov <pavel.zakharov@delphix.com>
Reviewed by: George Wilson <george.wilson@delphix.com>
Reviewed by: Prashanth Sreenivasa <pks@delphix.com>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Approved by: Matt Ahrens <mahrens@delphix.com>
Ported-by: Brian Behlendorf <behlendorf1@llnl.gov>
OpenZFS-issue: https://illumos.org/issues/9189
OpenZFS-commit: https://github.com/openzfs/openzfs/commit/f6af1b7
Closes #7533
module/zfs/vdev.c
module/zfs/vdev_label.c