]> git.proxmox.com Git - mirror_qemu.git/commit - target-i386/cpu.c
target-i386: kvm_cpu_fill_host(): No need to check xlevel2
authorEduardo Habkost <ehabkost@redhat.com>
Mon, 20 Jan 2014 16:41:11 +0000 (14:41 -0200)
committerPaolo Bonzini <pbonzini@redhat.com>
Mon, 3 Feb 2014 16:33:54 +0000 (17:33 +0100)
commit803a932706e3ba335d4c98f3577a05cb000f1699
tree36e4ba70a505d22749662c14f7909ae691d5c490
parentb73dcfb16fc894041de553ac9f98b9e1640fcf06
target-i386: kvm_cpu_fill_host(): No need to check xlevel2

There's no need to check CPU xlevel2 before calling
kvm_arch_get_supported_cpuid(s, 0xC0000001, 0, R_EDX), because:

 * The kernel won't return any entry for 0xC0000000 if host CPU vendor
   is not Centaur (See kvm_dev_ioctl_get_supported_cpuid() on the kernel
   code)
 * Similarly, the kernel won't return any entry for 0xC0000001 if
   CPUID[0xC0000000].EAX is < 0xC0000001
 * kvm_arch_get_supported_cpuid() will return 0 if no entry is returned
   by the kernel for the requested leaf

For similar reasons, we can simply set x86_cpu_def->xlevel2 directly
instead of making it conditional, because it will be set to 0 CPU vendor
is not Centaur.

This will simplify the kvm_cpu_fill_host() code a little.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
[Remove unparseable comment. - Paolo]
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
target-i386/cpu.c