]> git.proxmox.com Git - mirror_zfs.git/commit
Handle vdev_lookup_top() failure in dva_get_dsize_sync()
authorBrian Behlendorf <behlendorf1@llnl.gov>
Mon, 5 May 2014 18:28:12 +0000 (11:28 -0700)
committerBrian Behlendorf <behlendorf1@llnl.gov>
Tue, 6 May 2014 17:41:48 +0000 (10:41 -0700)
commit2c33b9127569ad62b4cfe7dd4f651ceeee3d005c
tree8f6345e90df320a9640352a30f65ec9939364a02
parent962d52421236fc9cd61d59b4f18cff3276077da9
Handle vdev_lookup_top() failure in dva_get_dsize_sync()

The dva_get_dsize_sync() function incorrectly assumes that the call
to vdev_lookup_top() cannot fail.  However, the NULL dereference at
clearly shows that under certain circumstances it is possible.  Note
that offset 0x570 (1376) maps as expected to vd->vdev_deflate_ratio.

  BUG: unable to handle kernel NULL pointer dereference at 00000570

  crash> struct -o vdev
  struct vdev {
       [0] uint64_t vdev_id;
       ... ...
    [1376] uint64_t vdev_deflate_ratio;

Given that this can happen this patch add the required error handling.
In the case where vdev_lookup_top() fails assume that no deflation
will occur for the DVA and use the asize.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ned Bass <bass6@llnl.gov>
Signed-off-by: Alexey Zhuravlev <alexey.zhuravlev@intel.com>
Closes #1707
Closes #1987
Closes #1891

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
module/zfs/spa_misc.c