]> git.proxmox.com Git - mirror_edk2.git/commit
FmpDevicePkg/FmpDxe: Fix Clang build error
authorMichael Kubacki <michael.kubacki@microsoft.com>
Wed, 12 Aug 2020 00:23:57 +0000 (08:23 +0800)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Thu, 13 Aug 2020 07:09:15 +0000 (07:09 +0000)
commit3633d5309f67550e2369776b37220674ad1b623c
treeb05f94ab0af42e3e154c9cd4c9d186fe6d3d1fb9
parente0eacd7daa6f2e59de2b35a5dfe8bb4c38821e31
FmpDevicePkg/FmpDxe: Fix Clang build error

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2887

The local Private pointer variable in SetTheImage() is initialized
based on the caller provided This pointer argument. The cleanup
label path uses the Private pointer which will not be
initialized if This is NULL.

This change initializes Private to NULL and accounts for Private
potentially being NULL in the cleanup label path.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Guomin Jiang <guomin.jiang@intel.com>
Cc: Wei6 Xu <wei6.xu@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Tested-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Guomin Jiang <guomin.jiang@intel.com>
FmpDevicePkg/FmpDxe/FmpDxe.c