]> git.proxmox.com Git - qemu.git/commit
target-i386: check/enforce: Check SVM flag support as well
authorEduardo Habkost <ehabkost@redhat.com>
Fri, 4 Jan 2013 22:01:09 +0000 (20:01 -0200)
committerAndreas Färber <afaerber@suse.de>
Tue, 8 Jan 2013 20:03:44 +0000 (21:03 +0100)
commit396d2cfccdc1a46a8c66d9d9baaa59071a553b1c
treebb548936b96477a3dc20e4c81775e16608c49159
parent227146259e8deb14b7b30e7718e61512e0f524a9
target-i386: check/enforce: Check SVM flag support as well

When nested SVM is supported, the kernel returns the SVM flag on
GET_SUPPORTED_CPUID[1], so we can check the SVM flag safely in
kvm_check_features_against_host().

I don't know why the original code ignored the SVM flag. Maybe it was
because kvm_cpu_fill_host() used the CPUID instruction directly instead
of GET_SUPPORTED_CPUID

[1] Older kernels (before v2.6.37) returned the SVM flag even if nested
    SVM was _not_ supported. So the only cases where this patch should
    change behavior is when SVM is being requested by the user or the
    CPU model, but not supported by the host. And on these cases we
    really want QEMU to abort if the "enforce" option is set.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
target-i386/cpu.c