]> git.proxmox.com Git - mirror_zfs.git/commit
Remove unnecessary equality check
authorTobin Harding <me@tobin.cc>
Fri, 6 Oct 2017 02:33:44 +0000 (13:33 +1100)
committerTony Hutter <hutter2@llnl.gov>
Mon, 16 Oct 2017 17:57:55 +0000 (10:57 -0700)
commit80cc2f6111d4300d5293f7d95d4b0c77d9df8bd9
tree2308f5749dc84bb691b6328ad4a8e6436048c294
parentb97948276d86343e3f4a9aa1232af9e02106ceeb
Remove unnecessary equality check

Currently `if` statement includes an assignment (from a function return
value) and a equality check. The parenthesis are in the incorrect place,
currently the code clobbers the function return value because of this.

We can fix this by simplifying the `if` statement.

`if (foo != 0)`

can be more succinctly expressed as

`if (foo)`

Remove the equality check, add parenthesis to correct the statement.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Chris Dunlop <chris@onthe.net.au>
Signed-off-by: Tobin C. Harding <me@tobin.cc>
Closes #6685
Close #6719
module/zfs/zfs_vnops.c