]> git.proxmox.com Git - mirror_zfs.git/commit
Fix estimated scrub completion time
authorTom Caputi <tcaputi@datto.com>
Thu, 2 May 2019 00:34:24 +0000 (20:34 -0400)
committerBrian Behlendorf <behlendorf1@llnl.gov>
Thu, 2 May 2019 00:34:24 +0000 (17:34 -0700)
commit85bdc6840190879e4b97364dfa6d93e2877a265e
tree8bdf9aafd812e3285adcc91438c8863738e40988
parent6bdefad311a87452b557febd5be33b627775a006
Fix estimated scrub completion time

Currently, it is possible for the 'zpool scrub' command to
progress slightly beyond 100% due to concurrent changes
happening on the live pool. This behavior is expected, but
the userspace code for 'zpool status' would subtract the
expected amount of data from the amount of data already
scrubbed, resulting in a negative integer being casted to a
large positive one. This number was then used to calculate
the estimated completion time, resulting in wildly wrong
results. This code changes the behavior so that 'zpool status'
does not attempt to report an estimate during this period.

Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Tom Caputi <tcaputi@datto.com>
Closes #8611
Closes #8687
cmd/zpool/zpool_main.c
man/man8/zpool.8