]> git.proxmox.com Git - mirror_edk2.git/commit
BaseTools/GenFds: unbreak Region.PadBuffer
authorLaszlo Ersek <lersek@redhat.com>
Tue, 12 Jul 2016 13:52:38 +0000 (15:52 +0200)
committerLaszlo Ersek <lersek@redhat.com>
Tue, 12 Jul 2016 14:22:28 +0000 (16:22 +0200)
commita78b518b6eddef545fa440822bec315b31e4e987
tree01b45543231d0d393b28497fc19517858c65ae2b
parente191a3114f4c8fc0a05e4dc7bb72935f18ff4de9
BaseTools/GenFds: unbreak Region.PadBuffer

In its current form, Region.PadBuffer() fills every second byte with 0x20,
the default separator string of Python's string.join():

https://docs.python.org/2/library/string.html#string.join

This corrupts some firmware because (a) 0x20 never corresponds to any
ErasePolarity, (b) the PadData produced are actually longer than Size.

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Reported-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Fixes: bd907fb6386560e621112beca7b7d381d0003967
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Tested-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
BaseTools/Source/Python/GenFds/Region.py