]> git.proxmox.com Git - mirror_zfs.git/commit
OpenZFS 9330 - stack overflow when creating a deeply nested dataset
authorSerapheim Dimitropoulos <serapheim.dimitro@delphix.com>
Mon, 12 Sep 2016 15:15:20 +0000 (08:15 -0700)
committerBrian Behlendorf <behlendorf1@llnl.gov>
Mon, 9 Jul 2018 20:02:50 +0000 (13:02 -0700)
commita7ed98d8b5cefbd62ed39b9cf25860dad3922861
tree7e688c96f11d41ac1b488da92b4c45e707348a51
parent66df02497c900dd1a74fdc218f9a81b690a40d47
OpenZFS 9330 - stack overflow when creating a deeply nested dataset

Datasets that are deeply nested (~100 levels) are impractical. We just
put a limit of 50 levels to newly created datasets. Existing datasets
should work without a problem.

The problem can be seen by attempting to create a dataset using the -p
option with many levels:

    panic[cpu0]/thread=ffffff01cd282c20: BAD TRAP: type=8 (#df Double fault) rp=ffffffff

    fffffffffbc3aa60 unix:die+100 ()
    fffffffffbc3ab70 unix:trap+157d ()
    ffffff00083d7020 unix:_patch_xrstorq_rbx+196 ()
    ffffff00083d7050 zfs:dbuf_rele+2e ()
    ...
    ffffff00083d7080 zfs:dsl_dir_close+32 ()
    ffffff00083d70b0 zfs:dsl_dir_evict+30 ()
    ffffff00083d70d0 zfs:dbuf_evict_user+4a ()
    ffffff00083d7100 zfs:dbuf_rele_and_unlock+87 ()
    ffffff00083d7130 zfs:dbuf_rele+2e ()
    ... The block above repeats once per directory in the ...
    ... create -p command, working towards the root ...
    ffffff00083db9f0 zfs:dsl_dataset_drop_ref+19 ()
    ffffff00083dba20 zfs:dsl_dataset_rele+42 ()
    ffffff00083dba70 zfs:dmu_objset_prefetch+e4 ()
    ffffff00083dbaa0 zfs:findfunc+23 ()
    ffffff00083dbb80 zfs:dmu_objset_find_spa+38c ()
    ffffff00083dbbc0 zfs:dmu_objset_find+40 ()
    ffffff00083dbc20 zfs:zfs_ioc_snapshot_list_next+4b ()
    ffffff00083dbcc0 zfs:zfsdev_ioctl+347 ()
    ffffff00083dbd00 genunix:cdev_ioctl+45 ()
    ffffff00083dbd40 specfs:spec_ioctl+5a ()
    ffffff00083dbdc0 genunix:fop_ioctl+7b ()
    ffffff00083dbec0 genunix:ioctl+18e ()
    ffffff00083dbf10 unix:brand_sys_sysenter+1c9 ()

Porting notes:
* Added zfs_max_dataset_nesting module option with documentation.
* Updated zfs_rename_014_neg.ksh for Linux.
* Increase the zfs.sh stack warning to 15K.  Enough time has passed
  that 16K can be reasonably assumed to be the default value.  It
  was increased in the 3.15 kernel released in June of 2014.

Authored by: Serapheim Dimitropoulos <serapheim.dimitro@delphix.com>
Reviewed by: John Kennedy <john.kennedy@delphix.com>
Reviewed by: Matt Ahrens <matt@delphix.com>
Ported-by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Garrett D'Amore <garrett@damore.org>

OpenZFS-issue: https://www.illumos.org/issues/9330
OpenZFS-commit: https://github.com/openzfs/openzfs/commit/757a75a
Closes #7681
13 files changed:
include/zfs_namecheck.h
lib/libzfs/libzfs_dataset.c
man/man5/zfs-module-parameters.5
man/man8/zfs.8
module/zcommon/zfs_namecheck.c
module/zfs/dmu_objset.c
module/zfs/dsl_dir.c
scripts/zfs.sh
tests/runfiles/linux.run
tests/zfs-tests/tests/functional/cli_root/zfs_create/zfs_create.cfg
tests/zfs-tests/tests/functional/cli_root/zfs_create/zfs_create_009_neg.ksh
tests/zfs-tests/tests/functional/cli_root/zfs_rename/Makefile.am
tests/zfs-tests/tests/functional/cli_root/zfs_rename/zfs_rename_014_neg.ksh [new file with mode: 0755]