]> git.proxmox.com Git - mirror_zfs.git/commit
Cleanup: Suppress Coverity dereference before/after NULL check reports
authorRichard Yao <richard.yao@alumni.stonybrook.edu>
Thu, 10 Nov 2022 14:09:35 +0000 (09:09 -0500)
committerBrian Behlendorf <behlendorf1@llnl.gov>
Thu, 10 Nov 2022 21:58:05 +0000 (13:58 -0800)
commitb1eec00904a22bd6600a2853709ca50faa56ea24
tree5b802a2ad7252d73192b68740f1fdf1925663d0a
parent9e2be2dfbde6c41ff53d71f3669cb6b9909c5a40
Cleanup: Suppress Coverity dereference before/after NULL check reports

f224eddf922a33ca4b86d83148e9e6fa155fc290 began dereferencing a NULL
checked pointer in zpl_vap_init(), which made Coverity complain because
either the dereference is unsafe or the NULL check is unnecessary. Upon
inspection, this pointer is guaranteed to never be NULL because it is
from the Linux kernel VFS. The calls into ZFS simply would not make
sense if this pointer were NULL, so the NULL check is unnecessary.

Reported-by: Coverity (CID 1527260)
Reported-by: Coverity (CID 1527262)
Reviewed-by: Mariusz Zaborski <mariusz.zaborski@klarasystems.com>
Reviewed-by: Youzhong Yang <yyang@mathworks.com>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #14170
module/os/linux/zfs/zpl_inode.c