]> git.proxmox.com Git - mirror_zfs.git/commit
zcommon: pre-iterate over sysfs instead of statting every feature
authorнаб <nabijaczleweli@nabijaczleweli.xyz>
Fri, 17 Dec 2021 00:43:10 +0000 (01:43 +0100)
committerGitHub <noreply@github.com>
Fri, 17 Dec 2021 00:43:10 +0000 (16:43 -0800)
commiteb51a9d74742bd2dc4e31c1806532149593101df
treed3ec2ed57a9a8e573f5304f6ca401160fe4ed3a9
parent8fdc6f618cf19e1894f5a803e043e80e762a86b1
zcommon: pre-iterate over sysfs instead of statting every feature

If sufficient memory (<2K, realistically) is available, libzfs_init()
can be significantly shorted by iterating over the correct sysfs
directory before registrations, we can turn 168 stats into 15/18
syscalls (3 opens (6 if built in), 3 fstats, 6 getdentses, and 3
closes), a tenfoldish reduction; this is probably a bit faster, too.

The list is always optional, and registration functions (and one-off
users) can simply pass NULL, which will fall back to the previous
mechanism

Also, don't allocate in zfs_mod_supported_impl, and use use access()
instead of stat(), since existence is really what we care about

Also, fix pre-prop-checking compat in fallback for built-in ZFS

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes #12089
include/sys/zfs_sysfs.h
include/zfs_prop.h
lib/libzfs/libzfs.abi
module/zcommon/zfeature_common.c
module/zcommon/zfs_prop.c
module/zcommon/zpool_prop.c
module/zcommon/zprop_common.c