]> git.proxmox.com Git - mirror_edk2.git/commit
UefiPayloadPkg: Add support for logging to CBMEM console
authorBenjamin Doron <benjamin.doron00@gmail.com>
Sun, 22 May 2022 18:20:55 +0000 (14:20 -0400)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Wed, 27 Jul 2022 20:54:35 +0000 (20:54 +0000)
commitf26b70cb9f1367ceb25190ba2777631ee42c69fe
tree349032fa52a9d7af1422c5c456687617305c236e
parent2677286307c67b62c198cf6890d62ec540dd8c99
UefiPayloadPkg: Add support for logging to CBMEM console

Writes TianoCore debug logs into the CBMEM console ringbuffer, from
where the user can retrieve them with the `cbmem` userspace utility.

The intention is to aid in debugging non-fatal issues even in release
builds, or simply make TianoCore's logs available to those interested.
Consequently, MDEPKG_NDEBUG must be masked. As an in-memory debug
logging library, ASSERTs must be non-fatal to be seen, so they neither
dead-loop nor create a breakpoint. It is assumed that ASSERT() neither
enforces fatal conditions nor security integrity, as release builds do
not call DebugAssert() from the ASSERT macro.

More detailed debug logs are produced with the DEBUG_CODE macro, but
this guards other debug-related code throughout the codebase. To avoid
changing behaviour on release builds, this is only set for debug builds.

Tested on QEMU, dumping the appropriate memory region in the UEFI shell
shows the TianoCore log. An improved revision of the debug library used
in several coreboot-related EDK2 forks, including MrChromebox's.
Previous revisions also tested on an Acer Aspire VN7-572G laptop.

Cc: Guo Dong <guo.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Benjamin You <benjamin.you@intel.com>
Cc: Sean Rhodes <sean@starlabs.systems>
Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com>
UefiPayloadPkg/Include/Coreboot.h
UefiPayloadPkg/Library/CbSerialPortLib/CbSerialPortLib.c [new file with mode: 0644]
UefiPayloadPkg/Library/CbSerialPortLib/CbSerialPortLib.inf [new file with mode: 0644]
UefiPayloadPkg/UefiPayloadPkg.dsc