]> git.proxmox.com Git - mirror_edk2.git/commit
BaseTools: explicitly import email.header PatchCheck.py
authorLeif Lindholm <leif@nuviainc.com>
Thu, 2 Jul 2020 15:39:34 +0000 (23:39 +0800)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Fri, 3 Jul 2020 00:18:50 +0000 (00:18 +0000)
commitf56d52c7f581da4bb732ab6b456718ae59d39efa
treedaddf52f04d79a464d21bf34a0ce1272fe6f0820
parentc267eb889fe1244840eb4fd067fe0d85e3cc271f
BaseTools: explicitly import email.header PatchCheck.py

On Debian 10 (Buster), when running PatchCheck.py with python2, a
backtrace is printed, starting from:

  File "../edk2/BaseTools/Scripts/PatchCheck.py", line 595,
   in find_patch_pieces
    parts = email.header.decode_header(pmail.get('subject'))
  AttributeError: 'module' object has no attribute 'header'

When using python3, this backtrace does not appear.

Explicitly importing email.header resolves this for python2 and does not
appear to cause any issues with python3.

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Leif Lindholm <leif@nuviainc.com>
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
BaseTools/Scripts/PatchCheck.py