]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
fuse: Fix use-after-free in fuse_dev_do_write()
authorKirill Tkhai <ktkhai@virtuozzo.com>
Tue, 25 Sep 2018 09:52:42 +0000 (12:52 +0300)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Tue, 23 Apr 2019 15:51:47 +0000 (17:51 +0200)
commitf7b5f6081dccad5430cf3d0ffdfce9459b38dbf1
tree6be530c1d08ebc8586894ecb96ae44b371078c82
parent54c318d5004af458616ac91b685d2408c184435d
fuse: Fix use-after-free in fuse_dev_do_write()

BugLink: https://bugs.launchpad.net/bugs/1824553
After we found req in request_find() and released the lock,
everything may happen with the req in parallel:

cpu0                              cpu1
fuse_dev_do_write()               fuse_dev_do_write()
  req = request_find(fpq, ...)    ...
  spin_unlock(&fpq->lock)         ...
  ...                             req = request_find(fpq, oh.unique)
  ...                             spin_unlock(&fpq->lock)
  queue_interrupt(&fc->iq, req);   ...
  ...                              ...
  ...                              ...
  request_end(fc, req);
    fuse_put_request(fc, req);
  ...                              queue_interrupt(&fc->iq, req);

Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Fixes: 46c34a348b0a ("fuse: no fc->lock for pqueue parts")
Cc: <stable@vger.kernel.org> # v4.2
(cherry picked from commit d2d2d4fb1f54eff0f3faa9762d84f6446a4bc5d0)
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
fs/fuse/dev.c