Fix gcc compiler warning, dsl_pool_create()

When compiling ZFS in user space gcc-4.6.0 correctly identifies
the variable 'os' as being set but never used.  This generates a
warning and a build failure when using --enable-debug.  However,
the code is correct we only want to use 'os' for the kernel space
builds.  To suppress the warning the call was wrapped with a
VERIFY() which has the nice side effect of ensuring the 'os'
actually never is NULL.  This was observed under Fedora 15.

  module/zfs/dsl_pool.c: In function ‘dsl_pool_create’:
  module/zfs/dsl_pool.c:229:12: error: variable ‘os’ set but not used
  [-Werror=unused-but-set-variable]

diff --git a/module/zfs/dsl_pool.c b/module/zfs/dsl_pool.c
index 7185540f1a40d1a0908435a10f9ceebcf706a6a4..6c54193ce8eec035b48ae38765c8f7ea402e99bb 100644 (file)
--- a/module/zfs/dsl_pool.c
+++ b/module/zfs/dsl_pool.c
@@ -275,8 +275,8 @@ dsl_pool_create(spa_t *spa, nvlist_t *zplprops, uint64_t txg)
 
        /* create the root objset */
        VERIFY(0 == dsl_dataset_hold_obj(dp, obj, FTAG, &ds));
-       os = dmu_objset_create_impl(dp->dp_spa, ds,
-           dsl_dataset_get_blkptr(ds), DMU_OST_ZFS, tx);
+       VERIFY(NULL != (os = dmu_objset_create_impl(dp->dp_spa, ds,
+           dsl_dataset_get_blkptr(ds), DMU_OST_ZFS, tx)));
 #ifdef _KERNEL
        zfs_create_fs(os, kcred, zplprops, tx);
 #endif