Remove superfluous statement

Clang's static analyzer reported that the value assigned to pcksum is
never used. That is because we initialize both zc and pcksum to {{ 0 }}
and then do `pcksum = zc;`. That is fairly pointless. However, it has
the effect of generating a false positive in Clang's static analyzer.
Since noise from false positives can obscure real issues, we fix it
anyway.

Signed-off-by: Richard Yao <ryao@gentoo.org>
Signed-off-by: Ned Bass <bass6@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue #2330

diff --git a/cmd/zstreamdump/zstreamdump.c b/cmd/zstreamdump/zstreamdump.c
index c5bcdabd3cb63637acd4c2d262ffc4f67cbe65d7..a4c451d53029e62b3b349138bcf19d9ed6167902 100644 (file)
--- a/cmd/zstreamdump/zstreamdump.c
+++ b/cmd/zstreamdump/zstreamdump.c
@@ -127,7 +127,6 @@ main(int argc, char *argv[])
        }
 
        send_stream = stdin;
-       pcksum = zc;
        while (ssread(drr, sizeof (dmu_replay_record_t), &zc)) {
 
                if (first) {