]> git.proxmox.com Git - mirror_zfs.git/commitdiff
libzfs_sendrecv: Style pass on dump_filesystems
authorRyan Moeller <freqlabs@FreeBSD.org>
Wed, 18 Aug 2021 21:01:21 +0000 (21:01 +0000)
committerBrian Behlendorf <behlendorf1@llnl.gov>
Wed, 2 Feb 2022 01:03:38 +0000 (17:03 -0800)
* Add a high level comment.
* Eliminate unnecessarily void arg.
* Capitalize and punctuate complete sentences in comments.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <freqlabs@FreeBSD.org>
Closes #12967

lib/libzfs/libzfs_sendrecv.c

index 751e34a92b4b0d1a973830dc12ee1229c53fd65f..f96f1aa9332ad1e909a09f884122439a787bef0c 100644 (file)
@@ -1270,10 +1270,12 @@ dump_filesystem(zfs_handle_t *zhp, send_dump_data_t *sdd)
        return (rv);
 }
 
+/*
+ * Send all snapshots for all filesystems in sdd.
+ */
 static int
-dump_filesystems(zfs_handle_t *rzhp, void *arg)
+dump_filesystems(zfs_handle_t *rzhp, send_dump_data_t *sdd)
 {
-       send_dump_data_t *sdd = arg;
        nvpair_t *fspair;
        boolean_t needagain, progress;
 
@@ -1326,7 +1328,7 @@ again:
                if (parent_guid != 0) {
                        parent_nv = fsavl_find(sdd->fsavl, parent_guid, NULL);
                        if (!nvlist_exists(parent_nv, "sent")) {
-                               /* parent has not been sent; skip this one */
+                               /* Parent has not been sent; skip this one. */
                                needagain = B_TRUE;
                                continue;
                        }
@@ -1338,7 +1340,7 @@ again:
                        if (origin_nv != NULL &&
                            !nvlist_exists(origin_nv, "sent")) {
                                /*
-                                * origin has not been sent yet;
+                                * Origin has not been sent yet;
                                 * skip this clone.
                                 */
                                needagain = B_TRUE;
@@ -1361,7 +1363,7 @@ again:
                goto again;
        }
 
-       /* clean out the sent flags in case we reuse this fss */
+       /* Clean out the sent flags in case we reuse this fss. */
        for (fspair = nvlist_next_nvpair(sdd->fss, NULL); fspair;
            fspair = nvlist_next_nvpair(sdd->fss, fspair)) {
                nvlist_t *fslist;