selected.forEach(function(item) {
cur++;
if (item > 2) {
- days.push(Ext.Date.dayNames[(cur+1)] + '-' + Ext.Date.dayNames[(cur+item)%7]);
+ days.push(Ext.Date.dayNames[cur+1] + '-' + Ext.Date.dayNames[(cur+item)%7]);
cur += item-1;
} else if (item == 2) {
days.push(Ext.Date.dayNames[cur+1]);
render_hotplug_features: function(value) {
var fa = [];
- if (!value || (value === '0')) {
+ if (!value || value === '0') {
return gettext('Disabled');
}
},
render_qemu_machine: function(value) {
- return value || (Proxmox.Utils.defaultText + ' (i440fx)');
+ return value || Proxmox.Utils.defaultText + ' (i440fx)';
},
render_qemu_bios: function(value) {
}
},
render_as_property_string: function(value) {
- return (!value) ? Proxmox.Utils.defaultText
+ return !value ? Proxmox.Utils.defaultText
: PVE.Parser.printPropertyString(value);
},
format_storage_type: function(value, md, record) {
if (value === 'rbd') {
- value = (!record || record.get('monhost') ? 'rbd' : 'pveceph');
+ value = !record || record.get('monhost') ? 'rbd' : 'pveceph';
} else if (value === 'cephfs') {
- value = (!record || record.get('monhost') ? 'cephfs' : 'pvecephfs');
+ value = !record || record.get('monhost') ? 'cephfs' : 'pvecephfs';
}
var schema = PVE.Utils.storageSchema[value];
var maxcpu = record.data.maxcpu || 1;
- if (!Ext.isNumeric(maxcpu) && (maxcpu >= 1)) {
+ if (!Ext.isNumeric(maxcpu) && maxcpu >= 1) {
return '';
}
return -1;
}
- return (data.mem / data.maxmem);
+ return data.mem / data.maxmem;
},
render_mem_usage_percent: function(value, metaData, record, rowIndex, colIndex, store) {
return '';
}
- return ((mem*100)/maxmem).toFixed(1) + " %";
+ return (mem*100/maxmem).toFixed(1) + " %";
}
return (value*100).toFixed(1) + " %";
},
calculate_disk_usage: function(data) {
if (!Ext.isNumeric(data.disk) ||
data.type === 'qemu' ||
- (data.type === 'lxc' && data.uptime === 0) ||
+ data.type === 'lxc' && data.uptime === 0 ||
data.maxdisk === 0) {
return -1;
}
- return (data.disk / data.maxdisk);
+ return data.disk / data.maxdisk;
},
render_disk_usage_percent: function(value, metaData, record, rowIndex, colIndex, store) {
if (!Ext.isNumeric(disk) ||
type === 'qemu' ||
maxdisk === 0 ||
- (type === 'lxc' && record.data.uptime === 0)) {
+ type === 'lxc' && record.data.uptime === 0) {
return '';
}
}
var dv = PVE.VersionInfo.console || 'xtermjs';
if (dv === 'vv' && !allowSpice) {
- dv = (allowXtermjs) ? 'xtermjs' : 'html5';
+ dv = allowXtermjs ? 'xtermjs' : 'html5';
} else if (dv === 'xtermjs' && !allowXtermjs) {
- dv = (allowSpice) ? 'vv' : 'html5';
+ dv = allowSpice ? 'vv' : 'html5';
}
return dv;
var comp = {
xtype: tlckup[n.data.type || 'root'] ||
'pvePanelConfig',
- showSearch: (n.data.id === 'root') ||
+ showSearch: n.data.id === 'root' ||
Ext.isDefined(n.data.groupbyid),
pveSelNode: n,
workspace: me,
listeners: {
resize: function(panel, width, height) {
var viewHeight = me.getSize().height;
- if (height > (viewHeight - 150)) {
+ if (height > viewHeight - 150) {
panel.setHeight(viewHeight - 150);
}
},
var rec, msg;
if (me.selModel) {
rec = me.selModel.getSelection()[0];
- if (!rec || (me.enableFn(rec) === false)) {
+ if (!rec || me.enableFn(rec) === false) {
return;
}
}
if (item.selModel) {
me.mon(item.selModel, "selectionchange", function() {
var rec = item.selModel.getSelection()[0];
- if (!rec || (item.enableFn(rec) === false)) {
+ if (!rec || item.enableFn(rec) === false) {
item.setDisabled(true);
} else {
item.setDisabled(false);
if (me.selModel) {
me.mon(me.selModel, "selectionchange", function() {
var rec = me.selModel.getSelection()[0];
- if (!rec || (me.enableFn(rec) === false)) {
+ if (!rec || me.enableFn(rec) === false) {
me.setDisabled(true);
} else {
me.setDisabled(false);
},
formulas: {
canCreateFS: function(get) {
- return (!get('cephfsConfigured') && get('mdsCount') > 0);
+ return !get('cephfsConfigured') && get('mdsCount') > 0;
},
},
},
let rec = selection[0];
let vm = this.getViewModel();
- let isOsd = rec.data.host && (rec.data.type === 'osd') && (rec.data.id >= 0);
+ let isOsd = rec.data.host && rec.data.type === 'osd' && rec.data.id >= 0;
vm.set('isOsd', isOsd);
vm.set('downOsd', isOsd && rec.data.status === 'down');
}
});
var i;
- var quorummap = (status && status.quorum_names) ? status.quorum_names : [];
+ var quorummap = status && status.quorum_names ? status.quorum_names : [];
var monmessages = {};
var mgrmessages = {};
var mdsmessages = {};
if (pgmap.recovering_objects_per_sec !== undefined || unhealthy > 0) {
let total = pgmap.misplaced_total || pgmap.unfound_total || pgmap.degraded_total || 0;
if (total === 0) return;
- let recovered = (total - unhealthy) || 0;
+ let recovered = total - unhealthy || 0;
let speed = pgmap.recovering_bytes_per_sec || 0;
let speedTxt = PVE.Utils.render_bandwidth(speed);
let obj_per_sec = speed / (4*1024*1024); // 4MiB per Object
var regex = new RegExp("not (installed|initialized)", "i");
PVE.Utils.handleStoreErrorOrMask(me, me.store, regex, function(me, error) {
me.store.stopUpdate();
- PVE.Utils.showCephInstallOrMask(me, error.statusText, (nodename || 'localhost'),
+ PVE.Utils.showCephInstallOrMask(me, error.statusText, nodename || 'localhost',
function(win) {
me.mon(win, 'cephInstallWindowClosed', function() {
me.store.startUpdate();
var pgmap = status.pgmap || {};
var pgs_by_state = pgmap.pgs_by_state || [];
pgs_by_state.sort(function(a, b) {
- return (a.state_name < b.state_name)?-1:(a.state_name === b.state_name)?0:1;
+ return a.state_name < b.state_name?-1:a.state_name === b.state_name?0:1;
});
me.statecategories.forEach(function(cat) {
findVMID: function(vmid) {
var me = this, i;
- return (me.findExact('vmid', parseInt(vmid, 10)) >= 0);
+ return me.findExact('vmid', parseInt(vmid, 10)) >= 0;
},
// returns the cached data from all nodes
hidden: true,
convert: function(value, record) {
var info = record.data;
- return (Ext.isNumeric(info.uptime) && (info.uptime > 0));
+ return Ext.isNumeric(info.uptime) && info.uptime > 0;
},
},
text: {
var mode = selModeField.getValue();
store.clearFilter();
store.filterBy(function(rec) {
- return (!value || rec.get('node') === value);
+ return !value || rec.get('node') === value;
});
if (mode === 'all') {
sm.selectAll(true);
var node = nodesel.getValue();
store.clearFilter();
store.filterBy(function(rec) {
- return (!node || node.length === 0 || rec.get('node') === node);
+ return !node || node.length === 0 || rec.get('node') === node;
});
var list = vmidField.getValue();
var mode = selModeField.getValue();
return true;
}
- if (val === undefined || (val instanceof String && val.length === 0)) {
+ if (val === undefined || val instanceof String && val.length === 0) {
// let this be caught by allowBlank, if at all
return true;
}
}
}
- if (numNodes !== (nodes.online + nodes.offline)) {
+ if (numNodes !== nodes.online + nodes.offline) {
nodes.offline = numNodes - nodes.online;
}
sortable: true,
dataIndex: 'online',
renderer: function(value) {
- var cls = (value)?'good':'critical';
+ var cls = value?'good':'critical';
return '<i class="fa ' + PVE.Utils.get_health_icon(cls) + '"><i/>';
},
},
opts = opts || {};
me.rows = me.rows || {};
- let canEdit = (!opts.hasOwnProperty('caps') || opts.caps);
+ let canEdit = !opts.hasOwnProperty('caps') || opts.caps;
me.rows[name] = {
required: true,
defaultValue: opts.defaultValue,
initComponent: function() {
var me = this;
- me.isCreate = (me.group_name === undefined);
+ me.isCreate = me.group_name === undefined;
var subject;
selModel: sm,
baseurl: me.base_url + '/',
enableFn: function(rec) {
- return (rec && me.base_url);
+ return rec && me.base_url;
},
callback: function() {
reload();
var item = results[i];
switch (item.data.type) {
case 'node':
- cpu += (item.data.cpu * item.data.maxcpu);
+ cpu += item.data.cpu * item.data.maxcpu;
maxcpu += item.data.maxcpu || 0;
memory += item.data.mem || 0;
maxmem += item.data.maxmem || 0;
break;
}
if (!countedStorages[item.data.storage] ||
- (!item.data.shared && !countedStorages[item.data.id])) {
+ !item.data.shared && !countedStorages[item.data.id]) {
used += item.data.disk;
total += item.data.maxdisk;
}
var text = Ext.String.format(gettext('of {0} CPU(s)'), maxcpu);
- cpustat.updateValue((cpu/maxcpu), text);
+ cpustat.updateValue(cpu/maxcpu, text);
text = Ext.String.format(gettext('{0} of {1}'), PVE.Utils.render_size(memory), PVE.Utils.render_size(maxmem));
- memorystat.updateValue((memory/maxmem), text);
+ memorystat.updateValue(memory/maxmem, text);
text = Ext.String.format(gettext('{0} of {1}'), PVE.Utils.render_size(used), PVE.Utils.render_size(total));
- storagestat.updateValue((used/total), text);
+ storagestat.updateValue(used/total, text);
gueststatus.updateValues(qemu, lxc, error);
return get('secret').length > 0 && get('canSetupTOTP');
},
canDeleteTFA: function(get) {
- return (get('tfa_type') !== null && !get('tfa_required'));
+ return get('tfa_type') !== null && !get('tfa_required');
},
canSetupTOTP: function(get) {
var tfa = get('tfa_type');
- return (tfa === null || tfa === 'totp' || tfa === 1);
+ return tfa === null || tfa === 'totp' || tfa === 1;
},
canSetupU2F: function(get) {
var tfa = get('tfa_type');
- return (get('u2f_available') && (tfa === null || tfa === 'u2f' || tfa === 1));
+ return get('u2f_available') && (tfa === null || tfa === 'u2f' || tfa === 1);
},
secretEmpty: function(get) {
return get('secret').length === 0;
setNodename: function(nodename) {
var me = this;
- if (!nodename || (me.nodename === nodename)) {
+ if (!nodename || me.nodename === nodename) {
return;
}
if (rec.data.format) {
var format = rec.data.format[0]; // 0 is the formats, 1 the default in the backend
delete format.subvol; // we never need subvol in the gui
- selectformat = (Ext.Object.getSize(format) > 1);
+ selectformat = Ext.Object.getSize(format) > 1;
}
var select = !!rec.data.select_existing && !me.hideSelection;
var me = this;
var change = false;
- if (storage && (me.storage !== storage)) {
+ if (storage && me.storage !== storage) {
me.storage = storage;
change = true;
}
- if (nodename && (me.nodename !== nodename)) {
+ if (nodename && me.nodename !== nodename) {
me.nodename = nodename;
change = true;
}
}
// give the row the 'relevance' value
item.data.relevance = match;
- return (match > 0);
+ return match > 0;
},
updateFilter: function(field, newValue, oldValue) {
setPciID: function(pciid, force) {
var me = this;
- if (!force && (!pciid || (me.pciid === pciid))) {
+ if (!force && (!pciid || me.pciid === pciid)) {
return;
}
setNodename: function(nodename) {
var me = this;
- if (!nodename || (me.nodename === nodename)) {
+ if (!nodename || me.nodename === nodename) {
return;
}
var i, j;
for (j = 0; j < 9; j++) {
for (i = 0; i < 32; i++) {
- if ((value >= current_size) && (value < (current_size + dimm_size))) {
+ if (value >= current_size && value < current_size + dimm_size) {
value_start = current_size;
value_up = current_size + dimm_size;
- value_down = current_size - ((i === 0) ? prev_dimm_size : dimm_size);
+ value_down = current_size - (i === 0 ? prev_dimm_size : dimm_size);
}
current_size += dimm_size;
}
validator: function(value) {
var me = this;
- if (!me.onlineValidator || (me.allowBlank && !value)) {
+ if (!me.onlineValidator || me.allowBlank && !value) {
return true;
}
setNodename: function(nodename) {
var me = this;
- if (!nodename || (me.nodename === nodename)) {
+ if (!nodename || me.nodename === nodename) {
return;
}
setTargetNode: function(targetNode) {
var me = this;
- if (!targetNode || (me.targetNode === targetNode)) {
+ if (!targetNode || me.targetNode === targetNode) {
return;
}
setNodename: function(nodename) {
var me = this;
- if (!nodename || (me.nodename === nodename)) {
+ if (!nodename || me.nodename === nodename) {
return;
}
width: 520,
columns: [
{
- header: (me.type === 'device')?gettext('Device'):gettext('Port'),
+ header: me.type === 'device'?gettext('Device'):gettext('Port'),
sortable: true,
dataIndex: 'usbid',
width: 80,
applyState: function(state, doSelect) {
var view = me.getValue();
- if (state && state.value && (view != state.value)) {
+ if (state && state.value && view != state.value) {
var record = store.findRecord('key', state.value, 0, false, true, true);
if (record) {
me.setValue(state.value, true);
initComponent: function() {
var me = this;
- me.isCreate = (me.alias_name === undefined);
+ me.isCreate = me.alias_name === undefined;
if (me.isCreate) {
me.url = '/api2/extjs' + me.base_url;
throw "no list_refs_url specified";
}
- me.isCreate = (me.rule_pos === undefined);
+ me.isCreate = me.rule_pos === undefined;
if (me.isCreate) {
me.url = '/api2/extjs' + me.base_url;
initComponent: function() {
var me = this;
- me.isCreate = (me.rule_pos === undefined);
+ me.isCreate = me.rule_pos === undefined;
if (me.isCreate) {
me.url = '/api2/extjs' + me.base_url;
text: gettext('Copy'),
selModel: sm,
enableFn: function(rec) {
- return (rec.data.type === 'in' || rec.data.type === 'out');
+ return rec.data.type === 'in' || rec.data.type === 'out';
},
disabled: true,
handler: run_copy_editor,
],
filters: [
function(item) {
- return ((item.data.type === 'lxc' || item.data.type === 'qemu') && item.data.pool === '');
+ return (item.data.type === 'lxc' || item.data.type === 'qemu') && item.data.pool === '';
},
],
});
var items = [];
items.push({
- xtype: (me.isCreate && !vmid)?'pveGuestIDSelector':'displayfield',
+ xtype: me.isCreate && !vmid?'pveGuestIDSelector':'displayfield',
name: 'guest',
fieldLabel: 'CT/VM ID',
value: vmid || '',
me.rstore = Ext.create('Proxmox.data.UpdateStore', {
storeid: 'pve-replica-' + me.nodename + me.vmid,
- model: (mode === 'dc')? 'pve-replication' : 'pve-replication-state',
+ model: mode === 'dc'? 'pve-replication' : 'pve-replication-state',
interval: 3000,
proxy: {
type: 'proxmox',
},
isValid: function() {
var value = nodefield.getValue();
- return (value && 0 !== value.length);
+ return value && 0 !== value.length;
},
});
},
});
- var vmidStore = (me.vmid) ? {} : {
+ var vmidStore = me.vmid ? {} : {
model: 'PVEResources',
autoLoad: true,
sorters: 'vmid',
xtype: me.vmid ? 'displayfield' : 'vmComboSelector',
submitValue: me.isCreate,
name: 'vmid',
- fieldLabel: (me.vmid && me.guestType === 'ct') ? 'CT' : 'VM',
+ fieldLabel: me.vmid && me.guestType === 'ct' ? 'CT' : 'VM',
value: me.vmid,
store: vmidStore,
validateExists: true,
me.rstore = Ext.create('Proxmox.data.ObjectStore', {
interval: me.interval,
model: 'pve-ha-status',
- storeid: 'pve-store-' + (++Ext.idSeed),
+ storeid: 'pve-store-' + ++Ext.idSeed,
groupField: 'type',
proxy: {
type: 'proxmox',
sorterFn: function(rec1, rec2) {
var p1 = me.sortPriority[rec1.data.type];
var p2 = me.sortPriority[rec2.data.type];
- return (p1 !== p2) ? ((p1 > p2) ? 1 : -1) : 0;
+ return p1 !== p2 ? p1 > p2 ? 1 : -1 : 0;
},
}],
filters: {
Ext.create('PVE.ha.VMResourceEdit', {
vmid: vmid,
guestType: 'ct',
- isCreate: (!ha || ha === 'unmanaged'),
+ isCreate: !ha || ha === 'unmanaged',
}).show();
},
},
},
formulas: {
privilegedOnly: function(get) {
- return (get('unprivileged') ? gettext('privileged only') : '');
+ return get('unprivileged') ? gettext('privileged only') : '';
},
unprivilegedOnly: function(get) {
- return (!get('unprivileged') ? gettext('unprivileged only') : '');
+ return !get('unprivileged') ? gettext('unprivileged only') : '';
},
},
},
setNodename: function(nodename) {
var me = this;
- if (!nodename || (me.nodename === nodename)) {
+ if (!nodename || me.nodename === nodename) {
return;
}
cdata.name = 'eth0';
me.dataCache = {};
}
- cdata.firewall = (me.insideWizard || me.isCreate);
+ cdata.firewall = me.insideWizard || me.isCreate;
if (!me.dataCache) {
throw "no dataCache specified";
},
];
- var dhcp4 = (cdata.ip === 'dhcp');
+ var dhcp4 = cdata.ip === 'dhcp';
if (dhcp4) {
cdata.ip = '';
cdata.gw = '';
}
- var auto6 = (cdata.ip6 === 'auto');
- var dhcp6 = (cdata.ip6 === 'dhcp');
+ var auto6 = cdata.ip6 === 'auto';
+ var dhcp6 = cdata.ip6 === 'dhcp';
if (auto6 || dhcp6) {
cdata.ip6 = '';
cdata.gw6 = '';
value: cdata.ip6,
emptyText: dhcp6 || auto6 ? '' : Proxmox.Utils.NoneText,
vtype: 'IP6CIDRAddress',
- disabled: (dhcp6 || auto6),
+ disabled: dhcp6 || auto6,
fieldLabel: 'IPv6/CIDR', // do not localize
},
{
name: 'gw6',
vtype: 'IP6Address',
value: cdata.gw6,
- disabled: (dhcp6 || auto6),
+ disabled: dhcp6 || auto6,
fieldLabel: gettext('Gateway') + ' (IPv6)',
},
];
records.push(net);
});
me.store.loadData(records);
- me.down('button[name=addButton]').setDisabled((records.length >= 32));
+ me.down('button[name=addButton]').setDisabled(records.length >= 32);
},
});
},
var rowdef = rows[key];
var pending = rec.data['delete'] || me.hasPendingChanges(key);
- var isDisk = (rowdef.tdCls == 'pve-itype-icon-storage');
+ var isDisk = rowdef.tdCls == 'pve-itype-icon-storage';
var isUnusedDisk = key.match(/^unused\d+/);
var noedit = rec.data['delete'] || !rowdef.editor;
var order1 = rows[v1].order || 0;
var order2 = rows[v2].order || 0;
- if ((g1 - g2) !== 0) {
+ if (g1 - g2 !== 0) {
return g1 - g2;
}
- if ((order1 - order2) !== 0) {
+ if (order1 - order2 !== 0) {
return order1 - order2;
}
name: 'iconCls',
calculate: function(data) {
var txt = 'fa x-fa-tree fa-';
- txt += (data.leaf) ? 'hdd-o' : 'object-group';
+ txt += data.leaf ? 'hdd-o' : 'object-group';
return txt;
},
},
type: 'number',
name: 'usage',
calculate: function(data) {
- return ((data.size-data.free)/data.size);
+ return (data.size-data.free)/data.size;
},
},
],
disks.sort(function(a, b) {
var aorder = a.get('order') || 0;
var border = b.get('order') || 0;
- return (aorder - border);
+ return aorder - border;
});
disks.forEach(function(disk) {
// select the new item
var statechange = function(sp, key, state) {
// it the state change is for this panel
- if (stateid && (key === stateid) && state) {
+ if (stateid && key === stateid && state) {
// get active item
var acard = me.getLayout().getActiveItem().itemId;
// get the itemid of the new value
var ncard = state.value || me.firstItem;
- if (ncard && (acard != ncard)) {
+ if (ncard && acard != ncard) {
// select the chosen item
menu.setSelection(root.findChild('id', ncard, true) || root.firstChild);
}
initComponent: function() {
var me = this;
- me.isCreate = (me.cidr === undefined);
+ me.isCreate = me.cidr === undefined;
if (me.isCreate) {
let me = this.chart;
let panel = me.up();
let now = new Date().getTime();
- let begin = new Date(now - (1000 * panel.timeFrame)).getTime();
+ let begin = new Date(now - 1000 * panel.timeFrame).getTime();
me.store.add({
time: time || now,
if (key === stateid) {
var atab = me.getActiveTab().itemId;
var ntab = state.value;
- if (state && ntab && (atab != ntab)) {
+ if (state && ntab && atab != ntab) {
me.setActiveTab(ntab);
}
}
let agentRec = store.getById('agent');
let state = store.getById('status');
- me.agent = (agentRec && agentRec.data.value === 1);
- me.running = (state && state.data.value === 'running');
+ me.agent = agentRec && agentRec.data.value === 1;
+ me.running = state && state.data.value === 'running';
var caps = Ext.state.Manager.get('GuiCap');
},
isBootdev: function(dev, value) {
- return (this.isDisk(dev) && !this.isCloudinit(value)) ||
+ return this.isDisk(dev) && !this.isCloudinit(value) ||
(/^net\d+/).test(dev) ||
(/^hostpci\d+/).test(dev) ||
- ((/^usb\d+/).test(dev) && !(/spice/).test(value));
+ (/^usb\d+/).test(dev) && !(/spice/).test(value);
},
setVMConfig: function(vmconfig) {
onGetValues: function(values) {
var me = this;
- var confid = me.confid || (values.controller + values.deviceid);
+ var confid = me.confid || values.controller + values.deviceid;
me.drive.media = 'cdrom';
if (values.mediaType === 'iso') {
var ha = vm.hastate;
Ext.create('PVE.ha.VMResourceEdit', {
vmid: vmid,
- isCreate: (!ha || ha === 'unmanaged'),
+ isCreate: !ha || ha === 'unmanaged',
}).show();
},
},
return;
}
- var resume = (['prelaunch', 'paused', 'suspended'].indexOf(qmpstatus) !== -1);
+ var resume = ['prelaunch', 'paused', 'suspended'].indexOf(qmpstatus) !== -1;
if (resume || lock === 'suspended') {
startBtn.setVisible(false);
var me = this;
var params = {};
- var confid = me.confid || (values.controller + values.deviceid);
+ var confid = me.confid || values.controller + values.deviceid;
if (me.unused) {
me.drive.file = me.vmconfig[values.unusedId];
values.noreplicate = !PVE.Parser.parseBoolean(drive.replicate, 1);
values.diskformat = drive.format || 'raw';
values.cache = drive.cache || '__default__';
- values.discard = (drive.discard === 'on');
+ values.discard = drive.discard === 'on';
values.ssd = PVE.Parser.parseBoolean(drive.ssd);
values.iothread = PVE.Parser.parseBoolean(drive.iothread);
move_disk: function(disk, storage, format, delete_disk) {
var me = this;
- var qemu = (me.type === 'qemu');
+ var qemu = me.type === 'qemu';
var params = {};
params.storage = storage;
params[qemu ? 'disk':'volume'] = disk;
me.type = 'qemu';
}
- var qemu = (me.type === 'qemu');
+ var qemu = me.type === 'qemu';
var items = [
{
var rowdef = rows[key] || {};
var iconCls = rowdef.iconCls;
var icon = '';
- var txt = (rowdef.header || key);
+ var txt = rowdef.header || key;
metaData.tdAttr = "valign=middle";
sockets: {
header: gettext('Processors'),
never_delete: true,
- editor: (caps.vms['VM.Config.CPU'] || caps.vms['VM.Config.HWType'])
+ editor: caps.vms['VM.Config.CPU'] || caps.vms['VM.Config.HWType']
? 'PVE.qemu.ProcessorEdit' : undefined,
tdCls: 'pve-itype-icon-processor',
group: 3,
var order1 = rows[v1].order || 0;
var order2 = rows[v2].order || 0;
- if ((g1 - g2) !== 0) {
+ if (g1 - g2 !== 0) {
return g1 - g2;
}
- if ((order1 - order2) !== 0) {
+ if (order1 - order2 !== 0) {
return order1 - order2;
}
});
let counts = {};
- let isAtLimit = (type) => (counts[type] >= PVE.Utils.hardware_counts[type]);
+ let isAtLimit = (type) => counts[type] >= PVE.Utils.hardware_counts[type];
var set_button_status = function() {
var sm = me.getSelectionModel();
var rowdef = rows[key];
var pending = rec.data['delete'] || me.hasPendingChanges(key);
- var isCDRom = (value && !!value.toString().match(/media=cdrom/));
+ var isCDRom = value && !!value.toString().match(/media=cdrom/);
var isUnusedDisk = key.match(/^unused\d+/);
var isUsedDisk = !isUnusedDisk && rowdef.isOnStorageBus && !isCDRom;
- var isCloudInit = (value && value.toString().match(/vm-.*-cloudinit/));
+ var isCloudInit = value && value.toString().match(/vm-.*-cloudinit/);
- var isEfi = (key === 'efidisk0');
+ var isEfi = key === 'efidisk0';
- remove_btn.setDisabled(rec.data['delete'] || (rowdef.never_delete === true) || (isUnusedDisk && !diskCap));
- remove_btn.setText((isUsedDisk && !isCloudInit) ? remove_btn.altText : remove_btn.defaultText);
+ remove_btn.setDisabled(rec.data['delete'] || rowdef.never_delete === true || isUnusedDisk && !diskCap);
+ remove_btn.setText(isUsedDisk && !isCloudInit ? remove_btn.altText : remove_btn.defaultText);
remove_btn.RESTMethod = isUnusedDisk ? 'POST':'PUT';
- edit_btn.setDisabled(rec.data['delete'] || !rowdef.editor || isCloudInit || (!isCDRom && !diskCap));
+ edit_btn.setDisabled(rec.data['delete'] || !rowdef.editor || isCloudInit || !isCDRom && !diskCap);
resize_btn.setDisabled(pending || !isUsedDisk || !diskCap);
} else if (values.memory === values.balloon) {
delete res.balloon;
res['delete'] = 'balloon,shares';
- } else if (Ext.isDefined(values.shares) && (values.shares !== "")) {
+ } else if (Ext.isDefined(values.shares) && values.shares !== "") {
res.shares = values.shares;
} else {
res['delete'] = "shares";
var shares = me.down('field[name=shares]');
var memory = me.down('field[name=memory]');
bf.setDisabled(!value);
- shares.setDisabled(!value || (bf.getValue() === memory.getValue()));
+ shares.setDisabled(!value || bf.getValue() === memory.getValue());
},
},
},
ballooning: data.balloon === 0 ? '0' : '1',
shares: data.shares,
memory: data.memory || '512',
- balloon: data.balloon > 0 ? data.balloon : (data.memory || '512'),
+ balloon: data.balloon > 0 ? data.balloon : data.memory || '512',
};
ipanel.setValues(values);
xtype: 'proxmoxcheckbox',
fieldLabel: gettext('Firewall'),
name: 'firewall',
- checked: (me.insideWizard || me.isCreate),
+ checked: me.insideWizard || me.isCreate,
},
];
var child = Ext.clone(me[settings.parent]);
me[settings.pveOS] = Ext.apply(child, settings);
} else {
- throw ("Could not find your genitor");
+ throw "Could not find your genitor";
}
};
me.rstore = Ext.create('Proxmox.data.ObjectStore', {
interval: me.interval,
model: 'pve-sdn-status',
- storeid: 'pve-store-' + (++Ext.idSeed),
+ storeid: 'pve-store-' + ++Ext.idSeed,
groupField: 'type',
proxy: {
type: 'proxmox',
sorterFn: function(rec1, rec2) {
var p1 = me.sortPriority[rec1.data.type];
var p2 = me.sortPriority[rec2.data.type];
- return (p1 !== p2) ? ((p1 > p2) ? 1 : -1) : 0;
+ return p1 !== p2 ? p1 > p2 ? 1 : -1 : 0;
},
}],
filters: {
},
setValues: function(values) {
- values.luns = (values.content.indexOf('images') !== -1);
+ values.luns = values.content.indexOf('images') !== -1;
this.callParent([values]);
},
throw "no storage ID specified";
}
- if (!me.content || (me.content !== 'images' && me.content !== 'rootdir')) {
+ if (!me.content || me.content !== 'images' && me.content !== 'rootdir') {
throw "content needs to be either 'images' or 'rootdir'";
}
var value = field.getValue().toLowerCase();
store.clearFilter(true);
store.filterBy(function(rec) {
- return (rec.data['package'].toLowerCase().indexOf(value) !== -1) ||
- (rec.data.headline.toLowerCase().indexOf(value) !== -1);
+ return rec.data['package'].toLowerCase().indexOf(value) !== -1 ||
+ rec.data.headline.toLowerCase().indexOf(value) !== -1;
});
},
},
var n1 = node1.data;
var n2 = node2.data;
- if ((n1.groupbyid && n2.groupbyid) ||
+ if (n1.groupbyid && n2.groupbyid ||
!(n1.groupbyid || n2.groupbyid)) {
var tcmp;
var v1 = n1.type;
var v2 = n2.type;
- if ((tcmp = v1 > v2 ? 1 : (v1 < v2 ? -1 : 0)) != 0) {
+ if ((tcmp = v1 > v2 ? 1 : v1 < v2 ? -1 : 0) != 0) {
return tcmp;
}
}
v1 = n1.vmid;
v2 = n2.vmid;
- if ((tcmp = v1 > v2 ? 1 : (v1 < v2 ? -1 : 0)) != 0) {
+ if ((tcmp = v1 > v2 ? 1 : v1 < v2 ? -1 : 0) != 0) {
return tcmp;
}
}
- return n1.id > n2.id ? 1 : (n1.id < n2.id ? -1 : 0);
+ return n1.id > n2.id ? 1 : n1.id < n2.id ? -1 : 0;
} else if (n1.groupbyid) {
return -1;
} else if (n2.groupbyid) {
var sm = me.getSelectionModel();
// disable selection when right clicking
// except the record is already selected
- me.allowSelection = (ev.button !== 2) || sm.isSelected(record);
+ me.allowSelection = ev.button !== 2 || sm.isSelected(record);
},
beforeselect: function(tree, record, index, eopts) {
var allow = me.allowSelection;
});
var title = gettext('Backup') + " " +
- ((me.vmtype === 'lxc') ? "CT" : "VM") +
+ (me.vmtype === 'lxc' ? "CT" : "VM") +
" " + me.vmid;
Ext.apply(me, {
selectionchange: function(vmselector, records) {
if (me.action == 'migrateall') {
var showWarning = records.some(function(item) {
- return (item.data.type == 'lxc' &&
- item.data.status == 'running');
+ return item.data.type == 'lxc' &&
+ item.data.status == 'running';
});
me.down('#lxcwarning').setVisible(showWarning);
}
name: 'storage',
value: '',
fieldLabel: gettext('Storage'),
- storageContent: (me.vmtype === 'lxc') ? 'rootdir' : 'images',
+ storageContent: me.vmtype === 'lxc' ? 'rootdir' : 'images',
// when restoring a container without specifying a storage, the backend defaults
// to 'local', which is unintuitive and 'rootdir' might not even be allowed on it
allowBlank: me.vmtype !== 'lxc',
- emptyText: (me.vmtype === 'lxc') ? '' : gettext('From backup configuration'),
+ emptyText: me.vmtype === 'lxc' ? '' : gettext('From backup configuration'),
autoSelect: me.vmtype === 'lxc',
});
IDfield = Ext.create('Ext.form.field.Display', {
name: 'vmid',
value: me.vmid,
- fieldLabel: (me.vmtype === 'lxc') ? 'CT' : 'VM',
+ fieldLabel: me.vmtype === 'lxc' ? 'CT' : 'VM',
});
} else {
IDfield = Ext.create('PVE.form.GuestIDSelector', {
});
var title = gettext('Restore') + ": " + (
- (me.vmtype === 'lxc') ? 'CT' : 'VM');
+ me.vmtype === 'lxc' ? 'CT' : 'VM');
if (me.vmid) {
title += " " + me.vmid;
projects / pve-manager.git / commitdiff