]> git.proxmox.com Git - mirror_zfs.git/commitdiff
Fix coverity defects
authorBearBabyLiu <liu.huang@zte.com.cn>
Wed, 21 Sep 2016 02:09:22 +0000 (10:09 +0800)
committerBrian Behlendorf <behlendorf1@llnl.gov>
Wed, 21 Sep 2016 02:09:22 +0000 (19:09 -0700)
coverity scan CID:147504 Type: Explicit null dereferenced
Reason: passing null pointer dl to zfs_dirent_unlock

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: BearBabyLiu <liu.huang@zte.com.cn>
Closes #5131

module/zfs/zfs_vnops.c

index 405b37c1925d6e555b9365ea9aa9794e199bf45d..796cd1e342c4788508c2502503074127392427fe 100644 (file)
@@ -1470,8 +1470,10 @@ top:
                if (S_ISREG(ZTOI(zp)->i_mode) &&
                    (vap->va_mask & ATTR_SIZE) && (vap->va_size == 0)) {
                        /* we can't hold any locks when calling zfs_freesp() */
-                       zfs_dirent_unlock(dl);
-                       dl = NULL;
+                       if (dl) {
+                               zfs_dirent_unlock(dl);
+                               dl = NULL;
+                       }
                        error = zfs_freesp(zp, 0, 0, mode, TRUE);
                }
        }