]> git.proxmox.com Git - mirror_edk2.git/commitdiff
CryptoPkg/TlsLib: Remove the redundant free of BIO objects
authorJiaxin Wu <jiaxin.wu@intel.com>
Mon, 31 Jul 2017 05:29:40 +0000 (13:29 +0800)
committerJiaxin Wu <jiaxin.wu@intel.com>
Wed, 2 Aug 2017 07:31:46 +0000 (15:31 +0800)
TLS BIO objects (InBio/OutBio) will be freed by SSL_free() function.
So, the following free operation (BIO_free) in TlsFree is redundant.
It can be removed directly.

Cc: Ye Ting <ting.ye@intel.com>
Cc: Long Qin <qin.long@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
Reviewed-by: Long Qin <qin.long@intel.com>
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
CryptoPkg/Library/TlsLib/TlsInit.c

index e2c9744a44b961fbcfc5efbcf60645fb5c466630..e524647103f96d0f47cb11d9485bc54b0109d3e3 100644 (file)
@@ -130,20 +130,12 @@ TlsFree (
   }\r
 \r
   //\r
-  // Free the internal TLS and BIO objects.\r
+  // Free the internal TLS and related BIO objects.\r
   //\r
   if (TlsConn->Ssl != NULL) {\r
     SSL_free (TlsConn->Ssl);\r
   }\r
 \r
-  if (TlsConn->InBio != NULL) {\r
-    BIO_free (TlsConn->InBio);\r
-  }\r
-\r
-  if (TlsConn->OutBio != NULL) {\r
-    BIO_free (TlsConn->OutBio);\r
-  }\r
-\r
   OPENSSL_free (Tls);\r
 }\r
 \r