zfs: get: only accept whole source for -s, not src[=whatever]

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes #12996

diff --git a/cmd/zfs/zfs_main.c b/cmd/zfs/zfs_main.c
index 5d7599d3e062830009a947286c7298776cf35501..b7a26242b02072dd46fca4b76f4e75d5ef816976 100644 (file)
--- a/cmd/zfs/zfs_main.c
+++ b/cmd/zfs/zfs_main.c
@@ -2088,38 +2088,27 @@ found:
 
                case 's':
                        cb.cb_sources = 0;
-                       while (*optarg != '\0') {
-                               static char *source_subopts[] = {
-                                       "local", "default", "inherited",
-                                       "received", "temporary", "none",
-                                       NULL };
 
-                               switch (getsubopt(&optarg, source_subopts,
-                                   &value)) {
-                               case 0:
-                                       cb.cb_sources |= ZPROP_SRC_LOCAL;
-                                       break;
-                               case 1:
-                                       cb.cb_sources |= ZPROP_SRC_DEFAULT;
-                                       break;
-                               case 2:
-                                       cb.cb_sources |= ZPROP_SRC_INHERITED;
-                                       break;
-                               case 3:
-                                       cb.cb_sources |= ZPROP_SRC_RECEIVED;
-                                       break;
-                               case 4:
-                                       cb.cb_sources |= ZPROP_SRC_TEMPORARY;
-                                       break;
-                               case 5:
-                                       cb.cb_sources |= ZPROP_SRC_NONE;
-                                       break;
-                               default:
-                                       (void) fprintf(stderr,
-                                           gettext("invalid source "
-                                           "'%s'\n"), value);
-                                       usage(B_FALSE);
-                               }
+                       for (char *tok; (tok = strsep(&optarg, ",")); ) {
+                               static const char *const source_opt[] = {
+                                       "local", "default",
+                                       "inherited", "received",
+                                       "temporary", "none" };
+                               static const int source_flg[] = {
+                                       ZPROP_SRC_LOCAL, ZPROP_SRC_DEFAULT,
+                                       ZPROP_SRC_INHERITED, ZPROP_SRC_RECEIVED,
+                                       ZPROP_SRC_TEMPORARY, ZPROP_SRC_NONE };
+
+                               for (i = 0; i < ARRAY_SIZE(source_opt); ++i)
+                                       if (strcmp(tok, source_opt[i]) == 0) {
+                                               cb.cb_sources |= source_flg[i];
+                                               goto found2;
+                                       }
+
+                               (void) fprintf(stderr,
+                                   gettext("invalid source '%s'\n"), tok);
+                               usage(B_FALSE);
+found2:;
                        }
                        break;