]> git.proxmox.com Git - mirror_edk2.git/commitdiff
SecurityPkg/FvReportPei: remove redundant sizeof
authorWenyi Xie <xiewenyi2@huawei.com>
Wed, 14 Apr 2021 01:43:50 +0000 (09:43 +0800)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Fri, 16 Apr 2021 08:39:59 +0000 (08:39 +0000)
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3333

In function InstallPreHashFvPpi, when calculating the size
of struct HASH_INFO, sizeof is used twice. This bug does
not lead to buffer overflow, "sizeof (HASH_INFO)" is 4,
whereas "sizeof (sizeof (HASH_INFO))" is 4 or 8.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jian J Wang <jian.j.wang@intel.com>
Acked-by: Jiewen Yao <Jiewen.yao@intel.com>
SecurityPkg/FvReportPei/FvReportPei.c

index d709760ea3ce783465d5f116037406a54714bf68..e82413e090c0b2c6c29b8ca3108c1bebd9627e5d 100644 (file)
@@ -67,7 +67,7 @@ InstallPreHashFvPpi (
   HASH_INFO                                         *HashInfo;\r
 \r
   PpiSize = sizeof (EDKII_PEI_FIRMWARE_VOLUME_INFO_PREHASHED_FV_PPI)\r
-            + sizeof (sizeof (HASH_INFO))\r
+            + sizeof (HASH_INFO)\r
             + HashSize;\r
 \r
   PreHashedFvPpi = AllocatePool (PpiSize);\r