DynamicTablesPkg: Fix Ssdt PCI generation comments

The second model of the _PRT object is used. Indeed:
- the interrupts described are not re-configurable
- OSes are aware of the polarity of PCI legacy interrupts,
  so there is no need to accurately describe the polarity.

Also, fix a comment for the CM_ARM_PCI_INTERRUPT_MAP_INFO obj.

Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

diff --git a/DynamicTablesPkg/Include/ArmNameSpaceObjects.h b/DynamicTablesPkg/Include/ArmNameSpaceObjects.h
index cd39e609d6c4426673ca4fad85d889e449d36e72..d711f3ec59380878158e69389226c868cda42f30 100644 (file)
--- a/DynamicTablesPkg/Include/ArmNameSpaceObjects.h
+++ b/DynamicTablesPkg/Include/ArmNameSpaceObjects.h
@@ -1014,7 +1014,7 @@ typedef struct CmArmPciInterruptMapInfo {
   /// Value on 8 bits (max 255).\r
   UINT8    PciBus;\r
 \r
-  /// Pci Bus.\r
+  /// Pci Device.\r
   /// Value on 5 bits (max 31).\r
   UINT8    PciDevice;\r
 \r

diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c
index 85098752c614f6556ee768fd79a11ea316c0b5d4..c54ae6f551f684bf0c8ba713a53c54d7220f4e71 100644 (file)
--- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c
+++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c
@@ -288,12 +288,6 @@ GeneratePciDeviceInfo (
 \r
   Cf. ACPI 6.4 specification, s6.2.13 "_PRT (PCI Routing Table)"\r
 \r
-  The first model (defining a _CRS object) is used. This is necessary because\r
-  PCI legacy interrupts are active low and GICv2 SPI interrupts are active\r
-  high.\r
-  Even though PCI interrupts cannot be re-routed, only the first model allows\r
-  to specify the activation state (low/high).\r
-\r
   @param [in]       Generator       The SSDT Pci generator.\r
   @param [in]       CfgMgrProtocol  Pointer to the Configuration Manager\r
                                     Protocol interface.\r
@@ -397,6 +391,8 @@ GeneratePrt (
        High word-Device #, Low word-Function #. (for example, device 3,\r
        function 2 is 0x00030002). To refer to all the functions on a device #,\r
        use a function number of FFFF).\r
+\r
+      Use the second model for _PRT object and describe a hardwired interrupt.\r
     */\r
     Status = AmlAddPrtEntry (\r
                (IrqMapInfo->PciDevice << 16) | 0xFFFF,\r