cppcheck: explicitly exclude kernel code from userspace checks

Thus extracting the final shred of utility

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes #13316

diff --git a/config/CppCheck.am b/config/CppCheck.am
index 0c2502f3dddee49a7128a161b8330f074d668334..89a067d814ff1a296af07c283ac844999846b031 100644 (file)
--- a/config/CppCheck.am
+++ b/config/CppCheck.am
@@ -1,5 +1,5 @@
 #
-# Default rules for running cppcheck against the user space components.
+# cppcheck for userspace – nodist_*_SOURCES are kernel code and cppcheck goes crazy on them.
 #
 
 PHONY += cppcheck
@@ -15,7 +15,7 @@ cppcheck-recursive-%:
 
 _CTGT = $(subst cppcheck-for-,,$@)
 cppcheck-for-%:
-       @[ -n "$($(_CTGT)_SOURCES)$(dist_$(_CTGT)_SOURCES)$(nodist_$(_CTGT)_SOURCES)" ]
-       $(CPPCHECK) -j$(CPU_COUNT) $(CPPCHECKFLAGS) $(patsubst -U%,,$(patsubst -D%,,$(filter-out $(AM_CPPFLAGS_NOCHECK),$(or $($(_CTGT)_CPPFLAGS),$(AM_CPPFLAGS))))) $($(_CTGT)_SOURCES) $(dist_$(_CTGT)_SOURCES) $(nodist_$(_CTGT)_SOURCES)
+       @[ -n "$($(_CTGT)_SOURCES)$(dist_$(_CTGT)_SOURCES)" ]
+       $(CPPCHECK) -j$(CPU_COUNT) $(CPPCHECKFLAGS) $(patsubst -U%,,$(patsubst -D%,,$(filter-out $(AM_CPPFLAGS_NOCHECK),$(or $($(_CTGT)_CPPFLAGS),$(AM_CPPFLAGS))))) $($(_CTGT)_SOURCES) $(dist_$(_CTGT)_SOURCES)
 
 cppcheck: $(addprefix cppcheck-for-,$(subst -,_,$(subst .,_,$(subst /,_,$(CPPCHECKTARGETS))))) $(addprefix cppcheck-recursive-,$(CPPCHECKDIRS))

diff --git a/lib/libavl/Makefile.am b/lib/libavl/Makefile.am
index 5eaf4c08728d505097eb2bc90de7cb64834a9bf5..3b302ee9deaebdc5c8604980aefbe8749afb1f5a 100644 (file)
--- a/lib/libavl/Makefile.am
+++ b/lib/libavl/Makefile.am
@@ -2,7 +2,6 @@ libavl_la_CFLAGS  = $(AM_CFLAGS) $(KERNEL_CFLAGS) $(LIBRARY_CFLAGS)
 libavl_la_CFLAGS += -fvisibility=hidden
 
 noinst_LTLIBRARIES += libavl.la
-CPPCHECKTARGETS    += libavl.la
 
 nodist_libavl_la_SOURCES = \
        module/avl/avl.c

diff --git a/lib/libicp/Makefile.am b/lib/libicp/Makefile.am
index 00bfc5c36ae97982680efde097729b3dac3b9739..304f49e39005580100d43fdb8b893dc7df83ae94 100644 (file)
--- a/lib/libicp/Makefile.am
+++ b/lib/libicp/Makefile.am
@@ -2,7 +2,6 @@ libicp_la_CCASFLAGS = $(AM_CCASFLAGS)
 libicp_la_CFLAGS    = $(AM_CFLAGS) $(KERNEL_CFLAGS) $(LIBRARY_CFLAGS)
 
 noinst_LTLIBRARIES += libicp.la
-CPPCHECKTARGETS    += libicp.la
 
 nodist_libicp_la_SOURCES = \
        module/icp/spi/kcf_spi.c \

diff --git a/lib/libunicode/Makefile.am b/lib/libunicode/Makefile.am
index 82fee0101346b175104035f58faff3798ccacb01..90675947116330ba67d03578fd8b6e42b4dc27a5 100644 (file)
--- a/lib/libunicode/Makefile.am
+++ b/lib/libunicode/Makefile.am
@@ -1,7 +1,6 @@
 libunicode_la_CFLAGS = $(AM_CFLAGS) $(KERNEL_CFLAGS) $(LIBRARY_CFLAGS)
 
 noinst_LTLIBRARIES += libunicode.la
-CPPCHECKTARGETS    += libunicode.la
 
 nodist_libunicode_la_SOURCES = \
        module/unicode/u8_textprep.c \

diff --git a/lib/libzstd/Makefile.am b/lib/libzstd/Makefile.am
index 729856862644a875ac7edc69aad13dfc5cdf2902..49bfb328a6f7272a6376bfc7c958304437273e2d 100644 (file)
--- a/lib/libzstd/Makefile.am
+++ b/lib/libzstd/Makefile.am
@@ -4,7 +4,6 @@ libzstd_la_CFLAGS  = $(AM_CFLAGS) $(LIBRARY_CFLAGS)
 libzstd_la_CFLAGS += -fno-tree-vectorize
 
 noinst_LTLIBRARIES += libzstd.la
-CPPCHECKTARGETS    += libzstd.la
 
 nodist_libzstd_la_SOURCES = \
        module/zstd/lib/common/entropy_common.c \