Enhance the code to make the code logic more clear.

Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13650 6f19259b-4bc3-4df7-8a09-765794883524

diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c
index 8aced87c85e0febdfbaf7e55c70d967e9b1a5ffc..79829e6643dc58acfb170aeab7b6021e35e5ae2e 100644 (file)
--- a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c
+++ b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c
@@ -815,7 +815,7 @@ GetToken (
 \r
   String = HiiGetString (HiiHandle, Token, NULL);\r
   if (String == NULL) {\r
-    String = AllocateCopyPool (sizeof (mUnknownString), mUnknownString);\r
+    String = AllocateCopyPool (StrSize (mUnknownString), mUnknownString);\r
     ASSERT (String != NULL);\r
   }\r
   return (CHAR16 *) String;\r
@@ -3269,7 +3269,7 @@ ExtractDefault (
       //\r
       // Initilize Questions' Value\r
       //\r
-      LoadFormSetConfig (NULL, LocalFormSet);\r
+      Status = LoadFormSetConfig (NULL, LocalFormSet);\r
       if (EFI_ERROR (Status)) {\r
         DestroyFormSet (LocalFormSet);\r
         continue;\r

diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Ui.c b/MdeModulePkg/Universal/SetupBrowserDxe/Ui.c
index f48afbf66c68d839dedcc41c7d9bf1643443df22..f3019a84084b2a5d261ff522d75c7cb011061198 100644 (file)
--- a/MdeModulePkg/Universal/SetupBrowserDxe/Ui.c
+++ b/MdeModulePkg/Universal/SetupBrowserDxe/Ui.c
@@ -957,6 +957,9 @@ CreateDialog (
           TempString[Index - 1] = CHAR_NULL;\r
           StrCpy (StringBuffer, TempString);\r
         }\r
+        //\r
+        // break skipped on purpose\r
+        //\r
 \r
       default:\r
         //\r

diff --git a/MdePkg/Library/BasePrintLib/PrintLibInternal.c b/MdePkg/Library/BasePrintLib/PrintLibInternal.c
index 8a0cfa6e20e4737f65e9a4e52af3ebbec70cee74..34e9d1276782a089e5146da0a3d4dcc7c0eec744 100644 (file)
--- a/MdePkg/Library/BasePrintLib/PrintLibInternal.c
+++ b/MdePkg/Library/BasePrintLib/PrintLibInternal.c
@@ -517,6 +517,9 @@ BasePrintLibSPrintMarker (
         if (sizeof (VOID *) > 4) {\r
           Flags |= LONG_TYPE;\r
         }\r
+        //\r
+        // break skipped on purpose\r
+        //\r
       case 'X':\r
         Flags |= PREFIX_ZERO;\r
         //\r