]> git.proxmox.com Git - mirror_edk2.git/commitdiff
BaseTools/GenFfs: Optimazing else if statement
authorwenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
Tue, 15 Dec 2020 06:30:46 +0000 (14:30 +0800)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Tue, 22 Dec 2020 03:31:36 +0000 (03:31 +0000)
When Alignment < 0x400 is false, the expression of Alignment >= 0x400 is
always true. So extract the expression from the else if statement.

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
BaseTools/Source/C/GenFfs/GenFfs.c

index fcb911f4fc34e560fd06001f91ddc1afde71273c..949025c333251bc5776159a6c5355ea29e4ef987 100644 (file)
@@ -821,12 +821,11 @@ Returns:
           if (Alignment < 0x400){\r
             sprintf (AlignmentBuffer, "%d", Alignment);\r
           }\r
-          else if (Alignment >= 0x400) {\r
-            if (Alignment >= 0x100000) {\r
-              sprintf (AlignmentBuffer, "%dM", Alignment/0x100000);\r
-            } else {\r
-              sprintf (AlignmentBuffer, "%dK", Alignment/0x400);\r
-            }\r
+          else if (Alignment >= 0x100000) {\r
+            sprintf (AlignmentBuffer, "%dM", Alignment/0x100000);\r
+          }\r
+          else {\r
+            sprintf (AlignmentBuffer, "%dK", Alignment/0x400);\r
           }\r
           Status = StringtoAlignment (AlignmentBuffer, &(InputFileAlign[InputFileNum]));\r
         }\r