]> git.proxmox.com Git - mirror_zfs.git/commitdiff
expose snapshot count via stat(2) of .zfs/snapshot (#13559)
authorAndrew <awalker@ixsystems.com>
Fri, 17 Jun 2022 18:44:49 +0000 (13:44 -0500)
committerGitHub <noreply@github.com>
Fri, 17 Jun 2022 18:44:49 +0000 (11:44 -0700)
Increase nlinks in stat results of ./zfs/snapshot based on snapshot
count. This provides quick and efficient method for administrators to
get snapshot counts without having to use libzfs or list the snapdir
contents.

Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Andrew Walker <awalker@ixsystems.com>
Closes #13559

module/os/linux/zfs/zpl_ctldir.c

index f4e1ab7aef08e4c425a3ff8583ee32f475ba50da..d5c222120a9db1393cddd5c8412ae8fc53f59f71 100644 (file)
@@ -32,6 +32,9 @@
 #include <sys/zfs_vnops.h>
 #include <sys/zfs_ctldir.h>
 #include <sys/zpl.h>
+#include <sys/dmu.h>
+#include <sys/dsl_dataset.h>
+#include <sys/zap.h>
 
 /*
  * Common open routine.  Disallow any write access.
@@ -411,6 +414,20 @@ zpl_snapdir_getattr_impl(const struct path *path, struct kstat *stat,
 #endif
 
        stat->nlink = stat->size = 2;
+
+       dsl_dataset_t *ds = dmu_objset_ds(zfsvfs->z_os);
+       if (dsl_dataset_phys(ds)->ds_snapnames_zapobj != 0) {
+               uint64_t snap_count;
+               int err = zap_count(
+                   dmu_objset_pool(ds->ds_objset)->dp_meta_objset,
+                   dsl_dataset_phys(ds)->ds_snapnames_zapobj, &snap_count);
+               if (err != 0) {
+                       ZPL_EXIT(zfsvfs);
+                       return (-err);
+               }
+               stat->nlink += snap_count;
+       }
+
        stat->ctime = stat->mtime = dmu_objset_snap_cmtime(zfsvfs->z_os);
        stat->atime = current_time(ip);
        ZPL_EXIT(zfsvfs);