UnitTestFrameworkPkg/UnitTestLib: Fix XCODE parenthesis issues

https://bugzilla.tianocore.org/show_bug.cgi?id=2512

Remove extra sets of parenthesis that generate warnings on XCODE5
builds.

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
Reviewed-by: Sean Brogan <sean.brogan@microsoft.com>

diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c b/UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c
index dd85b84b08067228c9d282c1d6dbd07a9324c027..c327ba88f105bbb1344f9fccce23f71ff585a39a 100644 (file)
--- a/UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c
@@ -247,7 +247,7 @@ UnitTestAssertEqual (
   IN CONST CHAR8  *DescriptionB\r
   )\r
 {\r
-  if ((ValueA != ValueB)) {\r
+  if (ValueA != ValueB) {\r
     UnitTestLogFailure (\r
       FAILURETYPE_ASSERTEQUAL,\r
       "%a::%d Value %a != %a (%d != %d)!\n",\r
@@ -365,7 +365,7 @@ UnitTestAssertNotEqual (
   IN CONST CHAR8  *DescriptionB\r
   )\r
 {\r
-  if ((ValueA == ValueB)) {\r
+  if (ValueA == ValueB) {\r
     UnitTestLogFailure (\r
       FAILURETYPE_ASSERTNOTEQUAL,\r
       "%a::%d Value %a == %a (%d == %d)!\n",\r
@@ -420,7 +420,7 @@ UnitTestAssertStatusEqual (
   IN CONST CHAR8  *Description\r
   )\r
 {\r
-  if ((Status != Expected)) {\r
+  if (Status != Expected) {\r
     UnitTestLogFailure (\r
       FAILURETYPE_ASSERTSTATUSEQUAL,\r
       "%a::%d Status '%a' is %r, should be %r!\n",\r

diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/Log.c b/UnitTestFrameworkPkg/Library/UnitTestLib/Log.c
index 78df086a28d6e23a054ae60962d33845fa6c53c3..ac4e229b40716afb28938882487666c8007ec44f 100644 (file)
--- a/UnitTestFrameworkPkg/Library/UnitTestLib/Log.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestLib/Log.c
@@ -136,7 +136,7 @@ UnitTestLogInit (
     return;\r
   }\r
 \r
-  if((Buffer != NULL) && (BufferSize > 0) && ((BufferSize <= UNIT_TEST_MAX_LOG_BUFFER))) {\r
+  if((Buffer != NULL) && (BufferSize > 0) && (BufferSize <= UNIT_TEST_MAX_LOG_BUFFER)) {\r
     CopyMem (Test->Log, Buffer, BufferSize);\r
   }\r
 }\r