target-s390: Convert TEST DATA CLASS

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert MULTIPLY AND ADD, SUBTRACT

Use the new float*_muladd interface to softfloat.

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert FP MULTIPLY

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert FP DIVIDE

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert FP SUBTRACT

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert FP ADD, COMPARE, LOAD TEST/ROUND/LENGTHENED

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert LLGT

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert STORE REVERSED

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert LOAD REVERSED

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert LOAD CONTROL, part 2

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert TPROT

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert STCM

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert CLM

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert COMPARE AND SWAP

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert LCTL, STCTL

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert EFPC, STFPC

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert SIGP

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert LRA

Note that truncating the store to r1 based on PSW_MASK_64
is incorrect.  We always modify the entire register.

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert MVCP, MVCS

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert CLC

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert NC, XC, OC, TR, UNPK

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert MVC

The code that was in gen_op_mvc was a bit confused wrt what lengths
it wanted to handle.  I also disbelieve that the inline memset is
worthwhile.

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert CLCLE, MVCLE

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert LAM, STAM

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert STNSM, STOSM

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert NI, XI, OI

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert MOVE

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert LOAD, STORE MULTIPLE

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert SHIFT DOUBLE

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert SHIFT, ROTATE SINGLE

Note that we were missing the 32-bit SLA.

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert DIAGNOSE

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert LOAD PSW

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert SET SYSTEM MASK

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert CONVERT TO DECIMAL

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert FP STORE

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert EXECUTE

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert INSERT CHARACTERS UNDER MASK

Change the CC handling to be more like TEST UNDER MASK, with val & mask.
This lets us handle ICMH much more like ICM.

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Cleanup cc computation helpers

The inline markers hid the fact that {n}abs_32 were unused
because of typos in the main do_calc_cc function.  Let the
compiler handle auto-inlining here.

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert INSERT CHARACTER

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert FP LOAD

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert MOVE LONG

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert SUPERVISOR CALL

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert SET ADDRESSING MODE

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert TEST UNDER MASK

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Send signals for divide

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert DIVIDE

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert BRANCH ON COUNT

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert BRANCH ON CONDITION

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert BRANCH AND SAVE

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert ADD LOGICAL CARRY and SUBTRACT LOGICAL BORROW

I'm resonably certain that the carry/borrow-out condition for both
helpers was incorrect, failing to take into account the carry-in.
Adding the new CC_OP codes also allows removing the awkward interface
we used for the slb helpers.

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert STORE

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert AND, OR, XOR, INSERT IMMEDIATE

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert LOAD COMPLIMENT, POSITIVE, NEGATIVE

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert LOAD LOGICAL IMMEDIATE

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert LOAD AND TEST

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert LOAD (LOGICAL) BYTE, CHARACTER, HALFWORD

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert LOAD ADDRESS

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert LOAD, LOAD LOGICAL

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert COMPARE, COMPARE LOGICAL

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert AND, OR, XOR

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert 64-bit MULTIPLY LOGICAL

Use a new "retxl" member of CPUS290XState to return the "eXtra Low" part
of a 128-bit value.  That said, this will get used when two independent
values need returning (e.g. quotient+remainder) as well.

At the same time, shuffle the elements of CPUS390XState to get this new
space from existing padding in the structure.

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert 32-bit MULTIPLY, MULTIPLY LOGICAL

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert MULTIPLY HALFWORD, SINGLE

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Implement ADD LOGICAL WITH SIGNED IMMEDIATE

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Implement SUBTRACT HALFWORD

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Convert ADD HALFWORD

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Reorg exception handling

Make the user path more like the system path.  Prepare for more kinds
of runtime exceptions.  Rename ILC to ILEN to make it clear that we
want to pass around a full instruction length, rather than a "code"
that happens to be stored one bit left in a larger field.

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Split out disas_jcc

Lots of duplicated code replaced with a couple of tables.  We no longer
attempt to manually invert the logic operation: the comments now match
the code.  In the fully general test, constant propagate (1 << (3 - cc))
into (8 >> cc).

The new function will be usable by non-branch insns as well.

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Add format based disassassmbly infrastructure

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Fix PSW_MASK handling

We were treating psw.mask as the 32-bit quantity it is in ESA mode.
In particular, the CC field was at the wrong place.

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Tidy unconditional BRCL

Yes, we're about to rewrite all of this, but having this unconditional
jump recompute cc_op is a large source of "false diff errors" when
trying to examine before and after dumps.

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Fix BCR

There were are two exit paths for which we forgot to
copy s->cc_op back to the tcg register.

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Fix SACF exit

DISAS_EXCP is exit via exception; we wanted DISAS_JUMP.
This matters when we start cleaning up the TB exit paths.

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Register helpers

Which highlights a lot of cc helpers that no longer exist.

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Use TCG registers for FPR

At the same time, tidy other usages of tcg_gen_deposit_i64.
In some cases we can "type cast" rather than extend, and in
others we can allow tcg_gen_deposit_i64 itself to optimize
the HOST_LONG_BITS==32 case.

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Add missing temp_free in gen_op_calc_cc

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Fix gdbstub

The real gdb protocol doesn't split out pc or cc as real registers.
Those are pseudos that are extracted as needed from the PSW.  Don't
modify env->cc_op during read -- that way lies heisenbugs.

Fill in the XXX for the fp registers.

Remove duplicated defines in cpu.h.

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Fix disassembly of cpsdr

Signed-off-by: Richard Henderson <rth@twiddle.net>

target-s390: Disassemble more z10 and z196 opcodes

Also fix disassembly for COMPARE AND BRANCH.  The table must be
sorted by primary opcode, and several were out of place.

Signed-off-by: Richard Henderson <rth@twiddle.net>

hw/i386: Fix broken build for non POSIX hosts

pc-testdev.c cannot be compiled with MinGW (and other non POSIX hosts):

  CC    i386-softmmu/hw/i386/../pc-testdev.o
qemu/hw/i386/../pc-testdev.c:38:22: warning: sys/mman.h: file not found
qemu/hw/i386/../pc-testdev.c: In function ‘test_flush_page’:
qemu/hw/i386/../pc-testdev.c:103: warning: implicit declaration of function ‘mprotect’
...

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>

softfloat: Implement uint64_to_float128

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>

softfloat: Fix uint64_to_float64

The interface to normalizeRoundAndPackFloat64 requires that the
high bit be clear.  Perform one shift-right-and-jam if needed.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>

Merge remote-tracking branch 'stefanha/trivial-patches' into staging

* stefanha/trivial-patches:
  spice: drop incorrect vm_change_state_handler() opaque
  linux-user/syscall.c: remove forward declarations
  hw/mcf5206: Reduce size of lookup table
  Remove --sparc_cpu option from the configure list
  pseries: Remove unneeded include statement (fixes MinGW builds)
  pc_sysfw: Check for qemu_find_file() failure

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

Merge remote-tracking branch 'kraxel/testdev.1' into staging

* kraxel/testdev.1:
  pc: remove bochs bios debug ports
  hw: Add test device for unittests execution
  add isa-debug-exit device.
  switch debugcon to memory api

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

Merge remote-tracking branch 'kraxel/acpi.2' into staging

* kraxel/acpi.2:
  apci: assign memory regions to ich9 lpc device
  apci: assign memory regions to piix4 acpi device
  acpi: autoload dsdt
  configure: also symlink *.aml files

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

spice: drop incorrect vm_change_state_handler() opaque

The spice_server pointer is a global variable and
vm_change_state_handler() therefore does not use its opaque parameter.

The vm change state handler is added with a pointer to the spice_server
pointer.  This is useless and we probably would not want 2 levels of
pointers.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Uri Lublin <uril@redhat.com>

linux-user/syscall.c: remove forward declarations

instead use the correct headers that define these functions.

Requested-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: John Spencer <maillist-qemu@barfooze.de>
Reviewed-by: Amos Kong <kongjianjun@gmail.com>
Reviewed-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

hw/mcf5206: Reduce size of lookup table

This typically reduces the size from 512 bytes to 128 bytes.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

Remove --sparc_cpu option from the configure list

  commit 9b9c37c36439ee0452632253dac7a31897f27f70 always assume sparcv9,
the others are no longer supported. Remove --sparc_cpu option from the
configure list.

Signed-off-by: Chen Wei-Ren <chenwj@iis.sinica.edu.tw>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

pseries: Remove unneeded include statement (fixes MinGW builds)

sys/mman.h is not needed (tested on Linux) and unavailable for MinGW,
so remove it.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

pc_sysfw: Check for qemu_find_file() failure

pc_fw_add_pflash_drv() ignores qemu_find_file() failure, and happily
creates a drive without a medium.

When pc_system_flash_init() asks for its size, bdrv_getlength() fails
with -ENOMEDIUM, which isn't checked either.  It fails relatively
cleanly only because -ENOMEDIUM isn't a multiple of 4096:

    $ qemu-system-x86_64 -S -vnc :0 -bios nonexistant
    qemu: PC system firmware (pflash) must be a multiple of 0x1000
    [Exit 1 ]

Fix by handling the qemu_find_file() failure.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

pc: remove bochs bios debug ports

Prehistoric leftover, zap it.  We poweroff via acpi these days.

And having a port (0x501,0x502) where any random guest write will make
qemu exit -- with no way to turn it off -- is a bad joke anyway.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

hw: Add test device for unittests execution

Add a test device which supports the kvmctl ioports,
so one can run the KVM unittest suite.

Intended Usage:

qemu-system-x86_64 -nographic \
    -device pc-testdev \
    -device isa-debug-exit,iobase=0xf4,iosize=0x04 \
    -kernel /path/to/kvm/unittests/msr.flat

Where msr.flat is one of the KVM unittests, present on a
separate repo,

git://git.kernel.org/pub/scm/virt/kvm/kvm-unit-tests.git

[ kraxel: more memory api + qom fixes ]

CC: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Alexander Graf <agraf@suse.de>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

add isa-debug-exit device.

When present it makes qemu exit on any write.
Mapped to port 0x501 by default.

Without this patch Anthony doesn't allow me to
remove the bochs bios debug ports because his
test suite uses this.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

switch debugcon to memory api

Also some QOM glue while being at it.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

apci: assign memory regions to ich9 lpc device

Get rid of get_system_io() usage.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

apci: assign memory regions to piix4 acpi device

Get rid of get_system_io() usage.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

acpi: autoload dsdt

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

configure: also symlink *.aml files

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

pty: unbreak libvirt

Commit 586502189edf9fd0f89a83de96717a2ea826fdb0 breaks libvirt pty
support because it tried to figure the pts name from stderr output.

Fix this by moving the label to the end of the line, this way the
libvirt parser does still recognise the message.  libvirt looks
for "char device redirected to ${ptsname}<whitespace>".

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>