]> git.proxmox.com Git - qemu.git/commitdiff
spice: drop incorrect vm_change_state_handler() opaque
authorStefan Hajnoczi <stefanha@redhat.com>
Wed, 19 Dec 2012 13:07:16 +0000 (14:07 +0100)
committerStefan Hajnoczi <stefanha@redhat.com>
Fri, 4 Jan 2013 13:38:05 +0000 (14:38 +0100)
The spice_server pointer is a global variable and
vm_change_state_handler() therefore does not use its opaque parameter.

The vm change state handler is added with a pointer to the spice_server
pointer.  This is useless and we probably would not want 2 levels of
pointers.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Uri Lublin <uril@redhat.com>
ui/spice-core.c

index 3e44779107d71e019864f940e99b6f477c9b31fa..d83de2a46e5068e71281783622fcc1636a05d4f1 100644 (file)
@@ -709,7 +709,7 @@ void qemu_spice_init(void)
     qemu_spice_input_init();
     qemu_spice_audio_init();
 
-    qemu_add_vm_change_state_handler(vm_change_state_handler, &spice_server);
+    qemu_add_vm_change_state_handler(vm_change_state_handler, NULL);
 
     g_free(x509_key_file);
     g_free(x509_cert_file);
@@ -736,8 +736,7 @@ int qemu_spice_add_interface(SpiceBaseInstance *sin)
          */
         spice_server = spice_server_new();
         spice_server_init(spice_server, &core_interface);
-        qemu_add_vm_change_state_handler(vm_change_state_handler,
-                                         &spice_server);
+        qemu_add_vm_change_state_handler(vm_change_state_handler, NULL);
     }
 
     return spice_server_add_interface(spice_server, sin);